diff mbox series

[2/8] ARM: dragonboard820c: Disable network support

Message ID 20210402214801.1159432-2-pbrobinson@gmail.com
State Under Review
Delegated to: Kever Yang
Headers show
Series [1/8] ARM: dragonboard410c: Enable DM_ETH | expand

Commit Message

Peter Robinson April 2, 2021, 9:47 p.m. UTC
There's not currently any network support on the 820c but
the minor network config still triggers the DM_ETH warning
even though there's no even a USB network interface so lets
disable network support to mitigate the warning.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Cc: Jorge Ramirez-Ortiz <jorge.ramirez.ortiz@gmail.com>
---
 configs/dragonboard820c_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Jorge Ramirez-Ortiz, Gmail April 4, 2021, 8:20 p.m. UTC | #1
On 02/04/21, Peter Robinson wrote:
> There's not currently any network support on the 820c but
> the minor network config still triggers the DM_ETH warning
> even though there's no even a USB network interface so lets
> disable network support to mitigate the warning.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Cc: Jorge Ramirez-Ortiz <jorge.ramirez.ortiz@gmail.com>
> ---
>  configs/dragonboard820c_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/dragonboard820c_defconfig b/configs/dragonboard820c_defconfig
> index 13cffd9713..6489376a34 100644
> --- a/configs/dragonboard820c_defconfig
> +++ b/configs/dragonboard820c_defconfig
> @@ -14,6 +14,7 @@ CONFIG_BOOTARGS="console=ttyMSM0,115200n8"
>  # CONFIG_DISPLAY_BOARDINFO is not set
>  CONFIG_MISC_INIT_R=y
>  CONFIG_SYS_PROMPT="dragonboard820c => "
> +# CONFIG_NET is not set

yeah, looks good to me. In the past - at the time support was added -
I think NET was required for sysconf boot (IIRC was combined with pxe
but I could be wrong)

>  CONFIG_CMD_BOOTEFI_HELLO=y
>  CONFIG_CMD_MD5SUM=y
>  CONFIG_CMD_MEMINFO=y

btw I tried to boot the tip of u-boot and mmc is not recognized after
boot (so maybe some pinctrl issue lurking).


> -- 
> 2.31.1
>
diff mbox series

Patch

diff --git a/configs/dragonboard820c_defconfig b/configs/dragonboard820c_defconfig
index 13cffd9713..6489376a34 100644
--- a/configs/dragonboard820c_defconfig
+++ b/configs/dragonboard820c_defconfig
@@ -14,6 +14,7 @@  CONFIG_BOOTARGS="console=ttyMSM0,115200n8"
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_MISC_INIT_R=y
 CONFIG_SYS_PROMPT="dragonboard820c => "
+# CONFIG_NET is not set
 CONFIG_CMD_BOOTEFI_HELLO=y
 CONFIG_CMD_MD5SUM=y
 CONFIG_CMD_MEMINFO=y