diff mbox series

ls1012a: use default scan_dev_for_boot

Message ID 20210330140414.19452-1-yousaf.kaukab@suse.com
State Accepted
Commit a98550236f803c5a4fb6fe489bc9aff315b388eb
Delegated to: Priyanka Jain
Headers show
Series ls1012a: use default scan_dev_for_boot | expand

Commit Message

Mian Yousaf Kaukab March 30, 2021, 2:04 p.m. UTC
From: Mian Yousaf Kaukab <ykaukab@suse.de>

scan_dev_for_efi is supposed to be called from scan_dev_for_boot.
However, this call is missing for ls1012a boards. As a result EFI
boot doesn’t work. Fix this issue by removing custom definition of
scan_dev_for_boot and use the default definition instead.

Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
---
 include/configs/ls1012a2g5rdb.h | 7 -------
 include/configs/ls1012afrdm.h   | 7 -------
 include/configs/ls1012afrwy.h   | 7 -------
 include/configs/ls1012aqds.h    | 7 -------
 include/configs/ls1012ardb.h    | 7 -------
 5 files changed, 35 deletions(-)

Comments

Priyanka Jain March 31, 2021, 4:45 a.m. UTC | #1
>-----Original Message-----
>From: Mian Yousaf Kaukab <yousaf.kaukab@suse.com>
>Sent: Tuesday, March 30, 2021 7:34 PM
>To: u-boot@lists.denx.de; Priyanka Jain <priyanka.jain@nxp.com>
>Cc: Andy Tang <andy.tang@nxp.com>; Biwen Li <biwen.li@nxp.com>; Pramod
>Kumar <pramod.kumar_1@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>;
>Mian Yousaf Kaukab <ykaukab@suse.de>
>Subject: [PATCH] ls1012a: use default scan_dev_for_boot
>
>From: Mian Yousaf Kaukab <ykaukab@suse.de>
>
>scan_dev_for_efi is supposed to be called from scan_dev_for_boot.
>However, this call is missing for ls1012a boards. As a result EFI boot doesn’t work.
>Fix this issue by removing custom definition of scan_dev_for_boot and use the
>default definition instead.
>
>Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
>---
> include/configs/ls1012a2g5rdb.h | 7 -------
> include/configs/ls1012afrdm.h   | 7 -------
> include/configs/ls1012afrwy.h   | 7 -------
> include/configs/ls1012aqds.h    | 7 -------
> include/configs/ls1012ardb.h    | 7 -------
> 5 files changed, 35 deletions(-)
>
>diff --git a/include/configs/ls1012a2g5rdb.h b/include/configs/ls1012a2g5rdb.h
>index bbc3ffd7f0d3..9962b9872af5 100644
>--- a/include/configs/ls1012a2g5rdb.h
>+++ b/include/configs/ls1012a2g5rdb.h
>@@ -61,13 +61,6 @@
> 		      "run scan_dev_for_boot; "	\
> 		  "fi; "			\
> 	      "done\0"				\
>-	"scan_dev_for_boot="				  \
>-		"echo Scanning ${devtype} "		  \
>-				"${devnum}:${distro_bootpart}...; "  \
>-		"for prefix in ${boot_prefixes}; do "	  \
>-			"run scan_dev_for_scripts; "	  \
>-		"done;"					  \
>-		"\0"					  \
> 	"boot_a_script="				  \
> 		"load ${devtype} ${devnum}:${distro_bootpart} "  \
> 			"${scriptaddr} ${prefix}${script}; "    \
>diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h index
>8de20e3ff450..02dd59892bcc 100644
>--- a/include/configs/ls1012afrdm.h
>+++ b/include/configs/ls1012afrdm.h
>@@ -47,13 +47,6 @@
> 		      "run scan_dev_for_boot; "	\
> 		  "fi; "			\
> 	      "done\0"				\
>-	"scan_dev_for_boot="				  \
>-		"echo Scanning ${devtype} "		  \
>-				"${devnum}:${distro_bootpart}...; "  \
>-		"for prefix in ${boot_prefixes}; do "	  \
>-			"run scan_dev_for_scripts; "	  \
>-		"done;"					  \
>-		"\0"					  \
> 	"installer=load usb 0:2 $load_addr "	\
> 		   "/flex_installer_arm64.itb; "	\
> 		   "bootm $load_addr#$board\0"	\
>diff --git a/include/configs/ls1012afrwy.h b/include/configs/ls1012afrwy.h index
>29c344c63a95..ba152834d5ac 100644
>--- a/include/configs/ls1012afrwy.h
>+++ b/include/configs/ls1012afrwy.h
>@@ -80,13 +80,6 @@
> 		      "run scan_dev_for_boot; "	\
> 		  "fi; "			\
> 	      "done\0"				\
>-	"scan_dev_for_boot="				  \
>-		"echo Scanning ${devtype} "		  \
>-				"${devnum}:${distro_bootpart}...; "  \
>-		"for prefix in ${boot_prefixes}; do "	  \
>-			"run scan_dev_for_scripts; "	  \
>-		"done;"					  \
>-		"\0"					  \
> 	"boot_a_script="				  \
> 		"load ${devtype} ${devnum}:${distro_bootpart} "  \
> 			"${scriptaddr} ${prefix}${script}; "    \
>diff --git a/include/configs/ls1012aqds.h b/include/configs/ls1012aqds.h index
>c4c9b7f5019f..36be8f42c978 100644
>--- a/include/configs/ls1012aqds.h
>+++ b/include/configs/ls1012aqds.h
>@@ -131,13 +131,6 @@
> 		      "run scan_dev_for_boot; "	\
> 		  "fi; "			\
> 	      "done\0"				\
>-	"scan_dev_for_boot="				  \
>-		"echo Scanning ${devtype} "		  \
>-				"${devnum}:${distro_bootpart}...; "  \
>-		"for prefix in ${boot_prefixes}; do "	  \
>-			"run scan_dev_for_scripts; "	  \
>-		"done;"					  \
>-		"\0"					  \
> 	"boot_a_script="				  \
> 		"load ${devtype} ${devnum}:${distro_bootpart} "  \
> 			"${scriptaddr} ${prefix}${script}; "    \
>diff --git a/include/configs/ls1012ardb.h b/include/configs/ls1012ardb.h index
>94e742ee8446..582945b2ab19 100644
>--- a/include/configs/ls1012ardb.h
>+++ b/include/configs/ls1012ardb.h
>@@ -79,13 +79,6 @@
> 		      "run scan_dev_for_boot; "	\
> 		  "fi; "			\
> 	      "done\0"				\
>-	"scan_dev_for_boot="				  \
>-		"echo Scanning ${devtype} "		  \
>-				"${devnum}:${distro_bootpart}...; "  \
>-		"for prefix in ${boot_prefixes}; do "	  \
>-			"run scan_dev_for_scripts; "	  \
>-		"done;"					  \
>-		"\0"					  \
> 	"boot_a_script="				  \
> 		"load ${devtype} ${devnum}:${distro_bootpart} "  \
> 			"${scriptaddr} ${prefix}${script}; "    \
>--
>2.26.2

Reviewed-by: Priyanka Jain <priyanka.jain@nxp.com>
diff mbox series

Patch

diff --git a/include/configs/ls1012a2g5rdb.h b/include/configs/ls1012a2g5rdb.h
index bbc3ffd7f0d3..9962b9872af5 100644
--- a/include/configs/ls1012a2g5rdb.h
+++ b/include/configs/ls1012a2g5rdb.h
@@ -61,13 +61,6 @@ 
 		      "run scan_dev_for_boot; "	\
 		  "fi; "			\
 	      "done\0"				\
-	"scan_dev_for_boot="				  \
-		"echo Scanning ${devtype} "		  \
-				"${devnum}:${distro_bootpart}...; "  \
-		"for prefix in ${boot_prefixes}; do "	  \
-			"run scan_dev_for_scripts; "	  \
-		"done;"					  \
-		"\0"					  \
 	"boot_a_script="				  \
 		"load ${devtype} ${devnum}:${distro_bootpart} "  \
 			"${scriptaddr} ${prefix}${script}; "    \
diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h
index 8de20e3ff450..02dd59892bcc 100644
--- a/include/configs/ls1012afrdm.h
+++ b/include/configs/ls1012afrdm.h
@@ -47,13 +47,6 @@ 
 		      "run scan_dev_for_boot; "	\
 		  "fi; "			\
 	      "done\0"				\
-	"scan_dev_for_boot="				  \
-		"echo Scanning ${devtype} "		  \
-				"${devnum}:${distro_bootpart}...; "  \
-		"for prefix in ${boot_prefixes}; do "	  \
-			"run scan_dev_for_scripts; "	  \
-		"done;"					  \
-		"\0"					  \
 	"installer=load usb 0:2 $load_addr "	\
 		   "/flex_installer_arm64.itb; "	\
 		   "bootm $load_addr#$board\0"	\
diff --git a/include/configs/ls1012afrwy.h b/include/configs/ls1012afrwy.h
index 29c344c63a95..ba152834d5ac 100644
--- a/include/configs/ls1012afrwy.h
+++ b/include/configs/ls1012afrwy.h
@@ -80,13 +80,6 @@ 
 		      "run scan_dev_for_boot; "	\
 		  "fi; "			\
 	      "done\0"				\
-	"scan_dev_for_boot="				  \
-		"echo Scanning ${devtype} "		  \
-				"${devnum}:${distro_bootpart}...; "  \
-		"for prefix in ${boot_prefixes}; do "	  \
-			"run scan_dev_for_scripts; "	  \
-		"done;"					  \
-		"\0"					  \
 	"boot_a_script="				  \
 		"load ${devtype} ${devnum}:${distro_bootpart} "  \
 			"${scriptaddr} ${prefix}${script}; "    \
diff --git a/include/configs/ls1012aqds.h b/include/configs/ls1012aqds.h
index c4c9b7f5019f..36be8f42c978 100644
--- a/include/configs/ls1012aqds.h
+++ b/include/configs/ls1012aqds.h
@@ -131,13 +131,6 @@ 
 		      "run scan_dev_for_boot; "	\
 		  "fi; "			\
 	      "done\0"				\
-	"scan_dev_for_boot="				  \
-		"echo Scanning ${devtype} "		  \
-				"${devnum}:${distro_bootpart}...; "  \
-		"for prefix in ${boot_prefixes}; do "	  \
-			"run scan_dev_for_scripts; "	  \
-		"done;"					  \
-		"\0"					  \
 	"boot_a_script="				  \
 		"load ${devtype} ${devnum}:${distro_bootpart} "  \
 			"${scriptaddr} ${prefix}${script}; "    \
diff --git a/include/configs/ls1012ardb.h b/include/configs/ls1012ardb.h
index 94e742ee8446..582945b2ab19 100644
--- a/include/configs/ls1012ardb.h
+++ b/include/configs/ls1012ardb.h
@@ -79,13 +79,6 @@ 
 		      "run scan_dev_for_boot; "	\
 		  "fi; "			\
 	      "done\0"				\
-	"scan_dev_for_boot="				  \
-		"echo Scanning ${devtype} "		  \
-				"${devnum}:${distro_bootpart}...; "  \
-		"for prefix in ${boot_prefixes}; do "	  \
-			"run scan_dev_for_scripts; "	  \
-		"done;"					  \
-		"\0"					  \
 	"boot_a_script="				  \
 		"load ${devtype} ${devnum}:${distro_bootpart} "  \
 			"${scriptaddr} ${prefix}${script}; "    \