| Message ID | 20210317140138.11147-2-michael@walle.cc |
|---|---|
| State | Accepted |
| Commit | 73e553a280b1b0464c44dc912c8e47e5ba379208 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | mmc: fsl_esdhc: ls1028a workarounds | expand |
On 3/17/21 11:01 PM, Michael Walle wrote: > Since commit 8ee802f899ef ("mmc: fsl_esdhc: make sure delay chain locked > for HS400") HS400 mode is unreliable on LS1028A SoCs. Some workarounds are > missing for this SoC. > > Disable HS400 mode for now. > > Signed-off-by: Michael Walle <michael@walle.cc> It seems that this patch doesn't need. Because CONFIG_MMC_HS400_SUPPORT is re-enabling with [PATCH 4/4]. How about dropping Drop [PATCH 1/4] and [PATCH 4/4]? Best Regards, Jaehoon Chung > --- > configs/kontron_sl28_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configs/kontron_sl28_defconfig b/configs/kontron_sl28_defconfig > index 1c781e091c..0c6c1911d9 100644 > --- a/configs/kontron_sl28_defconfig > +++ b/configs/kontron_sl28_defconfig > @@ -70,7 +70,7 @@ CONFIG_I2C_SET_DEFAULT_BUS_NUM=y > CONFIG_I2C_DEFAULT_BUS_NUMBER=0 > CONFIG_I2C_MUX=y > CONFIG_DM_MMC=y > -CONFIG_MMC_HS400_SUPPORT=y > +CONFIG_MMC_HS200_SUPPORT=y > CONFIG_FSL_ESDHC=y > CONFIG_FSL_ESDHC_SUPPORT_ADMA2=y > CONFIG_DM_SPI_FLASH=y >
Am 2021-03-17 23:49, schrieb Jaehoon Chung: > On 3/17/21 11:01 PM, Michael Walle wrote: >> Since commit 8ee802f899ef ("mmc: fsl_esdhc: make sure delay chain >> locked >> for HS400") HS400 mode is unreliable on LS1028A SoCs. Some workarounds >> are >> missing for this SoC. >> >> Disable HS400 mode for now. >> >> Signed-off-by: Michael Walle <michael@walle.cc> > > It seems that this patch doesn't need. Because > CONFIG_MMC_HS400_SUPPORT is re-enabling with [PATCH 4/4]. > How about dropping Drop [PATCH 1/4] and [PATCH 4/4]? Please read the cover letter, if patch 2/4 and 3/4 will make it into the 2021.04 relase, sure both can be dropped. But if not, patch 1/4 is intented to go into the release while 2/4, 3/4 and 4/4 might get into the next relase. The reason is that I favor a working mmc boot in the next u-boot release for this board ;) -michael
On 3/18/21 7:59 AM, Michael Walle wrote: > Am 2021-03-17 23:49, schrieb Jaehoon Chung: >> On 3/17/21 11:01 PM, Michael Walle wrote: >>> Since commit 8ee802f899ef ("mmc: fsl_esdhc: make sure delay chain locked >>> for HS400") HS400 mode is unreliable on LS1028A SoCs. Some workarounds are >>> missing for this SoC. >>> >>> Disable HS400 mode for now. >>> >>> Signed-off-by: Michael Walle <michael@walle.cc> >> >> It seems that this patch doesn't need. Because >> CONFIG_MMC_HS400_SUPPORT is re-enabling with [PATCH 4/4]. >> How about dropping Drop [PATCH 1/4] and [PATCH 4/4]? > > Please read the cover letter, if patch 2/4 and 3/4 will make > it into the 2021.04 relase, sure both can be dropped. But if not, > patch 1/4 is intented to go into the release while 2/4, 3/4 and > 4/4 might get into the next relase. Sorry. I didn't read your cover-letter. At next time, i will read cover-letter, too. :) Best Regards, Jaehoon Chung > > The reason is that I favor a working mmc boot in the next > u-boot release for this board ;) > > -michael >
On Wed, Mar 17, 2021 at 03:01:35PM +0100, Michael Walle wrote: > Since commit 8ee802f899ef ("mmc: fsl_esdhc: make sure delay chain locked > for HS400") HS400 mode is unreliable on LS1028A SoCs. Some workarounds are > missing for this SoC. > > Disable HS400 mode for now. > > Signed-off-by: Michael Walle <michael@walle.cc> Applied to u-boot/master, thanks!
diff --git a/configs/kontron_sl28_defconfig b/configs/kontron_sl28_defconfig index 1c781e091c..0c6c1911d9 100644 --- a/configs/kontron_sl28_defconfig +++ b/configs/kontron_sl28_defconfig @@ -70,7 +70,7 @@ CONFIG_I2C_SET_DEFAULT_BUS_NUM=y CONFIG_I2C_DEFAULT_BUS_NUMBER=0 CONFIG_I2C_MUX=y CONFIG_DM_MMC=y -CONFIG_MMC_HS400_SUPPORT=y +CONFIG_MMC_HS200_SUPPORT=y CONFIG_FSL_ESDHC=y CONFIG_FSL_ESDHC_SUPPORT_ADMA2=y CONFIG_DM_SPI_FLASH=y
Since commit 8ee802f899ef ("mmc: fsl_esdhc: make sure delay chain locked for HS400") HS400 mode is unreliable on LS1028A SoCs. Some workarounds are missing for this SoC. Disable HS400 mode for now. Signed-off-by: Michael Walle <michael@walle.cc> --- configs/kontron_sl28_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)