| Message ID | 20210308215236.27722-2-tharvey@gateworks.com |
|---|---|
| State | Accepted |
| Commit | 72b3732d24f12b2279f93c05e6eb74452b2b284a |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [1/2] board: gateworks: venice: fix gsc_get_dev | expand |
On Mon, Mar 8, 2021 at 6:52 PM Tim Harvey <tharvey@gateworks.com> wrote: > > commit 03f1f78a9b44 ("spl: fit: Prefer a malloc()'d buffer for loading images")' > changed the way buffer allocation worked for SPL to a more flexible > method. > > For venice this caused breakage that is resolved by increasing the size > of CONFIG_SYS_SPL_MALLOC_SIZE as the current FIT slighly exceeds 512KiB. > > Additionally remove the unnecessary comment on CONFIG_SPL_BSS_MAX_SIZE > and CONFIG_SYS_SPL_MALLOC_SIZE as the size is obvious from the define. > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> commit 03f1f78a9b44 ("spl: fit: Prefer a malloc()'d buffer for loading images")' > changed the way buffer allocation worked for SPL to a more flexible > method. > For venice this caused breakage that is resolved by increasing the size > of CONFIG_SYS_SPL_MALLOC_SIZE as the current FIT slighly exceeds 512KiB. > Additionally remove the unnecessary comment on CONFIG_SPL_BSS_MAX_SIZE > and CONFIG_SYS_SPL_MALLOC_SIZE as the size is obvious from the define. > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > Reviewed-by: Fabio Estevam <festevam@gmail.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/include/configs/imx8mm_venice.h b/include/configs/imx8mm_venice.h index a406e91c84..91669255e1 100644 --- a/include/configs/imx8mm_venice.h +++ b/include/configs/imx8mm_venice.h @@ -19,9 +19,9 @@ #ifdef CONFIG_SPL_BUILD #define CONFIG_SPL_STACK 0x920000 #define CONFIG_SPL_BSS_START_ADDR 0x910000 -#define CONFIG_SPL_BSS_MAX_SIZE SZ_8K /* 8 KB */ +#define CONFIG_SPL_BSS_MAX_SIZE SZ_8K #define CONFIG_SYS_SPL_MALLOC_START 0x42200000 -#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K /* 512 KB */ +#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_1M /* malloc f used before GD_FLG_FULL_MALLOC_INIT set */ #define CONFIG_MALLOC_F_ADDR 0x930000
commit 03f1f78a9b44 ("spl: fit: Prefer a malloc()'d buffer for loading images")' changed the way buffer allocation worked for SPL to a more flexible method. For venice this caused breakage that is resolved by increasing the size of CONFIG_SYS_SPL_MALLOC_SIZE as the current FIT slighly exceeds 512KiB. Additionally remove the unnecessary comment on CONFIG_SPL_BSS_MAX_SIZE and CONFIG_SYS_SPL_MALLOC_SIZE as the size is obvious from the define. Signed-off-by: Tim Harvey <tharvey@gateworks.com> --- include/configs/imx8mm_venice.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)