| Message ID | 20210303095236.14970-1-pali@kernel.org |
|---|---|
| State | Accepted |
| Commit | 612a201d38b5a443665648057941d8c91c069816 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | fs/squashfs: Fix compilation error | expand |
On Wed, Mar 03, 2021 at 10:52:36AM +0100, Pali Rohár wrote: > Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop > asm/global_data.h from common header") broke compilation of squashfs > filesystem when CONFIG_CMD_SQUASHFS=y is enabled. > > Compilation is failing on error: > > aarch64-linux-gnu-ld.bfd: u-boot/fs/squashfs/sqfs_inode.c:121: undefined reference to `le32_to_cpu' > > Fixes: 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header") > Suggested-by: Tom Rini <trini@konsulko.com> > Signed-off-by: Pali Rohár <pali@kernel.org> Reviewed-by: Tom Rini <trini@konsulko.com>
On Wed, Mar 03, 2021 at 10:52:36AM +0100, Pali Rohár wrote: > Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop > asm/global_data.h from common header") broke compilation of squashfs > filesystem when CONFIG_CMD_SQUASHFS=y is enabled. > > Compilation is failing on error: > > aarch64-linux-gnu-ld.bfd: u-boot/fs/squashfs/sqfs_inode.c:121: undefined reference to `le32_to_cpu' > > Fixes: 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header") > Suggested-by: Tom Rini <trini@konsulko.com> > Signed-off-by: Pali Rohár <pali@kernel.org> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/fs/squashfs/sqfs_inode.c b/fs/squashfs/sqfs_inode.c index e76ec7cbdfd9..d25cfb53e75d 100644 --- a/fs/squashfs/sqfs_inode.c +++ b/fs/squashfs/sqfs_inode.c @@ -6,6 +6,7 @@ */ #include <asm/unaligned.h> +#include <compiler.h> #include <errno.h> #include <stdint.h> #include <stdio.h>
Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header") broke compilation of squashfs filesystem when CONFIG_CMD_SQUASHFS=y is enabled. Compilation is failing on error: aarch64-linux-gnu-ld.bfd: u-boot/fs/squashfs/sqfs_inode.c:121: undefined reference to `le32_to_cpu' Fixes: 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header") Suggested-by: Tom Rini <trini@konsulko.com> Signed-off-by: Pali Rohár <pali@kernel.org> --- Please include this change into U-Boot master branch which is currently affected by this issue. --- fs/squashfs/sqfs_inode.c | 1 + 1 file changed, 1 insertion(+)