diff mbox series

[03/20] net: phy: fixed: Remove non-DM prototype of phy_connect_fixed()

Message ID 20210302153451.19440-4-bmeng.cn@gmail.com
State Superseded
Delegated to: Priyanka Jain
Headers show
Series ppc: qemu: Add eTSEC support | expand

Commit Message

Bin Meng March 2, 2021, 3:34 p.m. UTC
CONFIG_PHY_FIXED depends on CONFIG_DM_ETH. Remove the non-DM version
prototype of phy_connect_fixed().

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 drivers/net/phy/phy.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Ramon Fried March 2, 2021, 5:42 p.m. UTC | #1
On Tue, Mar 2, 2021 at 5:35 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> CONFIG_PHY_FIXED depends on CONFIG_DM_ETH. Remove the non-DM version
> prototype of phy_connect_fixed().
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  drivers/net/phy/phy.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index f0522fc149..d08e8026ba 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -997,15 +997,9 @@ struct phy_device *fixed_phy_create(ofnode node)
>                                  false, interface);
>  }
>
> -#ifdef CONFIG_DM_ETH
>  static struct phy_device *phy_connect_fixed(struct mii_dev *bus,
>                                             struct udevice *dev,
>                                             phy_interface_t interface)
> -#else
> -static struct phy_device *phy_connect_fixed(struct mii_dev *bus,
> -                                           struct eth_device *dev,
> -                                           phy_interface_t interface)
> -#endif
>  {
>         struct phy_device *phydev = NULL;
>         int sn;
> --
> 2.25.1
>
Reviewed-By: Ramon Fried <rfried.dev@gmail.com>
diff mbox series

Patch

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index f0522fc149..d08e8026ba 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -997,15 +997,9 @@  struct phy_device *fixed_phy_create(ofnode node)
 				 false, interface);
 }
 
-#ifdef CONFIG_DM_ETH
 static struct phy_device *phy_connect_fixed(struct mii_dev *bus,
 					    struct udevice *dev,
 					    phy_interface_t interface)
-#else
-static struct phy_device *phy_connect_fixed(struct mii_dev *bus,
-					    struct eth_device *dev,
-					    phy_interface_t interface)
-#endif
 {
 	struct phy_device *phydev = NULL;
 	int sn;