From patchwork Sun Feb 28 14:12:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 1445256 X-Patchwork-Delegate: lokeshvutla@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=libero.it header.i=@libero.it header.a=rsa-sha256 header.s=s2021 header.b=QYft2cwx; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DpQPX3wWnz9rx6 for ; Mon, 1 Mar 2021 01:14:24 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2761E826A6; Sun, 28 Feb 2021 15:13:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=libero.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=libero.it header.i=@libero.it header.b="QYft2cwx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6244681444; Sun, 28 Feb 2021 15:13:07 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FROM, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from libero.it (smtp-17-i2.italiaonline.it [213.209.12.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5BB0C81444 for ; Sun, 28 Feb 2021 15:13:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=libero.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=dariobin@libero.it Received: from passgat-Modern-14-A10M.homenet.telecomitalia.it ([87.20.116.197]) by smtp-17.iol.local with ESMTPA id GMoXljE45lChfGMoelwAFF; Sun, 28 Feb 2021 15:13:00 +0100 x-libjamoibt: 1601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=libero.it; s=s2021; t=1614521580; bh=8gOyM0CO/oXKzmOEXqHKKjhLPt6bih2DX5nB2zly8wg=; h=From; b=QYft2cwx/mmi39nouinGJNb9P8wDaw4T42JuSFa4fWdxg/fWLtOLS7hrpANvmHqqZ 1FtT3YREjoeqkhPV1rlilinpEKOrHYZmK9ZtLVCPrtIkIa4fa7Whizng5v7NSsqYrA qBHgWPUTvVczSLgOKnmnHfAQ25o6yHQ5Gs4mj1dYPXUtG3Db+ca6kwSxsaruJZNxlb JGakLtBdtY+t1VhKJSYxUwc0q4sBwEnlaQr52KJANT8EOhgyHjLIUrq0aAEq7T3MuO Wt6zNDNrggDyOT2pDx5RoIFqarTHEMatlyD2qT3CDGJTGH2G+mXUf2hTGsFG9QZ7El AAipV3YPNYVNQ== X-CNFS-Analysis: v=2.4 cv=S6McfKgP c=1 sm=1 tr=0 ts=603ba4ec cx=a_exe a=AVqmXbCQpuNSdJmApS5GbQ==:117 a=AVqmXbCQpuNSdJmApS5GbQ==:17 a=sozttTNsAAAA:8 a=-Ek-Wcpen0pd0nQ6rpYA:9 a=aeg5Gbbo78KNqacMgKqU:22 From: Dario Binacchi To: u-boot@lists.denx.de Cc: Lokesh Vutla , Dario Binacchi , Patrick Delaunay , Pratyush Yadav , Simon Glass Subject: [PATCH v3 05/12] pinctrl: single: get register area size by device API Date: Sun, 28 Feb 2021 15:12:34 +0100 Message-Id: <20210228141241.15931-6-dariobin@libero.it> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210228141241.15931-1-dariobin@libero.it> References: <20210228141241.15931-1-dariobin@libero.it> X-CMAE-Envelope: MS4xfL8eiwZaH6CEcOGR37WazBixH2tbppefJIfJFAiahE55g09Ic3J5V3bBnHkldazQ8hZyfrC9SuEly6ZziLyC37/PojCpzpmkb2wJrZzKsl5V0uadWgFV yg698kTAiuMkJ5MH25qRwjnCdmh9vpet3jgpmjMNswalcInG2nn2TDtxPDZdcGPxLApMHafZIhvmXLIqNZXRVnp4tJNLr20bopaoosW954XmmEaR5UErY9o+ wh4w5Y7/gAHamneeXri8RsuGVtRJqyIC8fx0f4QGHiSLOMJILE5KMb7fqYeUOvTiJfT0UG+JZhmxVbMuSbQnl9p2e0GDVHqCMo8Wskvm/xIFbOT5cckfGsbN awiDY3FzqXOTvIJsdCur+Yr70bWv6w== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Use dev_read_addr_size to get size of the controller's register area. Signed-off-by: Dario Binacchi Reviewed-by: Pratyush Yadav --- Changes in v3: - Added Pratyush Yadav review tag. Changes in v2: - Check dev_read_addr_size return value. drivers/pinctrl/pinctrl-single.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index cec00e289c..d5656de8e8 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -182,17 +182,19 @@ static int single_set_state(struct udevice *dev, static int single_of_to_plat(struct udevice *dev) { fdt_addr_t addr; - u32 of_reg[2]; - int res; + fdt_size_t size; struct single_pdata *pdata = dev_get_plat(dev); pdata->width = dev_read_u32_default(dev, "pinctrl-single,register-width", 0); - res = dev_read_u32_array(dev, "reg", of_reg, 2); - if (res) - return res; - pdata->offset = of_reg[1] - pdata->width / 8; + addr = dev_read_addr_size(dev, "reg", &size); + if (addr == FDT_ADDR_T_NONE) { + dev_err(dev, "failed to get base register size\n"); + return -EINVAL; + } + + pdata->offset = size - pdata->width / BITS_PER_BYTE; addr = dev_read_addr(dev); if (addr == FDT_ADDR_T_NONE) {