From patchwork Wed Feb 24 23:25:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Farhan Ali X-Patchwork-Id: 1444097 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=daeVvnhb; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DmClW4yVLz9sVR for ; Thu, 25 Feb 2021 11:07:18 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A289A804EA; Thu, 25 Feb 2021 01:07:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.b="daeVvnhb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BCA78801E9; Thu, 25 Feb 2021 00:26:06 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MIME_NO_TEXT,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.2 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 13C2480040 for ; Thu, 25 Feb 2021 00:26:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=farhan.ali@broadcom.com Received: by mail-pg1-x530.google.com with SMTP id p21so2526060pgl.12 for ; Wed, 24 Feb 2021 15:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:mime-version; bh=H0bknSMIHNaSZbfV2s54gmcwmT38YfeKw4sAGm+iTcs=; b=daeVvnhb9E+cN1X2SbjndoGNsEzEsGBZKE7/uEw3ZOelGq2NhEVdVgokILkMoHrNLi mGMLGvEaKEZ7hdLLfZRYiu2HMcOMjhXowE6o8eH/XKZS/vtOmiXW1JiRbId9LbWLQQW/ JPCJHoVNdiSLztzWaMmRkLNz80ObwwqGT9etQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=H0bknSMIHNaSZbfV2s54gmcwmT38YfeKw4sAGm+iTcs=; b=BogIOZ54OVH8kXrRqqRaVUOWIxfe7Zzl4QMRBhnrSbDCg/EPSlP4FOT62lTbyeFBEi ycYdTHmF1vGiEikd2NKirNC/r4wsXoN/e3FLvhrZnAoDz6RapfXdb6PVSENP+KiNfHle xOO2s70z5pVuEgaEiOrmMNFBMSX3hKITpbTAVXaXsUuwX12vU7Yao0cHNf0oIV8DlmZd mziUCmKx883WdGyr3NS2qTKC23XYUJqGtw6pTotyxVMH/0F89CQZ/4lrOwMufeVqwb1G rh+Wucs+IdZOz+uONw0XrNjG74AAoGlTC7lbwKpO1w+016bd3TgWQW/q1aoHd7LeZp2V efLA== X-Gm-Message-State: AOAM53266RhZgiSnV21taKZ7ISRJWVG+/ycnY/0Szuzcs7hrB0bRBNXX f7CLl354Krqzg7DA+FMRny0V4o0cmDnukgQdkhljN/gBHbyLlPf9QHc5/XjSMP9qsmlf6sF+OqA 19Q8EEHyp5d6iEYfbBN3mMUtBqfPf0nfSlVtMDAQiaos1vkoaSU8RBa7cDnitemApbNJbmbchZY 4= X-Google-Smtp-Source: ABdhPJw4e6YTnBZj2NcEd/EY+JtvkX4i6kasOX1arGKGysLAJvGcKi/tOnefIOTI6aRgPXOlJ23AfA== X-Received: by 2002:aa7:93d2:0:b029:1ee:1433:85b7 with SMTP id y18-20020aa793d20000b02901ee143385b7mr391586pff.12.1614209160924; Wed, 24 Feb 2021 15:26:00 -0800 (PST) Received: from xl-irv-13.lvn.broadcom.net ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id x9sm3824864pjp.3.2021.02.24.15.26.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Feb 2021 15:26:00 -0800 (PST) From: Farhan Ali To: u-boot@lists.denx.de Cc: Farhan Ali , Simon Glass Subject: [PATCH] mtd: Update fail_addr when erase fails due to bad blocks Date: Wed, 24 Feb 2021 15:25:53 -0800 Message-Id: <20210224232553.23477-1-farhan.ali@broadcom.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 25 Feb 2021 01:06:57 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean For all other erase failures, the fail_addr is updated with the failing address. Only in the case of erase failure due to bad block detection, the fail_addr is not updated. This change simply updates the fail_addr for this specific scenario so that it is consistent with the rest of the code. Signed-off-by: Farhan Ali --- Cc: Simon Glass drivers/mtd/nand/raw/nand_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index 6557fad..3679ee7 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -3559,6 +3559,8 @@ int nand_erase_nand(struct mtd_info *mtd, struct erase_info *instr, pr_warn("%s: attempt to erase a bad block at page 0x%08x\n", __func__, page); instr->state = MTD_ERASE_FAILED; + instr->fail_addr = + ((loff_t)page << chip->page_shift); goto erase_exit; }