| Message ID | 20210224111907.3.I5f01e1c1c0c7f0d06dec0c0af215c1e476d730de@changeid |
|---|---|
| State | Accepted |
| Commit | 1b9ad5198afa4d6c39ec605935dab468f7559b9e |
| Delegated to: | Patrice Chotard |
| Headers | show |
| Series | stm32mp1_trusted_defconfig rely on SCMI support | expand |
Hi Patrick On 2/24/21 11:19 AM, Patrick Delaunay wrote: > Include the file needed for log function prototype, this patch solves the > compilation issue for undefined reference to `dev_err'. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > drivers/firmware/scmi/smccc_agent.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/scmi/smccc_agent.c b/drivers/firmware/scmi/smccc_agent.c > index 64d0929f69..81c2884bb7 100644 > --- a/drivers/firmware/scmi/smccc_agent.c > +++ b/drivers/firmware/scmi/smccc_agent.c > @@ -9,6 +9,7 @@ > #include <scmi_agent.h> > #include <scmi_agent-uclass.h> > #include <dm/devres.h> > +#include <dm/device_compat.h> > #include <dm/device-internal.h> > #include <linux/arm-smccc.h> > #include <linux/compat.h> > Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> Thanks Patrice
Hi Patrick On 2/24/21 11:19 AM, Patrick Delaunay wrote: > Include the file needed for log function prototype, this patch solves the > compilation issue for undefined reference to `dev_err'. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > drivers/firmware/scmi/smccc_agent.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/scmi/smccc_agent.c b/drivers/firmware/scmi/smccc_agent.c > index 64d0929f69..81c2884bb7 100644 > --- a/drivers/firmware/scmi/smccc_agent.c > +++ b/drivers/firmware/scmi/smccc_agent.c > @@ -9,6 +9,7 @@ > #include <scmi_agent.h> > #include <scmi_agent-uclass.h> > #include <dm/devres.h> > +#include <dm/device_compat.h> > #include <dm/device-internal.h> > #include <linux/arm-smccc.h> > #include <linux/compat.h> > Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> Thanks Patrice
HI On 3/9/21 2:03 PM, Patrice CHOTARD wrote: > Hi Patrick > > On 2/24/21 11:19 AM, Patrick Delaunay wrote: >> Include the file needed for log function prototype, this patch solves the >> compilation issue for undefined reference to `dev_err'. >> >> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> >> --- >> >> drivers/firmware/scmi/smccc_agent.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/firmware/scmi/smccc_agent.c b/drivers/firmware/scmi/smccc_agent.c >> index 64d0929f69..81c2884bb7 100644 >> --- a/drivers/firmware/scmi/smccc_agent.c >> +++ b/drivers/firmware/scmi/smccc_agent.c >> @@ -9,6 +9,7 @@ >> #include <scmi_agent.h> >> #include <scmi_agent-uclass.h> >> #include <dm/devres.h> >> +#include <dm/device_compat.h> >> #include <dm/device-internal.h> >> #include <linux/arm-smccc.h> >> #include <linux/compat.h> >> > > Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> > > Thanks > Patrice > Applied to u-boot-stm/next Thanks Patrice
diff --git a/drivers/firmware/scmi/smccc_agent.c b/drivers/firmware/scmi/smccc_agent.c index 64d0929f69..81c2884bb7 100644 --- a/drivers/firmware/scmi/smccc_agent.c +++ b/drivers/firmware/scmi/smccc_agent.c @@ -9,6 +9,7 @@ #include <scmi_agent.h> #include <scmi_agent-uclass.h> #include <dm/devres.h> +#include <dm/device_compat.h> #include <dm/device-internal.h> #include <linux/arm-smccc.h> #include <linux/compat.h>
Include the file needed for log function prototype, this patch solves the compilation issue for undefined reference to `dev_err'. Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> --- drivers/firmware/scmi/smccc_agent.c | 1 + 1 file changed, 1 insertion(+)