| Message ID | 20210220090524.76841-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 97401d0dbcd71d34fee95e3d89736699e78a9c6b |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [1/1] x86: sizeof-array-div error in lpc_common_early_init | expand |
On Sat, 20 Feb 2021 at 02:05, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > Building qemu-x86_64_defconfig with GCC 11.0 fails with: > > arch/x86/cpu/intel_common/lpc.c: > In function ‘lpc_common_early_init’: > arch/x86/cpu/intel_common/lpc.c:56:40: > error: expression does not compute the number of elements in this array; > element type is ‘struct reg_info’, not ‘u32’ {aka ‘unsigned int’} > [-Werror=sizeof-array-div] > 56 | sizeof(values) / sizeof(u32)); > | ^ > arch/x86/cpu/intel_common/lpc.c:56:40: note: add parentheses around the > second ‘sizeof’ to silence this warning > arch/x86/cpu/intel_common/lpc.c:50:11: note: array ‘values’ declared here > 50 | } values[4], *ptr; > | ^~~~~~ > > Add parentheses to silence warning. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > arch/x86/cpu/intel_common/lpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Sat, Feb 20, 2021 at 5:05 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > Building qemu-x86_64_defconfig with GCC 11.0 fails with: > > arch/x86/cpu/intel_common/lpc.c: > In function ‘lpc_common_early_init’: > arch/x86/cpu/intel_common/lpc.c:56:40: > error: expression does not compute the number of elements in this array; > element type is ‘struct reg_info’, not ‘u32’ {aka ‘unsigned int’} > [-Werror=sizeof-array-div] > 56 | sizeof(values) / sizeof(u32)); > | ^ > arch/x86/cpu/intel_common/lpc.c:56:40: note: add parentheses around the > second ‘sizeof’ to silence this warning > arch/x86/cpu/intel_common/lpc.c:50:11: note: array ‘values’ declared here > 50 | } values[4], *ptr; > | ^~~~~~ > > Add parentheses to silence warning. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > arch/x86/cpu/intel_common/lpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Thu, Feb 25, 2021 at 9:18 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Sat, Feb 20, 2021 at 5:05 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > > > Building qemu-x86_64_defconfig with GCC 11.0 fails with: > > > > arch/x86/cpu/intel_common/lpc.c: > > In function ‘lpc_common_early_init’: > > arch/x86/cpu/intel_common/lpc.c:56:40: > > error: expression does not compute the number of elements in this array; > > element type is ‘struct reg_info’, not ‘u32’ {aka ‘unsigned int’} > > [-Werror=sizeof-array-div] > > 56 | sizeof(values) / sizeof(u32)); > > | ^ > > arch/x86/cpu/intel_common/lpc.c:56:40: note: add parentheses around the > > second ‘sizeof’ to silence this warning > > arch/x86/cpu/intel_common/lpc.c:50:11: note: array ‘values’ declared here > > 50 | } values[4], *ptr; > > | ^~~~~~ > > > > Add parentheses to silence warning. > > > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > > --- > > arch/x86/cpu/intel_common/lpc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
diff --git a/arch/x86/cpu/intel_common/lpc.c b/arch/x86/cpu/intel_common/lpc.c index 23befbef15..f31fddb6fa 100644 --- a/arch/x86/cpu/intel_common/lpc.c +++ b/arch/x86/cpu/intel_common/lpc.c @@ -53,7 +53,7 @@ int lpc_common_early_init(struct udevice *dev) count = fdtdec_get_int_array_count(gd->fdt_blob, dev_of_offset(dev), "intel,gen-dec", (u32 *)values, - sizeof(values) / sizeof(u32)); + sizeof(values) / (sizeof(u32))); if (count < 0) return -EINVAL;
Building qemu-x86_64_defconfig with GCC 11.0 fails with: arch/x86/cpu/intel_common/lpc.c: In function ‘lpc_common_early_init’: arch/x86/cpu/intel_common/lpc.c:56:40: error: expression does not compute the number of elements in this array; element type is ‘struct reg_info’, not ‘u32’ {aka ‘unsigned int’} [-Werror=sizeof-array-div] 56 | sizeof(values) / sizeof(u32)); | ^ arch/x86/cpu/intel_common/lpc.c:56:40: note: add parentheses around the second ‘sizeof’ to silence this warning arch/x86/cpu/intel_common/lpc.c:50:11: note: array ‘values’ declared here 50 | } values[4], *ptr; | ^~~~~~ Add parentheses to silence warning. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- arch/x86/cpu/intel_common/lpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.0