| Message ID | 20210209083813.55765-2-oleksandr.suvorov@toradex.com |
|---|---|
| State | Accepted |
| Commit | e5da517c285ad389547cc80f8eadf5687a2d2fa2 |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | Improve iMX8 FEC ENET MAC settings | expand |
On 2/9/21 9:38 AM, Oleksandr Suvorov wrote: > Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC. > Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this > definition from configs of boards, based on MX8/MX8X. Acked-by: Marek Vasut <marex@denx.de> +CC Ramon
On Tue, Feb 9, 2021 at 10:41 AM Marek Vasut <marex@denx.de> wrote: > > On 2/9/21 9:38 AM, Oleksandr Suvorov wrote: > > Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC. > > Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this > > definition from configs of boards, based on MX8/MX8X. > > Acked-by: Marek Vasut <marex@denx.de> > > +CC Ramon Reviewed-By: Ramon Fried <rfried.dev@gmail.com>
On 09/02/21, Oleksandr Suvorov wrote: > Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC. > Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this > definition from configs of boards, based on MX8/MX8X. > > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com> Acked-by: Oliver Graute <oliver.graute@kococonnector.com>
Hi Oleksandr, On Tue, Feb 9, 2021 at 5:39 AM Oleksandr Suvorov <oleksandr.suvorov@toradex.com> wrote: > > Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC. > Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this > definition from configs of boards, based on MX8/MX8X. > > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC. > Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this > definition from configs of boards, based on MX8/MX8X. > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com> > Acked-by: Marek Vasut <marex@denx.de> > Reviewed-By: Ramon Fried <rfried.dev@gmail.com> > Acked-by: Oliver Graute <oliver.graute@kococonnector.com> > Reviewed-by: Fabio Estevam <festevam@gmail.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/include/asm/arch-imx8/imx-regs.h b/arch/arm/include/asm/arch-imx8/imx-regs.h index 6333ff4686..ed6e05e556 100644 --- a/arch/arm/include/asm/arch-imx8/imx-regs.h +++ b/arch/arm/include/asm/arch-imx8/imx-regs.h @@ -26,6 +26,8 @@ #define LPI2C4_BASE_ADDR 0x5A830000 #define LPI2C5_BASE_ADDR 0x5A840000 +#define FEC_QUIRK_ENET_MAC + #ifdef CONFIG_IMX8QXP #define LVDS0_PHYCTRL_BASE 0x56221000 #define LVDS1_PHYCTRL_BASE 0x56241000 diff --git a/include/configs/apalis-imx8.h b/include/configs/apalis-imx8.h index b474b2f522..0260eb4019 100644 --- a/include/configs/apalis-imx8.h +++ b/include/configs/apalis-imx8.h @@ -21,7 +21,6 @@ #define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG /* Networking */ -#define FEC_QUIRK_ENET_MAC #define FEC_ENET_ENABLE_TXC_DELAY #define CONFIG_TFTP_TSIZE diff --git a/include/configs/apalis-imx8x.h b/include/configs/apalis-imx8x.h index db31c210f5..a84b8e684b 100644 --- a/include/configs/apalis-imx8x.h +++ b/include/configs/apalis-imx8x.h @@ -143,7 +143,6 @@ #define CONFIG_FEC_MXC_PHYADDR 0x4 #define CONFIG_ETHPRIME "eth0" #define CONFIG_FEC_XCV_TYPE RGMII -#define FEC_QUIRK_ENET_MAC #define PHY_ANEG_TIMEOUT 20000 #endif /* __APALIS_IMX8X_H */ diff --git a/include/configs/capricorn-common.h b/include/configs/capricorn-common.h index 7c168f17d5..b310e6c9e5 100644 --- a/include/configs/capricorn-common.h +++ b/include/configs/capricorn-common.h @@ -43,7 +43,6 @@ /* ENET Config */ #define CONFIG_FEC_XCV_TYPE RMII -#define FEC_QUIRK_ENET_MAC /* ENET1 connects to base board and MUX with ESAI */ #define CONFIG_FEC_ENET_DEV 1 diff --git a/include/configs/colibri-imx8x.h b/include/configs/colibri-imx8x.h index fc2c191594..59593f6c00 100644 --- a/include/configs/colibri-imx8x.h +++ b/include/configs/colibri-imx8x.h @@ -22,8 +22,6 @@ #define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG /* Networking */ -#define FEC_QUIRK_ENET_MAC - #define CONFIG_TFTP_TSIZE #define CONFIG_IPADDR 192.168.10.2 diff --git a/include/configs/imx8qm_mek.h b/include/configs/imx8qm_mek.h index ff281d3800..99e73a9446 100644 --- a/include/configs/imx8qm_mek.h +++ b/include/configs/imx8qm_mek.h @@ -173,6 +173,5 @@ /* Networking */ #define CONFIG_FEC_XCV_TYPE RGMII -#define FEC_QUIRK_ENET_MAC #endif /* __IMX8QM_MEK_H */ diff --git a/include/configs/imx8qm_rom7720.h b/include/configs/imx8qm_rom7720.h index e5989ebafb..fcbf8eeb34 100644 --- a/include/configs/imx8qm_rom7720.h +++ b/include/configs/imx8qm_rom7720.h @@ -161,7 +161,6 @@ /* Networking */ #define CONFIG_FEC_XCV_TYPE RGMII -#define FEC_QUIRK_ENET_MAC #include <linux/stringify.h> #endif /* __IMX8QM_ROM7720_H */ diff --git a/include/configs/imx8qxp_mek.h b/include/configs/imx8qxp_mek.h index 51a8eb6760..a7d623a9b9 100644 --- a/include/configs/imx8qxp_mek.h +++ b/include/configs/imx8qxp_mek.h @@ -177,7 +177,6 @@ /* Networking */ #define CONFIG_FEC_XCV_TYPE RGMII -#define FEC_QUIRK_ENET_MAC /* Misc configuration */ #define CONFIG_SYS_CBSIZE 2048
Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC. Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this definition from configs of boards, based on MX8/MX8X. Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com> --- arch/arm/include/asm/arch-imx8/imx-regs.h | 2 ++ include/configs/apalis-imx8.h | 1 - include/configs/apalis-imx8x.h | 1 - include/configs/capricorn-common.h | 1 - include/configs/colibri-imx8x.h | 2 -- include/configs/imx8qm_mek.h | 1 - include/configs/imx8qm_rom7720.h | 1 - include/configs/imx8qxp_mek.h | 1 - 8 files changed, 2 insertions(+), 8 deletions(-)