| Message ID | 20210205041119.145784-5-seanga2@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | spi: dw: Add support for DUAL/QUAD/OCTAL modes | expand |
On Fri, Feb 5, 2021 at 9:41 AM Sean Anderson <seanga2@gmail.com> wrote: > > This is useful for extending the default functionality. This mirrors the > change in Linux commit 46109648052f ("spi: spi-mem: export > spi_mem_default_supports_op()"). > > Signed-off-by: Sean Anderson <seanga2@gmail.com> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > Reviewed-by: Pratyush Yadav <p.yadav@ti.com> > --- > > (no changes since v1) > > include/spi-mem.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/spi-mem.h b/include/spi-mem.h > index ca0f55c8fd..1dd556b6cf 100644 > --- a/include/spi-mem.h > +++ b/include/spi-mem.h > @@ -236,6 +236,9 @@ spi_controller_dma_unmap_mem_op_data(struct spi_controller *ctlr, > > int spi_mem_adjust_op_size(struct spi_slave *slave, struct spi_mem_op *op); > > +bool spi_mem_default_supports_op(struct spi_slave *slave, > + const struct spi_mem_op *op); > + But, does it used anywhere now? if not it's better to add when it requires. Jagan.
On 2/26/21 5:22 AM, Jagan Teki wrote: > On Fri, Feb 5, 2021 at 9:41 AM Sean Anderson <seanga2@gmail.com> wrote: >> >> This is useful for extending the default functionality. This mirrors the >> change in Linux commit 46109648052f ("spi: spi-mem: export >> spi_mem_default_supports_op()"). >> >> Signed-off-by: Sean Anderson <seanga2@gmail.com> >> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> >> Reviewed-by: Pratyush Yadav <p.yadav@ti.com> >> --- >> >> (no changes since v1) >> >> include/spi-mem.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/spi-mem.h b/include/spi-mem.h >> index ca0f55c8fd..1dd556b6cf 100644 >> --- a/include/spi-mem.h >> +++ b/include/spi-mem.h >> @@ -236,6 +236,9 @@ spi_controller_dma_unmap_mem_op_data(struct spi_controller *ctlr, >> >> int spi_mem_adjust_op_size(struct spi_slave *slave, struct spi_mem_op *op); >> >> +bool spi_mem_default_supports_op(struct spi_slave *slave, >> + const struct spi_mem_op *op); >> + > > But, does it used anywhere now? if not it's better to add when it requires. > > Jagan. > Yes, it is used in this driver later in this series. --Sean
diff --git a/include/spi-mem.h b/include/spi-mem.h index ca0f55c8fd..1dd556b6cf 100644 --- a/include/spi-mem.h +++ b/include/spi-mem.h @@ -236,6 +236,9 @@ spi_controller_dma_unmap_mem_op_data(struct spi_controller *ctlr, int spi_mem_adjust_op_size(struct spi_slave *slave, struct spi_mem_op *op); +bool spi_mem_default_supports_op(struct spi_slave *slave, + const struct spi_mem_op *op); + bool spi_mem_supports_op(struct spi_slave *slave, const struct spi_mem_op *op); int spi_mem_exec_op(struct spi_slave *slave, const struct spi_mem_op *op);
This is useful for extending the default functionality. This mirrors the change in Linux commit 46109648052f ("spi: spi-mem: export spi_mem_default_supports_op()"). Signed-off-by: Sean Anderson <seanga2@gmail.com> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Pratyush Yadav <p.yadav@ti.com> --- (no changes since v1) include/spi-mem.h | 3 +++ 1 file changed, 3 insertions(+)