diff mbox series

[2/3] test: inconsistent string tests

Message ID 20210117231735.34139-2-xypron.glpk@gmx.de
State Accepted
Commit 9d43b4106e23a241b398544a6d2aa5bb541e62cb
Delegated to: Tom Rini
Headers show
Series [1/3] test: inconsistent bootm tests | expand

Commit Message

Heinrich Schuchardt Jan. 17, 2021, 11:17 p.m. UTC
Excluding ut str in test/cmd_ut.c but compiling test/str_ut.c results in
failure of the Python test invoking the C unit tests as observed on
sipeed_riscv_smode_defconfig:

FAILED test/py/tests/test_ut.py::test_ut[ut_str_upper]

Allow to compile test/str_ut.c on all boards.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 test/cmd_ut.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--
2.29.2

Comments

Simon Glass Jan. 19, 2021, 6:06 p.m. UTC | #1
On Sun, 17 Jan 2021 at 16:22, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Excluding ut str in test/cmd_ut.c but compiling test/str_ut.c results in
> failure of the Python test invoking the C unit tests as observed on
> sipeed_riscv_smode_defconfig:
>
> FAILED test/py/tests/test_ut.py::test_ut[ut_str_upper]
>
> Allow to compile test/str_ut.c on all boards.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  test/cmd_ut.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini Jan. 30, 2021, 7:21 p.m. UTC | #2
On Mon, Jan 18, 2021 at 12:17:34AM +0100, Heinrich Schuchardt wrote:

> Excluding ut str in test/cmd_ut.c but compiling test/str_ut.c results in
> failure of the Python test invoking the C unit tests as observed on
> sipeed_riscv_smode_defconfig:
> 
> FAILED test/py/tests/test_ut.py::test_ut[ut_str_upper]
> 
> Allow to compile test/str_ut.c on all boards.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/test/cmd_ut.c b/test/cmd_ut.c
index fad1c899a4..90674d5de5 100644
--- a/test/cmd_ut.c
+++ b/test/cmd_ut.c
@@ -89,9 +89,8 @@  static struct cmd_tbl cmd_ut_sub[] = {
 	U_BOOT_CMD_MKENT(bloblist, CONFIG_SYS_MAXARGS, 1, do_ut_bloblist,
 			 "", ""),
 	U_BOOT_CMD_MKENT(bootm, CONFIG_SYS_MAXARGS, 1, do_ut_bootm, "", ""),
-	U_BOOT_CMD_MKENT(str, CONFIG_SYS_MAXARGS, 1, do_ut_str,
-			 "", ""),
 #endif
+	U_BOOT_CMD_MKENT(str, CONFIG_SYS_MAXARGS, 1, do_ut_str, "", ""),
 };

 static int do_ut_all(struct cmd_tbl *cmdtp, int flag, int argc,