[05/15] gpio: Drop dm_gpio_set_dir()

Message ID	20210115140500.846307-6-sjg@chromium.org
State	Superseded
Delegated to:	Simon Glass
Headers	show Return-Path: <u-boot-bounces@lists.denx.de> From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Cc: Patrick Delaunay <patrick.delaunay@st.com>, Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>, Dario Binacchi <dariobin@libero.it>, Heiko Schocher <hs@denx.de>, Jean-Jacques Hiblot <jjhiblot@ti.com>, Patrick Delaunay <patrick.delaunay@foss.st.com>, Pratyush Yadav <p.yadav@ti.com>, Wolfgang Wallner <wolfgang.wallner@br-automation.com> Subject: [PATCH 05/15] gpio: Drop dm_gpio_set_dir() Date: Fri, 15 Jan 2021 07:04:50 -0700 Message-Id: <20210115140500.846307-6-sjg@chromium.org> In-Reply-To: <20210115140500.846307-1-sjg@chromium.org> References: <20210115140500.846307-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	gpio: Update and simplify the uclass API \| expand [00/15] gpio: Update and simplify the uclass API [01/15] gpio: Disable functions not used with of-platdata [02/15] dm: gpio: Rename set_dir_flags() method to update_flags() [03/15] dm: gpio: Rename get_dir_flags() method to get_flags() [04/15] gpio: Rename dm_gpio_get_dir_flags() to dm_gpio_get_flags() [05/15] gpio: Drop dm_gpio_set_dir() [06/15] gpio: sandbox: Rename GPIO dir_flags to flags [07/15] gpio: sandbox: Use a separate flag for the value [08/15] gpio: sandbox: Fully separate pin value from output value [09/15] gpio: sandbox: Make sandbox_gpio_set_flags() set all flags [10/15] dm: gpio: Add a way to update flags [11/15] gpio: Replace direction_input() and direction_output() [12/15] gpio: Use an 'ops' variable everywhere [13/15] gpio: x86: Drop the deprecated methods in intel_gpio [14/15] gpio: sandbox: Track whether a GPIO is driven [15/15] gpio: Add a way to read 3-way strapping pins

Message ID

20210115140500.846307-6-sjg@chromium.org

State

Superseded

Delegated to:

Simon Glass

Headers

From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Patrick Delaunay <patrick.delaunay@st.com>, Tom Rini <trini@konsulko.com>,
 Simon Glass <sjg@chromium.org>, Dario Binacchi <dariobin@libero.it>,
 Heiko Schocher <hs@denx.de>, Jean-Jacques Hiblot <jjhiblot@ti.com>,
 Patrick Delaunay <patrick.delaunay@foss.st.com>,
 Pratyush Yadav <p.yadav@ti.com>,
 Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Subject: [PATCH 05/15] gpio: Drop dm_gpio_set_dir()
Date: Fri, 15 Jan 2021 07:04:50 -0700
Message-Id: <20210115140500.846307-6-sjg@chromium.org>
In-Reply-To: <20210115140500.846307-1-sjg@chromium.org>
References: <20210115140500.846307-1-sjg@chromium.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

gpio: Update and simplify the uclass API | expand

This function is not used. Drop it. Signed-off-by: Simon Glass <sjg@chromium.org> --- drivers/gpio/gpio-uclass.c | 11 ----------- include/asm-generic/gpio.h | 11 ----------- 2 files changed, 22 deletions(-)

Comments

Patrick DELAUNAY Jan. 21, 2021, 9:06 a.m. UTC | #1

Hi Simon,

On 1/15/21 3:04 PM, Simon Glass wrote:
> This function is not used. Drop it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   drivers/gpio/gpio-uclass.c | 11 -----------
>   include/asm-generic/gpio.h | 11 -----------
>   2 files changed, 22 deletions(-)
>

Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks

Patrick

diff --git a/drivers/gpio/gpio-uclass.c b/drivers/gpio/gpio-uclass.c
index 864a9003245..aa0e3852122 100644
--- a/drivers/gpio/gpio-uclass.c
+++ b/drivers/gpio/gpio-uclass.c
@@ -671,17 +671,6 @@  int dm_gpio_set_dir_flags(struct gpio_desc *desc, ulong flags)
 	return ret;
 }
 
-int dm_gpio_set_dir(struct gpio_desc *desc)
-{
-	int ret;
-
-	ret = check_reserved(desc, "set_dir");
-	if (ret)
-		return ret;
-
-	return _dm_gpio_update_flags(desc, desc->flags);
-}
-
 int dm_gpio_get_flags(struct gpio_desc *desc, ulong *flagsp)
 {
 	struct udevice *dev = desc->dev;
diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h
index 5ecb73c138d..30ff5feb160 100644
--- a/include/asm-generic/gpio.h
+++ b/include/asm-generic/gpio.h
@@ -659,17 +659,6 @@  int dm_gpio_get_value(const struct gpio_desc *desc);
 
 int dm_gpio_set_value(const struct gpio_desc *desc, int value);
 
-/**
- * dm_gpio_set_dir() - Set the direction for a GPIO
- *
- * This sets up the direction according to the GPIO flags: desc->flags.
- *
- * @desc:	GPIO description containing device, offset and flags,
- *		previously returned by gpio_request_by_name()
- * @return 0 if OK, -ve on error
- */
-int dm_gpio_set_dir(struct gpio_desc *desc);
-
 /**
  * dm_gpio_set_dir_flags() - Set direction using description and added flags
  *

[05/15] gpio: Drop dm_gpio_set_dir()

Commit Message

Comments

Patch