diff mbox series

[1/2] samsung: arndale: remove board_mmc_init function

Message ID 20210112063054.10979-1-jh80.chung@samsung.com
State Accepted
Commit a654b6a5ae142a4d0d21b2cb89a39e39e9eda954
Delegated to: Minkyu Kang
Headers show
Series [1/2] samsung: arndale: remove board_mmc_init function | expand

Commit Message

Jaehoon Chung Jan. 12, 2021, 6:30 a.m. UTC
Remove board_mmc_init function.
It will be probed with driver-model.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 arch/arm/mach-exynos/include/mach/dwmmc.h |  2 --
 board/samsung/arndale/arndale.c           | 13 -------------
 2 files changed, 15 deletions(-)

Comments

Peng Fan Jan. 13, 2021, 1:31 a.m. UTC | #1
> Subject: [PATCH 1/2] samsung: arndale: remove board_mmc_init function
> 
> Remove board_mmc_init function.
> It will be probed with driver-model.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  arch/arm/mach-exynos/include/mach/dwmmc.h |  2 --
>  board/samsung/arndale/arndale.c           | 13 -------------
>  2 files changed, 15 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/include/mach/dwmmc.h
> b/arch/arm/mach-exynos/include/mach/dwmmc.h
> index 5654a0ea6b..59c28ed54c 100644
> --- a/arch/arm/mach-exynos/include/mach/dwmmc.h
> +++ b/arch/arm/mach-exynos/include/mach/dwmmc.h
> @@ -25,5 +25,3 @@
>  /* CLKSEL Register */
>  #define DWMCI_DIVRATIO_BIT		24
>  #define DWMCI_DIVRATIO_MASK		0x7
> -
> -int exynos_dwmmc_init(const void *blob); diff --git
> a/board/samsung/arndale/arndale.c b/board/samsung/arndale/arndale.c
> index 91813763ce..d283ef6275 100644
> --- a/board/samsung/arndale/arndale.c
> +++ b/board/samsung/arndale/arndale.c
> @@ -73,19 +73,6 @@ int dram_init_banksize(void)
>  	return 0;
>  }
> 
> -#ifdef CONFIG_MMC
> -int board_mmc_init(struct bd_info *bis) -{
> -	int ret;
> -	/* dwmmc initializattion for available channels */
> -	ret = exynos_dwmmc_init(gd->fdt_blob);
> -	if (ret)
> -		debug("dwmmc init failed\n");
> -
> -	return ret;
> -}
> -#endif
> -
>  static int board_uart_init(void)
>  {
>  	int err = 0, uart_id;
> --
> 2.17.1
Krzysztof Kozlowski Jan. 13, 2021, 4:14 a.m. UTC | #2
On Tue, Jan 12, 2021 at 03:30:53PM +0900, Jaehoon Chung wrote:
> Remove board_mmc_init function.
> It will be probed with driver-model.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  arch/arm/mach-exynos/include/mach/dwmmc.h |  2 --
>  board/samsung/arndale/arndale.c           | 13 -------------
>  2 files changed, 15 deletions(-)
> 

Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Minkyu Kang Jan. 15, 2021, 9:23 a.m. UTC | #3
Hi,

On Wed, 13 Jan 2021 at 13:14, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On Tue, Jan 12, 2021 at 03:30:53PM +0900, Jaehoon Chung wrote:
> > Remove board_mmc_init function.
> > It will be probed with driver-model.
> >
> > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> > ---
> >  arch/arm/mach-exynos/include/mach/dwmmc.h |  2 --
> >  board/samsung/arndale/arndale.c           | 13 -------------
> >  2 files changed, 15 deletions(-)
> >
>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Best regards,
> Krzysztof
>

applied to u-boot-samsung.
diff mbox series

Patch

diff --git a/arch/arm/mach-exynos/include/mach/dwmmc.h b/arch/arm/mach-exynos/include/mach/dwmmc.h
index 5654a0ea6b..59c28ed54c 100644
--- a/arch/arm/mach-exynos/include/mach/dwmmc.h
+++ b/arch/arm/mach-exynos/include/mach/dwmmc.h
@@ -25,5 +25,3 @@ 
 /* CLKSEL Register */
 #define DWMCI_DIVRATIO_BIT		24
 #define DWMCI_DIVRATIO_MASK		0x7
-
-int exynos_dwmmc_init(const void *blob);
diff --git a/board/samsung/arndale/arndale.c b/board/samsung/arndale/arndale.c
index 91813763ce..d283ef6275 100644
--- a/board/samsung/arndale/arndale.c
+++ b/board/samsung/arndale/arndale.c
@@ -73,19 +73,6 @@  int dram_init_banksize(void)
 	return 0;
 }
 
-#ifdef CONFIG_MMC
-int board_mmc_init(struct bd_info *bis)
-{
-	int ret;
-	/* dwmmc initializattion for available channels */
-	ret = exynos_dwmmc_init(gd->fdt_blob);
-	if (ret)
-		debug("dwmmc init failed\n");
-
-	return ret;
-}
-#endif
-
 static int board_uart_init(void)
 {
 	int err = 0, uart_id;