diff mbox series

board: amlogic: vim3: read ethernet MAC address from efuse

Message ID 20201217072642.1319-1-m.szyprowski@samsung.com
State Accepted, archived
Commit d10037e976ddcf4fda9d25bce4e00429d05f0c8b
Delegated to: Neil Armstrong
Headers show
Series board: amlogic: vim3: read ethernet MAC address from efuse | expand

Commit Message

Marek Szyprowski Dec. 17, 2020, 7:26 a.m. UTC
Add the board specific code for reading built-in ethernet MAC address
from efuse.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 board/amlogic/vim3/vim3.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Comments

Neil Armstrong Dec. 17, 2020, 8:43 a.m. UTC | #1
On 17/12/2020 08:26, Marek Szyprowski wrote:
> Add the board specific code for reading built-in ethernet MAC address
> from efuse.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  board/amlogic/vim3/vim3.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c
> index 09ef39ff30..a36df61583 100644
> --- a/board/amlogic/vim3/vim3.c
> +++ b/board/amlogic/vim3/vim3.c
> @@ -11,6 +11,7 @@
>  #include <net.h>
>  #include <asm/io.h>
>  #include <asm/arch/eth.h>
> +#include <asm/arch/sm.h>
>  #include <i2c.h>
>  #include "khadas-mcu.h"
>  
> @@ -129,9 +130,27 @@ int meson_ft_board_setup(void *blob, struct bd_info *bd)
>  	return 0;
>  }
>  
> +#define EFUSE_MAC_OFFSET	0
> +#define EFUSE_MAC_SIZE		6
> +
>  int misc_init_r(void)
>  {
> +	uint8_t mac_addr[EFUSE_MAC_SIZE];
> +	ssize_t len;
> +
>  	meson_eth_init(PHY_INTERFACE_MODE_RGMII, 0);
>  
> +	if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
> +		len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
> +					  mac_addr, EFUSE_MAC_SIZE);
> +		if (len != EFUSE_MAC_SIZE)
> +			return 0;
> +
> +		if (is_valid_ethaddr(mac_addr))
> +			eth_env_set_enetaddr("ethaddr", mac_addr);
> +		else
> +			meson_generate_serial_ethaddr();
> +	}
> +
>  	return 0;
>  }
> 

Thx, I wasn't aware Khadas flashed the MAC address in the fuse

I'll do a quick test on my boards.

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Neil
Jaehoon Chung Dec. 17, 2020, 8:57 a.m. UTC | #2
On 12/17/20 5:43 PM, Neil Armstrong wrote:
> On 17/12/2020 08:26, Marek Szyprowski wrote:
>> Add the board specific code for reading built-in ethernet MAC address
>> from efuse.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>>  board/amlogic/vim3/vim3.c | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>>
>> diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c
>> index 09ef39ff30..a36df61583 100644
>> --- a/board/amlogic/vim3/vim3.c
>> +++ b/board/amlogic/vim3/vim3.c
>> @@ -11,6 +11,7 @@
>>  #include <net.h>
>>  #include <asm/io.h>
>>  #include <asm/arch/eth.h>
>> +#include <asm/arch/sm.h>
>>  #include <i2c.h>
>>  #include "khadas-mcu.h"
>>  
>> @@ -129,9 +130,27 @@ int meson_ft_board_setup(void *blob, struct bd_info *bd)
>>  	return 0;
>>  }
>>  
>> +#define EFUSE_MAC_OFFSET	0
>> +#define EFUSE_MAC_SIZE		6
>> +
>>  int misc_init_r(void)
>>  {
>> +	uint8_t mac_addr[EFUSE_MAC_SIZE];
>> +	ssize_t len;
>> +
>>  	meson_eth_init(PHY_INTERFACE_MODE_RGMII, 0);
>>  
>> +	if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
>> +		len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
>> +					  mac_addr, EFUSE_MAC_SIZE);
>> +		if (len != EFUSE_MAC_SIZE)
>> +			return 0;
>> +
>> +		if (is_valid_ethaddr(mac_addr))
>> +			eth_env_set_enetaddr("ethaddr", mac_addr);
>> +		else
>> +			meson_generate_serial_ethaddr();
>> +	}
>> +
>>  	return 0;
>>  }
>>
> 
> Thx, I wasn't aware Khadas flashed the MAC address in the fuse
> 
> I'll do a quick test on my boards.
> 
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Tested-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> 
> Neil
>
diff mbox series

Patch

diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c
index 09ef39ff30..a36df61583 100644
--- a/board/amlogic/vim3/vim3.c
+++ b/board/amlogic/vim3/vim3.c
@@ -11,6 +11,7 @@ 
 #include <net.h>
 #include <asm/io.h>
 #include <asm/arch/eth.h>
+#include <asm/arch/sm.h>
 #include <i2c.h>
 #include "khadas-mcu.h"
 
@@ -129,9 +130,27 @@  int meson_ft_board_setup(void *blob, struct bd_info *bd)
 	return 0;
 }
 
+#define EFUSE_MAC_OFFSET	0
+#define EFUSE_MAC_SIZE		6
+
 int misc_init_r(void)
 {
+	uint8_t mac_addr[EFUSE_MAC_SIZE];
+	ssize_t len;
+
 	meson_eth_init(PHY_INTERFACE_MODE_RGMII, 0);
 
+	if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
+		len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
+					  mac_addr, EFUSE_MAC_SIZE);
+		if (len != EFUSE_MAC_SIZE)
+			return 0;
+
+		if (is_valid_ethaddr(mac_addr))
+			eth_env_set_enetaddr("ethaddr", mac_addr);
+		else
+			meson_generate_serial_ethaddr();
+	}
+
 	return 0;
 }