diff mbox series

[V2] cmd: mmc: update the mmc command's usage about argument

Message ID 20201215222450.23156-1-jh80.chung@samsung.com
State Accepted
Commit 1019b19665ee719762f7613a36bf1b7ef9c3b578
Delegated to: Peng Fan
Headers show
Series [V2] cmd: mmc: update the mmc command's usage about argument | expand

Commit Message

Jaehoon Chung Dec. 15, 2020, 10:24 p.m. UTC 
It's confusing whether arguments are optional or mandatory.
Update the command's usage to clarify how to use.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
Changed on V2
- Update commit-msg
- Add Simon's Reviewed-by tag
---
 cmd/mmc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Jaehoon Chung Feb. 18, 2021, 12:21 a.m. UTC | #1 
On 12/16/20 7:24 AM, Jaehoon Chung wrote:
> It's confusing whether arguments are optional or mandatory.
> Update the command's usage to clarify how to use.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Ping. Is there any progress about this patch?

Best Regards,
Jaehoon Chung

> ---
> Changed on V2
> - Update commit-msg
> - Add Simon's Reviewed-by tag
> ---
>  cmd/mmc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/cmd/mmc.c b/cmd/mmc.c
> index 1529a3e05ddd..cb6b59f36a43 100644
> --- a/cmd/mmc.c
> +++ b/cmd/mmc.c
> @@ -1017,13 +1017,13 @@ U_BOOT_CMD(
>  	"  Power cycling is required to initialize partitions after set to complete.\n"
>  #endif
>  #ifdef CONFIG_SUPPORT_EMMC_BOOT
> -	"mmc bootbus dev boot_bus_width reset_boot_bus_width boot_mode\n"
> +	"mmc bootbus <dev> <boot_bus_width> <reset_boot_bus_width> <boot_mode>\n"
>  	" - Set the BOOT_BUS_WIDTH field of the specified device\n"
>  	"mmc bootpart-resize <dev> <boot part size MB> <RPMB part size MB>\n"
>  	" - Change sizes of boot and RPMB partitions of specified device\n"
> -	"mmc partconf dev [boot_ack boot_partition partition_access]\n"
> +	"mmc partconf <dev> [boot_ack boot_partition partition_access]\n"
>  	" - Show or change the bits of the PARTITION_CONFIG field of the specified device\n"
> -	"mmc rst-function dev value\n"
> +	"mmc rst-function <dev> <value>\n"
>  	" - Change the RST_n_FUNCTION field of the specified device\n"
>  	"   WARNING: This is a write-once field and 0 / 1 / 2 are the only valid values.\n"
>  #endif
>
diff mbox series

Patch

diff --git a/cmd/mmc.c b/cmd/mmc.c
index 1529a3e05ddd..cb6b59f36a43 100644
--- a/cmd/mmc.c
+++ b/cmd/mmc.c
@@ -1017,13 +1017,13 @@  U_BOOT_CMD(
 	"  Power cycling is required to initialize partitions after set to complete.\n"
 #endif
 #ifdef CONFIG_SUPPORT_EMMC_BOOT
-	"mmc bootbus dev boot_bus_width reset_boot_bus_width boot_mode\n"
+	"mmc bootbus <dev> <boot_bus_width> <reset_boot_bus_width> <boot_mode>\n"
 	" - Set the BOOT_BUS_WIDTH field of the specified device\n"
 	"mmc bootpart-resize <dev> <boot part size MB> <RPMB part size MB>\n"
 	" - Change sizes of boot and RPMB partitions of specified device\n"
-	"mmc partconf dev [boot_ack boot_partition partition_access]\n"
+	"mmc partconf <dev> [boot_ack boot_partition partition_access]\n"
 	" - Show or change the bits of the PARTITION_CONFIG field of the specified device\n"
-	"mmc rst-function dev value\n"
+	"mmc rst-function <dev> <value>\n"
 	" - Change the RST_n_FUNCTION field of the specified device\n"
 	"   WARNING: This is a write-once field and 0 / 1 / 2 are the only valid values.\n"
 #endif