Message ID | 20201130015402.2328621-15-sjg@chromium.org |
---|---|
State | Superseded |
Delegated to: | Simon Glass |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=kJHQx00/; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CkpL85NzHz9sTc for <incoming@patchwork.ozlabs.org>; Mon, 30 Nov 2020 12:58:40 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2EDB8827DB; Mon, 30 Nov 2020 02:57:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="kJHQx00/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3BFEC82623; Mon, 30 Nov 2020 02:55:23 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D31EE82797 for <u-boot@lists.denx.de>; Mon, 30 Nov 2020 02:54:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-io1-xd42.google.com with SMTP id y5so9146644iow.5 for <u-boot@lists.denx.de>; Sun, 29 Nov 2020 17:54:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gpUJ72lYnb7T6c39VmBqbSUeX8EBFpjF4CVFQDlV6zY=; b=kJHQx00/RIEz2DMwjxpqF3sT7BVJ1SF2iazqqjjTgH2YpDS72tR1zGYTD937sBPYuO vmsgLygNmsep3ilsTdfBypTDHJ+A5Kc3YPI0e8YhYwXpNHFq/0hXpVOmxRlpHMBEdoGy gxg7iP6VHZom4WJxc6YMaC0QgHI8OutjmKUzY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gpUJ72lYnb7T6c39VmBqbSUeX8EBFpjF4CVFQDlV6zY=; b=dPyEeGHfxuRxGFBItJfFNZYT1FetuMrQ3pB3bbj1DqXGMcnOG87Mu1T07rSL/qoaIA 06WBtSexDdxXltUH5kW8B59mUHPu8v0YP/7TmhIpl492FolqoejdS62q8/dSm6zYS4hg DBXU5nm9NX5onj0e6wxNPTiwOkvWTGY4+QXqCVGAAec2/lA+zCvcev5AeoZz3j7JdsPB oJQrh0vCZHHyjWmvyZg3K06v0zxY3jskv2wA+QYHnK+5iyg4u415fF7IkY3hTSTqvNG7 RW0kObaJ+rNkhh57RsJkJykCI7fdzMgljI1qo9VihjonRiVaJxTKyFnRHUeW4UgdBUpj ujhQ== X-Gm-Message-State: AOAM530Qnu05srg8tTNPC/RHD0GyqwNFfDVPAqM6bzad36BNc7mju0ui H3W03FXUc0Q+QIDt0Ex4Tpf+++DthXicyQ== X-Google-Smtp-Source: ABdhPJySoEn8/MZ3PQ3pfTm+AEgulu0avELYRbVn0L8/C9oVZX3WbfwwOGdcqPgzrMWVD5jWrswsDQ== X-Received: by 2002:a5d:85c7:: with SMTP id e7mr14090349ios.162.1606701291387; Sun, 29 Nov 2020 17:54:51 -0800 (PST) Received: from localhost.localdomain (c-67-190-101-114.hsd1.co.comcast.net. [67.190.101.114]) by smtp.gmail.com with ESMTPSA id q5sm6543341ilg.62.2020.11.29.17.54.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Nov 2020 17:54:50 -0800 (PST) From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Cc: Simon Glass <sjg@chromium.org>, Marek Vasut <marex@denx.de>, Masahiro Yamada <yamada.masahiro@socionext.com> Subject: [PATCH 16/27] usb: Update for new sequence numbers Date: Sun, 29 Nov 2020 18:53:51 -0700 Message-Id: <20201130015402.2328621-15-sjg@chromium.org> X-Mailer: git-send-email 2.29.2.454.gaff20da3a2-goog In-Reply-To: <20201130015402.2328621-1-sjg@chromium.org> References: <20201130015402.2328621-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <https://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean |
Series |
dm: Change the way sequence numbers are implemented
|
expand
|
diff --git a/drivers/usb/host/ehci-vf.c b/drivers/usb/host/ehci-vf.c index 92b70ba1b30..dd82669b284 100644 --- a/drivers/usb/host/ehci-vf.c +++ b/drivers/usb/host/ehci-vf.c @@ -296,16 +296,14 @@ static const struct ehci_ops vf_ehci_ops = { static int vf_usb_bind(struct udevice *dev) { - static int num_controllers; - /* * Without this hack, if we return ENODEV for USB Controller 0, on * probe for the next controller, USB Controller 1 will be given a * sequence number of 0. This conflicts with our requirement of * sequence numbers while initialising the peripherals. + * + * FIXME: Check that this still works OK with the new sequence numbers */ - dev->req_seq = num_controllers; - num_controllers++; return 0; }
Use the new sequence number in all cases. Since all devices are assigned a number when bound, this hack should not be needed. Signed-off-by: Simon Glass <sjg@chromium.org> --- drivers/usb/host/ehci-vf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)