From patchwork Thu Nov 26 19:46:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1406863 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=JUox0nsh; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4ChpDv0K3nz9sSf for ; Fri, 27 Nov 2020 06:47:01 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 41293826D9; Thu, 26 Nov 2020 20:46:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="JUox0nsh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 23946826DC; Thu, 26 Nov 2020 20:46:50 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 62B40826D7 for ; Thu, 26 Nov 2020 20:46:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1606420002; bh=V4kaYqw/e4n6KvWqXhUSM4Ts8Ts8dU64lbZiiUeAVFs=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=JUox0nshktPCfAGbz/4H/9jIpseQc7nCpGQmlLfG3oH8aqnxevCuQTh3EZYLoJ+0c 61RWZGEe5jjz8a2oQCrqbZlO6x0UT3gzo/XrutFGCOLJ/J/qup2Xk3F/EOCy9N7mF5 bkDI0FyLQEa4Cd5etMcgzcYg4sCzHOPSKj58Fitc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from mcbin.fritz.box ([62.143.246.89]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mv2xU-1jrmfi30aW-00r2yw; Thu, 26 Nov 2020 20:46:42 +0100 From: Heinrich Schuchardt To: Tom Rini Cc: Simon Glass , Stefan Roese , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] common: always compile fixup_cmdtable() Date: Thu, 26 Nov 2020 20:46:37 +0100 Message-Id: <20201126194637.59863-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:4HlW1GIdeG0pG0cKzws+CUcsX6r9TuejnAL8GFtk42LhaszGiwA uykaEMESzwXaGuWFURlb9W22uj6iAK/X6YWq14GJ5F8wvfzLQ4mxuYUBckjV1QmKassfosh iJIulzebl00GwFbuVjjSv5ZgyQWFvAKBfX9fsSDtg+OEfjeiCkETehyIEGQYgQzkM4led8R pa74KnWVptZAP8UzAmVuQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:oeq8tE1DVPs=:ta6+rC4kV6Pl+0kjeT15W2 TDHtWi7g3DQJM2Pnof5OaNS5poQaSMGBuUyjxhm1wl4S8rpOOX5tnVanzl+0YWryG6DoRs2Tk E8+Bg/3YSaquucKYA5GTejWxEB2wiQ+fnNo0tVawdaT6Su3j9c94KIfk4fLxVBWyzp6iXyCsj bVsQJqTXZYgYZzIS6mTkswTCnj6O/X6BCGxTCzf7GaW3nDuKqjIabXR1N2T0V6oBOMxLd34LQ 12EgaYUGFCpIh3mtwskPFRHsmWT4qZdiL2kuBNz5eRpivIu2uRPlG9VyUWRtX3DaDeX/cJN7F db6jgza3lkksnOpZtk/dcDFPsX6Rllu+n3BnsOQjCXMEql8FcP+RAMAMT7pr9YzA4ropUp6o6 xUxqOcP2q/Q2aKNk2DqCzWb/kr/9XPcq8GMJrLDN3M7B+0goLrt7vhRCN2Mx4qi3S3YqbfNnL oHRb5T2y6x4EpghVFhm6DZhn+wM8jQPfWCMFM2HRUaA0D/tJBnGftEIyqtHZ42pr1RLIwaVqO J8kAssvgQenCjvyMwdLxSL8dlVp44QQxkZCwWaJms1e2yE075MLMWEUJ/k8Xt++HuOywz4ofW RdLZncQpp2nADEQJmeawQDijBCf2cjv/HO7jUqfnOdxX215Q/qkthJFjDK9ecVvhvBsCWdZ7J dsjwnGsZM1gC7V9QAsA8XEyGIx8NuaRQKRbe0usoa35OpQG06PgkXAM9cIrbg63lyJFjvRGSJ jD0ulwOlweiDK2nk8D6vWumxhUkFLYS6LdoIpnCAYkkstS2X7MmMJbXyXeHR4LLcAWO0il4ZT YBcRIOJ2VPRuuwx+fq8P1swKNYRbPBCIq/zTRutn9an6r+GhIy92NZ/6bjLkiMGarX+jHHZWV 1InwZZHhWK3fYUoyEl6Q== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean With our optimization settings the linker eliminates unused functions. But for debugging it is better to compile with -Og or -O0. With -O0 compiling the sandbox fails due to the missing function fixup_cmdtable() called by dm_reloc() and others. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- common/command.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.29.2 diff --git a/common/command.c b/common/command.c index 2c491e20a7..345846f165 100644 --- a/common/command.c +++ b/common/command.c @@ -16,6 +16,8 @@ #include #include +DECLARE_GLOBAL_DATA_PTR; + /* * Use puts() instead of printf() to avoid printf buffer overflow * for long help messages @@ -488,9 +490,6 @@ int cmd_get_data_size(char* arg, int default_size) } #endif -#if defined(CONFIG_NEEDS_MANUAL_RELOC) -DECLARE_GLOBAL_DATA_PTR; - void fixup_cmdtable(struct cmd_tbl *cmdtp, int size) { int i; @@ -535,7 +534,6 @@ void fixup_cmdtable(struct cmd_tbl *cmdtp, int size) cmdtp++; } } -#endif int cmd_always_repeatable(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[], int *repeatable)