From patchwork Thu Nov 26 10:48:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pragnesh Patel X-Patchwork-Id: 1406527 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=AZFr3DY3; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4ChZJQ2h6kz9sRK for ; Thu, 26 Nov 2020 21:49:15 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 573F4826A8; Thu, 26 Nov 2020 11:49:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="AZFr3DY3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F12B1826AA; Thu, 26 Nov 2020 11:49:01 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20631.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe59::631]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C61A6826A6 for ; Thu, 26 Nov 2020 11:48:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pragnesh.patel@openfive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JeksmgHGOn5h69NgnH/K+jrlxW5w0QrtkSy1i6UukhzIJK21ayrM9yY+yOlvWzYudt0nYCIo9vS6QuRjCGVrAiqXbMOUlYXtvsGfru+RFLMQ+1TPFgPZ6tyqw5wrOpw6yJqZ78tYVR4GSazjIfX3ATrHYZudffi4Fg51dFlCaFxDZZdDMTqQWuBVGr43dQWHV1Q5H9X2S09NjDfVC9eyuhoiOfRaaOqR9M8Z6QVgmvbN0FtVitoTa5KR1rrTTt6jysGJiS+tIsUx2Y9EzeUWRo+3p7a0nZHVjANujjiflA0tuZTGMNzEkvcq5fLd9+N7ZLBruoNtClP/dNWufaw1Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2m65UStaUMA2qSy5hwB7SXlyr0YMGxIaO7LYVPn76CQ=; b=JL/dMkrbuQiTfUaQdlCu97MiU7jgznjsmjicqz+pnIkGgWapZQ326VJLnGz3zeD8jQ8jwlYucQL5w8GgkPvS6jyf40sZWZ4n89IUHyjf/Nme3Rvxe1ig91KXlTpTDqY4J96IC1aDJlLlAru/ThHH2ZvgYis2HnNn6YSR59Wv7B9cXrD8tcw3WkCCzwCrrhb8zkoO603FLzaos9KYFm5hwGQm5KmTSjth3mGqDuqZUkaD5KNh79B3bVGDdsxA1g70fwF3S5rhaNIJPqEi4QMnRqbc+Xp1OVd/UiMRjD4GWqVI3+UwaF6v1mXLHqOYf9f3KFBNzFiW8oKA11/ClaEGOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=openfive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2m65UStaUMA2qSy5hwB7SXlyr0YMGxIaO7LYVPn76CQ=; b=AZFr3DY3DQLtD8Z9vA8rpsXHwNsK/zUUX5E4gI7BIEe0w50nTsPXnJnJeKB8b9pw5gBJLqi+RS63+5fjiqce2ITt8zMVBWMXGORjVzV30pspyju4VHTnuf7zrQHuCzX/x4icflMVvsAIPpHsnWlBCrOzZ//r/LzAvOZ/j5X+/RU= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=sifive.com; Received: from MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) by MN2PR13MB3823.namprd13.prod.outlook.com (2603:10b6:208:1e9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.9; Thu, 26 Nov 2020 10:48:42 +0000 Received: from MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::390d:16fc:b871:f82e]) by MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::390d:16fc:b871:f82e%4]) with mapi id 15.20.3632.006; Thu, 26 Nov 2020 10:48:42 +0000 From: Pragnesh Patel To: u-boot@lists.denx.de Cc: atish.patra@wdc.com, palmerdabbelt@google.com, bmeng.cn@gmail.com, paul.walmsley@sifive.com, anup.patel@wdc.com, sagar.kadam@sifive.com, rick@andestech.com, Pragnesh Patel , Simon Glass , Naoki Hayama , Marek Vasut , Patrick Delaunay , Adam Ford , Thomas Hebb , Ramon Fried , Heinrich Schuchardt , Bin Meng , Sam Protsenko , Miquel Raynal , Philippe Reynes , =?utf-8?q?Fr=C3=A9d=C3=A9?= =?utf-8?q?ric_Danis?= , Patrice Chotard , Vladimir Olovyannikov Subject: [PATCH v2] cmd: Add a pwm command Date: Thu, 26 Nov 2020 16:18:10 +0530 Message-Id: <20201126104812.14619-1-pragnesh.patel@sifive.com> X-Mailer: git-send-email 2.17.1 X-Originating-IP: [114.143.65.226] X-ClientProxiedBy: LO2P265CA0313.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::13) To MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sachinj2-OptiPlex-7010.open-silicon.com (114.143.65.226) by LO2P265CA0313.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.20 via Frontend Transport; Thu, 26 Nov 2020 10:48:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 309c5f0f-2956-4b53-b3e3-08d891f8d6e9 X-MS-TrafficTypeDiagnostic: MN2PR13MB3823: X-LD-Processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1091; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SE9TY1lYP4+jaVRgPhfai48JV0Bzf00S52tWU4UmfXFya8ekva6cDrzOx8FtKls6OIQ61PixFliJ/QkQHXubzfdSld2QQjYymF6vXlrcNCvRVROpfwk/bHxnyLlKFo/VpQR8pZ6FTg5UVVxJopaljBYg5OqW6/VVj2Av8i9JgbFwwY0mb3FmuK53jMrBMy+/moP7mnVrqu6DcnGn/ZlKqtZemUQkyJSgywv9jtefbjKTvjpuDlgAJYJTQoDU9Eue0EN30yjwA7g5Lv1L+OmZhz7Y18YaoeaA1u3qeW7k4/nuIQQDU5KEUrABXM3PW51SuubHUYvVm0GT5+o+VljlIw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR13MB2797.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(346002)(136003)(396003)(376002)(39840400004)(1076003)(5660300002)(36756003)(478600001)(1006002)(6506007)(7416002)(26005)(16526019)(4326008)(2906002)(186003)(6512007)(83170400001)(2616005)(6666004)(54906003)(316002)(6486002)(52116002)(83380400001)(8936002)(8676002)(66556008)(66946007)(42882007)(66476007)(44832011)(6916009)(956004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: Mc7zje1lD7qo+xO0fb3Rwy6Du/yjgqnuw8l6QtYEYX5Imz5V+3bByZz7v8BZK/Fyr/cS4Os6E0ZYQJdwAp/tLAHINTLE8cIoxhH64AgVF4Hh0e70RnfQcu2xsoduLLN7DXKIz4BZGQabgQGyWtl6X38qwMyxJS+rNb2etk/B4636i5377FMoPIrNS7v+V1MpSCmHNb9Rfr8+hpNp4O6ZKyHPkyTnnGYlShgqBeclWHZRo2YK/SEoy65O/3PJNGHabHKYFlY1EiEX5NZMo97kdt3tzMk7cIybwaUu0c19X5GAPFMDnW8eHP1swYablVv7FYApeGThZVd3A0nmofLcqrqFOfWi7NfL3FPgHmE+Ph9GFVxxfia1GGkjUP+u/LV/JoO/9Uj8VoigR4qV7K9woaALtnhsCRGaeg5C7OTq/2OSG0svVEJYZ8itYaQ6nPr5S948UA4BGfabqJR/vV1ydcHI6KAmOMv6ZiU5qGEX6ZP8xQbB8UN1TTm0tnW8zu6swovKoRcYpPsY4oTuTl2WoGHxRIND1eb+4+admlcnGarlZq8EwyzFGkCzPee3CTSInAy2Ju5ysYvB+gGpZjXPSLCMOQHLdINRnkx8/w9cO5ZA1D1f1WpF9QUxrCLswdYgbKmN9VAnItqt+dY7m44NnXmus6bko9y4gYDNawDEtEkeHtp59hfplo3idlYUpjHisqCoArsDSXWDDgM/CE/OV5Apoo1uw583FhRlClRYqD0y9rQoJUiSt+++rnpEynY9s0bc2Kd5V0ojsVopW4bEVCGrFYS0VRbH4x5/J4QvdsjyU/dFArqSA96iOZTNhO8wb/+wFhcBAaQhLo9QwTKJst1Tqotko08gUvQBZ4RY6hTpZLEKZDJ99Ad+C7vVLOR0j1utqKupfMLvasHoVPlRrnyr+Uc/FPlBhqsB76UHIfaGzbbu04ZqfGN+ENMuwcQ4ZydVFHOs9l+9iUjPKFT3sDR9zS4zoYeukHZzSjt1FWeDDiwLbYi4Jt6hrzgHu3sa X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: 309c5f0f-2956-4b53-b3e3-08d891f8d6e9 X-MS-Exchange-CrossTenant-AuthSource: MN2PR13MB2797.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2020 10:48:42.5437 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AqB/95x3D7uOd+LIEH0i0lMeWO9uOnCYmw7paPIzrsTh0EcsDlNagFDuuRKD9T4ikAojf8Pg9ueCwkwTly7S3CqbmLj6R5alUeVHjD7TIt0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3823 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Add the command "pwm" for controlling the pwm channels. This command provides pwm invert/config/enable/disable functionalities via PWM uclass drivers Signed-off-by: Pragnesh Patel Reviewed-by: Simon Glass --- Changes in v2: - Add test for pwm command README | 1 + cmd/Kconfig | 6 ++ cmd/Makefile | 1 + cmd/pwm.c | 120 ++++++++++++++++++++++++++++++++++++++ configs/sandbox_defconfig | 1 + test/cmd/Makefile | 1 + test/cmd/pwm.c | 54 +++++++++++++++++ 7 files changed, 184 insertions(+) create mode 100644 cmd/pwm.c create mode 100644 test/cmd/pwm.c diff --git a/README b/README index cb49aa15da..dab291e0d0 100644 --- a/README +++ b/README @@ -3160,6 +3160,7 @@ i2c - I2C sub-system sspi - SPI utility commands base - print or set address offset printenv- print environment variables +pwm - control pwm channels setenv - set environment variables saveenv - save environment variables to persistent storage protect - enable or disable FLASH write protection diff --git a/cmd/Kconfig b/cmd/Kconfig index 1595de999b..0d085108f4 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -918,6 +918,12 @@ config CMD_GPIO help GPIO support. +config CMD_PWM + bool "pwm" + depends on DM_PWM + help + Control PWM channels, this allows invert/config/enable/disable PWM channels. + config CMD_GPT bool "GPT (GUID Partition Table) command" select EFI_PARTITION diff --git a/cmd/Makefile b/cmd/Makefile index dd86675bf2..75df3c136c 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -120,6 +120,7 @@ endif obj-$(CONFIG_CMD_PINMUX) += pinmux.o obj-$(CONFIG_CMD_PMC) += pmc.o obj-$(CONFIG_CMD_PSTORE) += pstore.o +obj-$(CONFIG_CMD_PWM) += pwm.o obj-$(CONFIG_CMD_PXE) += pxe.o pxe_utils.o obj-$(CONFIG_CMD_WOL) += wol.o obj-$(CONFIG_CMD_QFW) += qfw.o diff --git a/cmd/pwm.c b/cmd/pwm.c new file mode 100644 index 0000000000..f704c7a755 --- /dev/null +++ b/cmd/pwm.c @@ -0,0 +1,120 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Control PWM channels + * + * Copyright (c) 2020 SiFive, Inc + * author: Pragnesh Patel + */ + +#include +#include +#include + +enum pwm_cmd { + PWM_SET_INVERT, + PWM_SET_CONFIG, + PWM_SET_ENABLE, + PWM_SET_DISABLE, +}; + +static int do_pwm(struct cmd_tbl *cmdtp, int flag, int argc, + char *const argv[]) +{ + const char *str_cmd, *str_channel = NULL, *str_enable = NULL; + const char *str_pwm = NULL, *str_period = NULL, *str_duty = NULL; + enum pwm_cmd sub_cmd; + struct udevice *dev; + u32 channel, pwm_enable, pwm_dev, period_ns = 0, duty_ns = 0; + int ret; + + if (argc < 4) + show_usage: + return CMD_RET_USAGE; + + str_cmd = argv[1]; + argc -= 2; + argv += 2; + + if (argc > 0) { + str_pwm = *argv; + argc--; + argv++; + } + + if (!str_pwm) + goto show_usage; + + switch (*str_cmd) { + case 'i': + sub_cmd = PWM_SET_INVERT; + break; + case 'c': + sub_cmd = PWM_SET_CONFIG; + break; + case 'e': + sub_cmd = PWM_SET_ENABLE; + break; + case 'd': + sub_cmd = PWM_SET_DISABLE; + break; + default: + goto show_usage; + } + + if (IS_ENABLED(CONFIG_DM_PWM)) { + pwm_dev = simple_strtoul(str_pwm, NULL, 10); + ret = uclass_get_device(UCLASS_PWM, pwm_dev, &dev); + if (ret) { + printf("PWM: '%s' not found\n", str_pwm); + return cmd_process_error(cmdtp, ret); + } + } + + if (argc > 0) { + str_channel = *argv; + channel = simple_strtoul(str_channel, NULL, 10); + argc--; + argv++; + } else { + goto show_usage; + } + + if (sub_cmd == PWM_SET_INVERT && argc > 0) { + str_enable = *argv; + pwm_enable = simple_strtoul(str_enable, NULL, 10); + ret = pwm_set_invert(dev, channel, pwm_enable); + } else if (sub_cmd == PWM_SET_CONFIG && argc == 2) { + str_period = *argv; + argc--; + argv++; + period_ns = simple_strtoul(str_period, NULL, 10); + + if (argc > 0) { + str_duty = *argv; + duty_ns = simple_strtoul(str_duty, NULL, 10); + } + + ret = pwm_set_config(dev, channel, period_ns, duty_ns); + } else if (sub_cmd == PWM_SET_ENABLE) { + ret = pwm_set_enable(dev, channel, 1); + } else if (sub_cmd == PWM_SET_DISABLE) { + ret = pwm_set_enable(dev, channel, 0); + } else { + printf("PWM arguments missing\n"); + return CMD_RET_FAILURE; + } + + if (ret) { + printf("error\n"); + return CMD_RET_FAILURE; + } + + printf("success\n"); + return CMD_RET_SUCCESS; +} + +U_BOOT_CMD(pwm, 6, 0, do_pwm, + "control pwm channels", + "pwm \n" + "pwm \n" + "pwm "); diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index f2a767a4cd..7a16603461 100644 --- a/configs/sandbox_defconfig +++ b/configs/sandbox_defconfig @@ -58,6 +58,7 @@ CONFIG_CMD_LSBLK=y CONFIG_CMD_MUX=y CONFIG_CMD_OSD=y CONFIG_CMD_PCI=y +CONFIG_CMD_PWM=y CONFIG_CMD_READ=y CONFIG_CMD_REMOTEPROC=y CONFIG_CMD_SPI=y diff --git a/test/cmd/Makefile b/test/cmd/Makefile index 859dcda239..dde98dd371 100644 --- a/test/cmd/Makefile +++ b/test/cmd/Makefile @@ -4,3 +4,4 @@ obj-y += mem.o obj-$(CONFIG_CMD_MEM_SEARCH) += mem_search.o +obj-$(CONFIG_CMD_PWM) += pwm.o diff --git a/test/cmd/pwm.c b/test/cmd/pwm.c new file mode 100644 index 0000000000..987cdd1115 --- /dev/null +++ b/test/cmd/pwm.c @@ -0,0 +1,54 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Test for pwm command + * + * Copyright 2020 SiFive, Inc + * + * Authors: + * Pragnesh Patel + */ + +#include +#include +#include +#include + +/* Basic test of 'pwm' command */ +static int dm_test_pwm_cmd(struct unit_test_state *uts) +{ + struct udevice *dev; + + ut_assertok(uclass_get_device(UCLASS_PWM, 0, &dev)); + ut_assertnonnull(dev); + + ut_assertok(console_record_reset_enable()); + + /* pwm */ + run_command("pwm invert 0 0 1", 0); + console_record_readline(uts->actual_str, sizeof(uts->actual_str)); + ut_asserteq_str("success", uts->actual_str); + + run_command("pwm invert 0 0 0", 0); + console_record_readline(uts->actual_str, sizeof(uts->actual_str)); + ut_asserteq_str("success", uts->actual_str); + + /* pwm */ + run_command("pwm config 0 0 period_ns duty_ns", 0); + console_record_readline(uts->actual_str, sizeof(uts->actual_str)); + ut_asserteq_str("success", uts->actual_str); + + /* pwm */ + run_command("pwm enable 0 0", 0); + console_record_readline(uts->actual_str, sizeof(uts->actual_str)); + ut_asserteq_str("success", uts->actual_str); + + run_command("pwm disable 0 0", 0); + console_record_readline(uts->actual_str, sizeof(uts->actual_str)); + ut_asserteq_str("success", uts->actual_str); + + ut_assert_console_end(); + + return 0; +} + +DM_TEST(dm_test_pwm_cmd, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT | UT_TESTF_CONSOLE_REC);