| Message ID | 20201119192620.54872-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 3cbb026f17332b70d352ae3659179ca2b51f418c |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [v1] linux/compat.h: Remove debug() from spin_lock_irqsave() | expand |
Update Tom's address On Thu, Nov 19, 2020 at 9:26 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > It seems nobody tested the debug() option in spin_lock_irqsave(). > Currently, when #define DEBUG, it spoils the compiler with > > In file included from drivers/usb/dwc3/gadget.c:18: > drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_set_selfpowered’: > include/log.h:235:4: warning: ‘flags’ is used uninitialized in this function [-Wuninitialized] > 235 | printf(pr_fmt(fmt), ##args); \ > | ^~~~~~ > drivers/usb/dwc3/gadget.c:1347:17: note: ‘flags’ was declared here > 1347 | unsigned long flags; > | ^~~~~ > > and so on... > Drop useless debug() call to make compiler happy. > > Fixes: 0c06db598367 ("lib, linux: move linux specific defines to linux/compat.h") > Cc: Heiko Schocher <hs@denx.de> > Cc: Tom Rini <trini@ti.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > include/linux/compat.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/compat.h b/include/linux/compat.h > index 38549baa251d..3d0acbd582ef 100644 > --- a/include/linux/compat.h > +++ b/include/linux/compat.h > @@ -248,7 +248,7 @@ typedef int wait_queue_head_t; > #define spin_lock_init(lock) do {} while (0) > #define spin_lock(lock) do {} while (0) > #define spin_unlock(lock) do {} while (0) > -#define spin_lock_irqsave(lock, flags) do { debug("%lu\n", flags); } while (0) > +#define spin_lock_irqsave(lock, flags) do {} while (0) > #define spin_unlock_irqrestore(lock, flags) do { flags = 0; } while (0) > > #define DEFINE_MUTEX(...) > -- > 2.29.2 >
Hi, Andy On 11/19/20 10:21 PM, Andy Shevchenko wrote: > Update Tom's address > > On Thu, Nov 19, 2020 at 9:26 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: >> It seems nobody tested the debug() option in spin_lock_irqsave(). >> Currently, when #define DEBUG, it spoils the compiler with >> >> In file included from drivers/usb/dwc3/gadget.c:18: >> drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_set_selfpowered’: >> include/log.h:235:4: warning: ‘flags’ is used uninitialized in this function [-Wuninitialized] >> 235 | printf(pr_fmt(fmt), ##args); \ >> | ^~~~~~ >> drivers/usb/dwc3/gadget.c:1347:17: note: ‘flags’ was declared here >> 1347 | unsigned long flags; >> | ^~~~~ >> >> and so on... >> Drop useless debug() call to make compiler happy. >> >> Fixes: 0c06db598367 ("lib, linux: move linux specific defines to linux/compat.h") >> Cc: Heiko Schocher <hs@denx.de> >> Cc: Tom Rini <trini@ti.com> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> >> --- >> include/linux/compat.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/compat.h b/include/linux/compat.h >> index 38549baa251d..3d0acbd582ef 100644 >> --- a/include/linux/compat.h >> +++ b/include/linux/compat.h >> @@ -248,7 +248,7 @@ typedef int wait_queue_head_t; >> #define spin_lock_init(lock) do {} while (0) >> #define spin_lock(lock) do {} while (0) >> #define spin_unlock(lock) do {} while (0) >> -#define spin_lock_irqsave(lock, flags) do { debug("%lu\n", flags); } while (0) >> +#define spin_lock_irqsave(lock, flags) do {} while (0) >> #define spin_unlock_irqrestore(lock, flags) do { flags = 0; } while (0) >> >> #define DEFINE_MUTEX(...) >> -- >> 2.29.2 >> >
Hello Andy, Am 19.11.20 um 21:21 schrieb Andy Shevchenko: > Update Tom's address > > On Thu, Nov 19, 2020 at 9:26 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: >> >> It seems nobody tested the debug() option in spin_lock_irqsave(). >> Currently, when #define DEBUG, it spoils the compiler with >> >> In file included from drivers/usb/dwc3/gadget.c:18: >> drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_set_selfpowered’: >> include/log.h:235:4: warning: ‘flags’ is used uninitialized in this function [-Wuninitialized] >> 235 | printf(pr_fmt(fmt), ##args); \ >> | ^~~~~~ >> drivers/usb/dwc3/gadget.c:1347:17: note: ‘flags’ was declared here >> 1347 | unsigned long flags; >> | ^~~~~ >> >> and so on... >> Drop useless debug() call to make compiler happy. >> >> Fixes: 0c06db598367 ("lib, linux: move linux specific defines to linux/compat.h") >> Cc: Heiko Schocher <hs@denx.de> >> Cc: Tom Rini <trini@ti.com> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> --- >> include/linux/compat.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) Thanks! Reviewed-by: Heiko Schocher <hs@denx.de> bye, Heiko
On Thu, Nov 19, 2020 at 10:21:39PM +0200, Andy Shevchenko wrote:
> Update Tom's address
Tom, should I resend with your address fixed?
On Wed, Dec 02, 2020 at 08:28:55PM +0200, Andy Shevchenko wrote: > On Thu, Nov 19, 2020 at 10:21:39PM +0200, Andy Shevchenko wrote: > > Update Tom's address > > Tom, should I resend with your address fixed? No, I grab things from patchwork. This is on my TODO list, btw.
On Wed, Dec 02, 2020 at 01:37:35PM -0500, Tom Rini wrote: > On Wed, Dec 02, 2020 at 08:28:55PM +0200, Andy Shevchenko wrote: > > On Thu, Nov 19, 2020 at 10:21:39PM +0200, Andy Shevchenko wrote: > > > Update Tom's address > > > > Tom, should I resend with your address fixed? > > No, I grab things from patchwork. This is on my TODO list, btw. Cool, thanks!
On Thu, Nov 19, 2020 at 09:26:20PM +0200, Andy Shevchenko wrote: > It seems nobody tested the debug() option in spin_lock_irqsave(). > Currently, when #define DEBUG, it spoils the compiler with > > In file included from drivers/usb/dwc3/gadget.c:18: > drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_set_selfpowered’: > include/log.h:235:4: warning: ‘flags’ is used uninitialized in this function [-Wuninitialized] > 235 | printf(pr_fmt(fmt), ##args); \ > | ^~~~~~ > drivers/usb/dwc3/gadget.c:1347:17: note: ‘flags’ was declared here > 1347 | unsigned long flags; > | ^~~~~ > > and so on... > Drop useless debug() call to make compiler happy. > > Fixes: 0c06db598367 ("lib, linux: move linux specific defines to linux/compat.h") > Cc: Heiko Schocher <hs@denx.de> > Cc: Tom Rini <trini@ti.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > Reviewed-by: Heiko Schocher <hs@denx.de> Applied to u-boot/master, thanks!
diff --git a/include/linux/compat.h b/include/linux/compat.h index 38549baa251d..3d0acbd582ef 100644 --- a/include/linux/compat.h +++ b/include/linux/compat.h @@ -248,7 +248,7 @@ typedef int wait_queue_head_t; #define spin_lock_init(lock) do {} while (0) #define spin_lock(lock) do {} while (0) #define spin_unlock(lock) do {} while (0) -#define spin_lock_irqsave(lock, flags) do { debug("%lu\n", flags); } while (0) +#define spin_lock_irqsave(lock, flags) do {} while (0) #define spin_unlock_irqrestore(lock, flags) do { flags = 0; } while (0) #define DEFINE_MUTEX(...)
It seems nobody tested the debug() option in spin_lock_irqsave(). Currently, when #define DEBUG, it spoils the compiler with In file included from drivers/usb/dwc3/gadget.c:18: drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_set_selfpowered’: include/log.h:235:4: warning: ‘flags’ is used uninitialized in this function [-Wuninitialized] 235 | printf(pr_fmt(fmt), ##args); \ | ^~~~~~ drivers/usb/dwc3/gadget.c:1347:17: note: ‘flags’ was declared here 1347 | unsigned long flags; | ^~~~~ and so on... Drop useless debug() call to make compiler happy. Fixes: 0c06db598367 ("lib, linux: move linux specific defines to linux/compat.h") Cc: Heiko Schocher <hs@denx.de> Cc: Tom Rini <trini@ti.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/compat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)