| Message ID | 20201119174820.7820-2-nsaenzjulienne@suse.de |
|---|---|
| State | Superseded |
| Delegated to: | Matthias Brugger |
| Headers | show |
| Series | [1/8] rpi: Add identifier for the new RPi400 | expand |
On 19/11/2020 18:48, Nicolas Saenz Julienne wrote: > The Raspberry Pi Foundation released the new RPi400 which we want to > detect, so we can enable Ethernet on it and know the correct device tree > file name. > > So far the Raspberry Pi foundation is using the RPi4b device-tree file > to boot RPi400. I see no reason not to do the same as they are > completely compatible. > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > --- > board/raspberrypi/rpi/rpi.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c > index 6b1fa5fc14..ce60a24352 100644 > --- a/board/raspberrypi/rpi/rpi.c > +++ b/board/raspberrypi/rpi/rpi.c > @@ -157,6 +157,11 @@ static const struct rpi_model rpi_models_new_scheme[] = { > DTB_DIR "bcm2711-rpi-4-b.dtb", > true, > }, > + [0x13] = { > + "400", Holding to the documentation this should be "Pi 400". If I don't find any other issues, I can fix that up for you. No need for a v2. > + DTB_DIR "bcm2711-rpi-4-b.dtb", > + true, > + }, > }; > > static const struct rpi_model rpi_models_old_scheme[] = { >
Hi Matthias, thanks for the review! On Tue, 2020-12-01 at 17:55 +0100, Matthias Brugger wrote: > > On 19/11/2020 18:48, Nicolas Saenz Julienne wrote: > > The Raspberry Pi Foundation released the new RPi400 which we want to > > detect, so we can enable Ethernet on it and know the correct device tree > > file name. > > > > So far the Raspberry Pi foundation is using the RPi4b device-tree file > > to boot RPi400. I see no reason not to do the same as they are > > completely compatible. > > > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > > --- > > board/raspberrypi/rpi/rpi.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c > > index 6b1fa5fc14..ce60a24352 100644 > > --- a/board/raspberrypi/rpi/rpi.c > > +++ b/board/raspberrypi/rpi/rpi.c > > @@ -157,6 +157,11 @@ static const struct rpi_model rpi_models_new_scheme[] = { > > DTB_DIR "bcm2711-rpi-4-b.dtb", > > true, > > }, > > + [0x13] = { > > + "400", > > Holding to the documentation this should be "Pi 400". If I don't find any other > issues, I can fix that up for you. No need for a v2. The model is output during boot, and it looks like this: printf("RPI %s (0x%x)\n", model->name, revision); IMO it would look weird with the redundant 'Pi'. Ultimately the product name is 'Raspberry Pi 400', so we should be OK with having '400' as the suffix. Regards, Nicolas
diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c index 6b1fa5fc14..ce60a24352 100644 --- a/board/raspberrypi/rpi/rpi.c +++ b/board/raspberrypi/rpi/rpi.c @@ -157,6 +157,11 @@ static const struct rpi_model rpi_models_new_scheme[] = { DTB_DIR "bcm2711-rpi-4-b.dtb", true, }, + [0x13] = { + "400", + DTB_DIR "bcm2711-rpi-4-b.dtb", + true, + }, }; static const struct rpi_model rpi_models_old_scheme[] = {
The Raspberry Pi Foundation released the new RPi400 which we want to detect, so we can enable Ethernet on it and know the correct device tree file name. So far the Raspberry Pi foundation is using the RPi4b device-tree file to boot RPi400. I see no reason not to do the same as they are completely compatible. Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> --- board/raspberrypi/rpi/rpi.c | 5 +++++ 1 file changed, 5 insertions(+)