| Message ID | 20201117210018.751469-11-lkundrak@v3.sk |
|---|---|
| State | RFC |
| Delegated to: | Daniel Schwierzeck |
| Headers | show |
| Series | MIPS: Add support for JZ4730 and Skytone Alpha 400 | expand |
Hi Lubomir, On Tue, 2020-11-17 at 22:00 +0100, Lubomir Rintel wrote: > The driver doesn't use the jz4780's extra DMA channels and handles jz4740 > just fine. > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > --- > drivers/mmc/jz_mmc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/jz_mmc.c b/drivers/mmc/jz_mmc.c > index b33f0850738..d4b9d15ef2e 100644 > --- a/drivers/mmc/jz_mmc.c > +++ b/drivers/mmc/jz_mmc.c > @@ -490,6 +490,7 @@ static int jz_mmc_probe(struct udevice *dev) > } > > static const struct udevice_id jz_mmc_ids[] = { > + { .compatible = "ingenic,jz4740-mmc" }, Normally, you don't need to add another compatible if there's nothing in the implementation to distinguish them. However, I'm guessing here you want to add the compatible so you can support kernel compatibles such as ingenic,jz4740-mmc? Regards, Ezequiel > { .compatible = "ingenic,jz4780-mmc" }, > { } > };
diff --git a/drivers/mmc/jz_mmc.c b/drivers/mmc/jz_mmc.c index b33f0850738..d4b9d15ef2e 100644 --- a/drivers/mmc/jz_mmc.c +++ b/drivers/mmc/jz_mmc.c @@ -490,6 +490,7 @@ static int jz_mmc_probe(struct udevice *dev) } static const struct udevice_id jz_mmc_ids[] = { + { .compatible = "ingenic,jz4740-mmc" }, { .compatible = "ingenic,jz4780-mmc" }, { } };
The driver doesn't use the jz4780's extra DMA channels and handles jz4740 just fine. Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> --- drivers/mmc/jz_mmc.c | 1 + 1 file changed, 1 insertion(+)