diff mbox series

dfu: simplify the dependencies of DFU_TFTP

Message ID 20201117002716.13818-1-takahiro.akashi@linaro.org
State Accepted, archived
Commit c32479d1d2d9f0b0a56b674993860825a79dc3cc
Delegated to: Heinrich Schuchardt
Headers show
Series dfu: simplify the dependencies of DFU_TFTP | expand

Commit Message

AKASHI Takahiro Nov. 17, 2020, 12:27 a.m. UTC
Since CONFIG_UPDATE_COMMON always selects CONFIG_DFU_WRITE_ALT, we can
drop the latter from dependencies of CONFIG_DFU_TFTP.

Fixes: 3149e524fc1e ("common: update: add a generic interface for FIT
       image")
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
 drivers/dfu/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Heinrich Schuchardt Nov. 18, 2020, 4:31 p.m. UTC | #1
On 17.11.20 01:27, AKASHI Takahiro wrote:
> Since CONFIG_UPDATE_COMMON always selects CONFIG_DFU_WRITE_ALT, we can
> drop the latter from dependencies of CONFIG_DFU_TFTP.
>
> Fixes: 3149e524fc1e ("common: update: add a generic interface for FIT
>        image")
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

> ---
>  drivers/dfu/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
> index b7427fc4f0d6..121dc54f5463 100644
> --- a/drivers/dfu/Kconfig
> +++ b/drivers/dfu/Kconfig
> @@ -20,9 +20,8 @@ config DFU_WRITE_ALT
>
>  config DFU_TFTP
>  	bool "DFU via TFTP"
> -	select DFU_WRITE_ALT
> -	select DFU_OVER_TFTP
>  	select UPDATE_COMMON
> +	select DFU_OVER_TFTP
>  	help
>  	  This option allows performing update of DFU-managed medium with data
>  	  sent via TFTP boot.
>
diff mbox series

Patch

diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
index b7427fc4f0d6..121dc54f5463 100644
--- a/drivers/dfu/Kconfig
+++ b/drivers/dfu/Kconfig
@@ -20,9 +20,8 @@  config DFU_WRITE_ALT
 
 config DFU_TFTP
 	bool "DFU via TFTP"
-	select DFU_WRITE_ALT
-	select DFU_OVER_TFTP
 	select UPDATE_COMMON
+	select DFU_OVER_TFTP
 	help
 	  This option allows performing update of DFU-managed medium with data
 	  sent via TFTP boot.