diff mbox series

[3/4] fs: btrfs: initialize @ret to 0 to prevent uninitialized return value

Message ID 20201031010752.23974-4-wqu@suse.com
State Accepted
Commit 4891c4e595b48ee41b7d8062bb599d05a938ea0a
Delegated to: Tom Rini
Headers show
Series fs: btrfs: coverity fixes | expand

Commit Message

Qu Wenruo Oct. 31, 2020, 1:07 a.m. UTC 
In show_dir() if we hit a ROOT_ITEM, we can exit with uninitialized
@ret.

Fix it by initializing it to 0.

Reported-by: Coverity CID 312955
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 fs/btrfs/btrfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Behún Nov. 1, 2020, 11:03 p.m. UTC | #1 
Reviewed-by: Marek Behún <marek.behun@nic.cz>
Tom Rini Nov. 20, 2020, 1:36 a.m. UTC | #2 
On Sat, Oct 31, 2020 at 09:07:51AM +0800, Qu Wenruo wrote:

> In show_dir() if we hit a ROOT_ITEM, we can exit with uninitialized
> @ret.
> 
> Fix it by initializing it to 0.
> 
> Reported-by: Coverity CID 312955
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> Reviewed-by: Marek Behún <marek.behun@nic.cz>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/fs/btrfs/btrfs.c b/fs/btrfs/btrfs.c
index e48972ffa21a..346b2c4341c2 100644
--- a/fs/btrfs/btrfs.c
+++ b/fs/btrfs/btrfs.c
@@ -36,7 +36,7 @@  static int show_dir(struct btrfs_root *root, struct extent_buffer *eb,
 	char *target = NULL;
 	char filetime[32];
 	time_t mtime;
-	int ret;
+	int ret = 0;
 
 	btrfs_dir_item_key_to_cpu(eb, di, &key);