From patchwork Wed Oct 28 12:56:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Marko X-Patchwork-Id: 1389256 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sartura.hr Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=sartura-hr.20150623.gappssmtp.com header.i=@sartura-hr.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=C5xxZS+2; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CLpW74c4Vz9sVw for ; Wed, 28 Oct 2020 23:57:07 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 60495824C5; Wed, 28 Oct 2020 13:56:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sartura.hr Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=sartura-hr.20150623.gappssmtp.com header.i=@sartura-hr.20150623.gappssmtp.com header.b="C5xxZS+2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 23D9682483; Wed, 28 Oct 2020 13:56:39 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A17A2823F4 for ; Wed, 28 Oct 2020 13:56:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sartura.hr Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=robert.marko@sartura.hr Received: by mail-wm1-x343.google.com with SMTP id v5so4462803wmh.1 for ; Wed, 28 Oct 2020 05:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura-hr.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ILcW873S4cJhckbc1/8XWearEDgK+JoOxElRxqR5YZw=; b=C5xxZS+2voIC61k0uWFj2VCbq4HvuLQ01WvlaUBGqPceLpH1PBxQvUnwx7O0we5gBe PO7QDU21EAeu11DqY2sw/fNNzuFwUzQ7ICSn4z754Rjgl3ZBcTPhs51Gd3Dx/V7Sd8rd /jC+b7UoZ+ZxKoHnoh2qQLn+EaFiEWwLPwxckMnoGvBb8lXojkzd+Hb7AYyBx75GCFzC tT3qUvrCidlzraUi4A7Qnx6EV0Y47nGN20iNU6bgfKDbv2bpZ8e1B3R+2/quwmz2gRs9 +vAjjVtqMnh8ICNGEuZA+VVfMJOiGVbJGNsEkwd2oI4n78vrKjs1Mwtep1frU5PJ0nkL mK+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ILcW873S4cJhckbc1/8XWearEDgK+JoOxElRxqR5YZw=; b=Da1YyZywDQjt/RLG/kodRB+mqBh7C1x2XvhaT3OgdZwg56CzZKA8GwG33IEF6XIaAd vxXfbXjA9auiI/KOgCqIKHstamQ3eJr23i+flN+8BBNJqGgoSYaGDdCSRnMnIGo1lZBQ Dj36/Avilwdfca6Tjy5NQg2Gcr7D3m8WHdEIJbiZQv/VbUjCKCREJ1d7UKmntsYDUMJS bFybuKp3QErFlXfO0uFaCnAyIUEeYR08z2PJvxbUVIwIWjtvhypjzuqnQCINEdhryC/J LvtEPCEMsQPNUTOjdVllrMqAoVJOB/7n/9PI5zlOEJvjRI7pqEXNFJNVhavK83V8R9Rf 4p4A== X-Gm-Message-State: AOAM532BwlYo6szCHXwQ23w5hAFWB3rfPSs7vpG3KABHC5404VtsjG18 TTE99HD7Y/oEuAeSsUl+PRUJPfE1Bve1CMcIjcgjoOxFZS6OKkoDLVATYs4IopA0PFcseFzYD+o AWAUpDrapJrkVs2DmqSuj4JPIlgSEFNahq5OnF4+H1G0p6UJ0BGVyCMsZpmlzqZEo0Sua2SJi X-Google-Smtp-Source: ABdhPJwl9R2gcPpJErMhyavZV21TRQMI/JVPhCkfozOyd9ncdpQnQd9dRxyPDMj3aJ20bWRNUyQnow== X-Received: by 2002:a1c:7707:: with SMTP id t7mr8589898wmi.54.1603889795911; Wed, 28 Oct 2020 05:56:35 -0700 (PDT) Received: from localhost.localdomain (dh207-98-200.xnet.hr. [88.207.98.200]) by smtp.googlemail.com with ESMTPSA id q10sm6743233wrp.83.2020.10.28.05.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 05:56:35 -0700 (PDT) From: Robert Marko To: u-boot@lists.denx.de Cc: Robert Marko , Luka Perkov Subject: [PATCH 3/4] IPQ40xx: clk: dont always return 0 Date: Wed, 28 Oct 2020 13:56:25 +0100 Message-Id: <20201028125626.40067-3-robert.marko@sartura.hr> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201028125626.40067-1-robert.marko@sartura.hr> References: <20201028125626.40067-1-robert.marko@sartura.hr> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Currently the driver will go through the clock ID-s and set/enable them as needed. But if the ID is unknown it will fall through the switch case to the default case which will always return 0. This is not correct and default cases should return a error code since clock ID is unknown. So lets return -EINVAL instead. Signed-off-by: Robert Marko Cc: Luka Perkov --- arch/arm/mach-ipq40xx/clock-ipq4019.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-ipq40xx/clock-ipq4019.c b/arch/arm/mach-ipq40xx/clock-ipq4019.c index ac2b830353..7308563ad1 100644 --- a/arch/arm/mach-ipq40xx/clock-ipq4019.c +++ b/arch/arm/mach-ipq40xx/clock-ipq4019.c @@ -26,7 +26,7 @@ ulong msm_set_rate(struct clk *clk, ulong rate) /* This clock is already initialized by SBL1 */ return 0; default: - return 0; + return -EINVAL; } } @@ -56,7 +56,7 @@ static int msm_enable(struct clk *clk) /* This clock is already initialized by SBL1 */ return 0; default: - return 0; + return -EINVAL; } }