diff mbox series

[2/4] IPQ40xx: clk: drop breaks in switch case

Message ID 20201028125626.40067-2-robert.marko@sartura.hr
State Accepted
Commit 164cc98a7b9a8962a69cf4ae43bacb35eb98f51d
Delegated to: Tom Rini
Headers show
Series [1/4] IPQ40xx: clk: use dev_read_addr() | expand

Commit Message

Robert Marko Oct. 28, 2020, 12:56 p.m. UTC
There is no point in having break statements in the switch case as there is already a return before break.

So lets drop them from the driver.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Cc: Luka Perkov <luka.perkov@sartura.hr>
---
 arch/arm/mach-ipq40xx/clock-ipq4019.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Tom Rini Dec. 2, 2020, 9:22 p.m. UTC | #1
On Wed, Oct 28, 2020 at 01:56:24PM +0100, Robert Marko wrote:

> There is no point in having break statements in the switch case as there is already a return before break.
> 
> So lets drop them from the driver.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Cc: Luka Perkov <luka.perkov@sartura.hr>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/arch/arm/mach-ipq40xx/clock-ipq4019.c b/arch/arm/mach-ipq40xx/clock-ipq4019.c
index 1f385665cc..ac2b830353 100644
--- a/arch/arm/mach-ipq40xx/clock-ipq4019.c
+++ b/arch/arm/mach-ipq40xx/clock-ipq4019.c
@@ -25,7 +25,6 @@  ulong msm_set_rate(struct clk *clk, ulong rate)
 	case GCC_BLSP1_UART1_APPS_CLK: /*UART1*/
 		/* This clock is already initialized by SBL1 */
 		return 0;
-		break;
 	default:
 		return 0;
 	}
@@ -53,11 +52,9 @@  static int msm_enable(struct clk *clk)
 	case GCC_BLSP1_QUP1_SPI_APPS_CLK: /*SPI1*/
 		/* This clock is already initialized by SBL1 */
 		return 0;
-		break;
 	case GCC_PRNG_AHB_CLK: /*PRNG*/
 		/* This clock is already initialized by SBL1 */
 		return 0;
-		break;
 	default:
 		return 0;
 	}