From patchwork Tue Oct 27 23:55:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1389049 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=pN7fY+88; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CLTBF5X0Xz9sV1 for ; Wed, 28 Oct 2020 10:56:21 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 17DBF82496; Wed, 28 Oct 2020 00:56:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pN7fY+88"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BD383823DD; Wed, 28 Oct 2020 00:56:00 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 31840823DD for ; Wed, 28 Oct 2020 00:55:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qk1-x741.google.com with SMTP id j129so3037139qke.5 for ; Tue, 27 Oct 2020 16:55:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VplDn/Z3eLTaG0994elbCvKnWDlOsipC6/e0cfSXQ2w=; b=pN7fY+88lxTnljgqaBnaTtHK71MhLGWqKrN5rflP4ltLuMwc/6OnBXEkxnwverDYwN 1a4UkfYYwkU+K1RzlPo4oDWZ/OE0SsgKENpTCNVOY9NpODnJwt4/THrjS8QygNiZIF1n wTJHBUNhZDSsnjMtO/t8YFvbA/5NbPxG5Dx7YfSLx2rwFNowj8tfHhSursJhgD18bqDL 6nW7oXyrdC1W4aT/htr7bIsVhhEi3dzFfqtMhnczQxh09oS/vJPPUnin2ZNbdTde0cz9 YJ7scGtZAexoBhJ9zj65pjUHpMFfr9ez4kwleUoCFzqymMJ7l7POamMo8gTlm6qiIhhk NAng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VplDn/Z3eLTaG0994elbCvKnWDlOsipC6/e0cfSXQ2w=; b=hvOrvevEaMj5x7dJtMdHk7ynonLMinMeem4MErrnkVy5XSg1qw7oCypcbvsYGhgfze Qf83Oj31a2Xr6rrGFzrUxZD05q5G3ZOvEdvwS9MGcWTR5Dk3eSFFe+VVm1K9EDDIL41Q Ixc8MGZuR7+J9DvwkSfb7Rs33KYwAPpZvutsMXqaQL7GCvtl9j5R49X1cl8lPnq7OpM0 klhoJUSvigmWumCaJvzQ0OcOtSNmbSHm9InQTbvyuUUqvk8YJgtFtK4V18q2KD+oUs5P jWQsXF9hd/rIDQtaUWJnjE7rb2PtzRvSR/tgjRfBa70mq1gwjBqNa268/poAxk9NfrQ5 cQEQ== X-Gm-Message-State: AOAM53297zVnn6cDIOstUCYiI+uUycCkNxHvxfJHbvhG/K3fYEG5jeZU /cvJGz8n3D7odHYpmVUT9CQqfB0f/qB6PQ== X-Google-Smtp-Source: ABdhPJyOqRxbvAGENtlVLXHynOClZU5ssidA/peww4uxcnPbKQxqsTooYoMMxruJ3CH+Nq8uQQMxVw== X-Received: by 2002:a05:620a:10b7:: with SMTP id h23mr4662115qkk.132.1603842956797; Tue, 27 Oct 2020 16:55:56 -0700 (PDT) Received: from godwin.fios-router.home (pool-108-51-35-162.washdc.fios.verizon.net. [108.51.35.162]) by smtp.gmail.com with ESMTPSA id 69sm1907543qko.48.2020.10.27.16.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 16:55:56 -0700 (PDT) From: Sean Anderson To: u-boot@lists.denx.de Cc: Tom Rini , Heinrich Schuchardt , Simon Glass , Sean Anderson Subject: [PATCH v4 01/22] log: Fix missing negation of ENOMEM Date: Tue, 27 Oct 2020 19:55:20 -0400 Message-Id: <20201027235541.706077-2-seanga2@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201027235541.706077-1-seanga2@gmail.com> References: <20201027235541.706077-1-seanga2@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Errors returned should be negative. Fixes: 45fac9fc18 ("log: Correct missing free() on error in log_add_filter()") Signed-off-by: Sean Anderson Reviewed-by: Heinrich Schuchardt --- (no changes since v1) common/log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/log.c b/common/log.c index b7a6ebe298..6aab189a46 100644 --- a/common/log.c +++ b/common/log.c @@ -278,7 +278,7 @@ int log_add_filter(const char *drv_name, enum log_category_t cat_list[], if (file_list) { filt->file_list = strdup(file_list); if (!filt->file_list) { - ret = ENOMEM; + ret = -ENOMEM; goto err; } }