diff mbox series

[v2,03/10] drivers/video/rockchip/rk_edp.c: Change interrupt polarity configuration

Message ID 20201027132235.832232313@rtp-net.org
State Superseded
Delegated to: Kever Yang
Headers show
Series rk3399 (Pinebook pro) EDP support | expand

Commit Message

Arnaud Patard (Rtp) Oct. 27, 2020, 1:21 p.m. UTC 
The linux code is setting polarity configuration to 3 but
uboot code is setting it to 1. Change the configuration to match the
linux configuration

Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>

Comments

Alper Nebi Yasak Oct. 27, 2020, 10:32 p.m. UTC | #1 
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote:
> The linux code is setting polarity configuration to 3 but
> uboot code is setting it to 1. Change the configuration to match the
> linux configuration
> 
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>

On a rk3399-gru-kevin, (see comment in patch 1):

Tested-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
diff mbox series

Patch

Index: u-boot/arch/arm/include/asm/arch-rockchip/edp_rk3288.h
===================================================================
--- u-boot.orig/arch/arm/include/asm/arch-rockchip/edp_rk3288.h
+++ u-boot/arch/arm/include/asm/arch-rockchip/edp_rk3288.h
@@ -297,7 +297,9 @@  check_member(rk3288_edp, pll_reg_5, 0xa0
 
 /* int_ctl */
 #define SOFT_INT_CTRL				(0x1 << 2)
-#define INT_POL					(0x1 << 0)
+#define INT_POL1				(0x1 << 1)
+#define INT_POL0				(0x1 << 0)
+#define INT_POL					(INT_POL0 | INT_POL1)
 
 /* sys_ctl_1 */
 #define DET_STA					(0x1 << 2)