diff mbox series

[v3,01/23] log: Fix missing negation of ENOMEM

Message ID 20201017180749.119271-2-seanga2@gmail.com
State Deferred
Delegated to: Tom Rini
Headers show
Series log: Add commands for manipulating filters | expand

Commit Message

Sean Anderson Oct. 17, 2020, 6:07 p.m. UTC 
Errors returned should be negative.

Fixes: 45fac9fc18 ("log: Correct missing free() on error in log_add_filter()")

Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

(no changes since v1)

 common/log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/common/log.c b/common/log.c
index 1b10f6f180..807babbb6e 100644
--- a/common/log.c
+++ b/common/log.c
@@ -273,7 +273,7 @@  int log_add_filter(const char *drv_name, enum log_category_t cat_list[],
 	if (file_list) {
 		filt->file_list = strdup(file_list);
 		if (!filt->file_list) {
-			ret = ENOMEM;
+			ret = -ENOMEM;
 			goto err;
 		}
 	}