From patchwork Tue Sep 29 19:48:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1373634 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=Nq0RzkwS; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C191G36Yyz9sSJ for ; Wed, 30 Sep 2020 05:48:25 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1F6A48158B; Tue, 29 Sep 2020 21:48:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="Nq0RzkwS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CA76E8174F; Tue, 29 Sep 2020 21:48:17 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 62E6B808B2 for ; Tue, 29 Sep 2020 21:48:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601408894; bh=gU0KSFReUN3OJKWblf1d2zJcW4c6bkVxVJpKCO4/L3I=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=Nq0RzkwSe5Bddym9XWZqbwTUjW/9AE++/QQ+uoj04nRg/5vs+he/RXS15LwXVwXYT HXpIVhlFwcH0lPOADSvcl3jEXBH5/3C2xPIbDUvjV8koibqhuZ1EZLU59EIxrueG7I dqUN/yAjI+REWttkagBC2wGTZw8Bup599Px49PWA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([178.202.41.107]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1N6siz-1kUBlZ0FFX-018MaG; Tue, 29 Sep 2020 21:48:14 +0200 From: Heinrich Schuchardt To: Peng Fan Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] mmc: do not check argument of free() beforehand Date: Tue, 29 Sep 2020 21:48:08 +0200 Message-Id: <20200929194808.58522-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:gwJwlifaPcEViKVEcLZbjfG5wbdzBbFvi/XebEhF4OcUyFpBRrq uaH8jGkGL11XF+ByW8nWtxneyMSpS8fyCUI3TCXFDkGAYC76EDyLLPsc5yidbaQu+GqUgiB mdhLCx4s13e7OHOu3rfN/nX9wtaOTk2ctXRufMjM4PVcMKqLq9P5Gxzkp27rH2jpElwBlvw PZGfkgANoHNBqgKle+59w== X-UI-Out-Filterresults: notjunk:1;V03:K0:mpgN/2msNJ0=:IFBfUsSJ9l26CYSWorEImo RgZ9ZQtuFnlCknloQdXO9waoSdSwHRoAbHV8VfGfVdadrKqV51ZQCquWpbStdMhMcKTMyYngn tTQIl0B/JXHoFYjZJWp2X7kkhEmnIzJFF1yg8wYJEsRKhWAOmVYM81xjx9wPBUKrndHliW7IZ cqWeE01dXJsFwO+HzrUFADEhVkTKx2leCKNqrGB+iasHNRN30TXxNTxNjGW+3WhjshNOHgrfm fOhH/qiuLyCB9P69ju6T0IpH8GCiWIgPFD0WJ8GqcI/2A+DLrAT9YfpUv3H9gHaMxe2IT8zcT JOVAU3XW3YxJ4q2zucElcF8+fQwiUvZ+pvNEph4QXlJf9Xc48rt79bp8hEcBWRVACD+Atx4pv g+X0po2Np8vR/AVlHRecwlq0b1kEZAbnHLStP4IkOd185EOOuv7D3Mouh0iB0RbtFldNYeuaJ slACqUHDBapeQhT8VdVNbSqPXeGDvNnx/TiZpfc3eWcOrhCcvLrEe+lBaz4FYGFWZ+5L0HN8s SlQqVVpQCu/NB0sv6GUnqwR3Z7aJkkkwGQjKPP6H6Kkc87ipaAOaoc9frm6aJsEc41a4z7DgW Y7cogh+FeAyXNt+5H844j5SbPhIhRMSlLvvdirLQ3U3wIB6qEQ6b2B1JYhCxexVvojYpUaN8e ZuFDw4IK7Xr0rjNBvK3wc0fsZLb6lgirpbdCirG2wHf51v/6y/jTU5YioZwGgSwvdPRkgaJDg uxz9EE4GyPmh8DnW5jT8J/hjwJ5uiJaiq0ojw//suidQ8GUsdcGQrHsr4MxL96t7ms7G7Bt4o T8MgHeVtAK4ea7fjHSNx9p+t0OJOcTQcrjyYxGMDQTRKLzwdISzJ0D+gQBZMOolxNIu+TPrGs AFjepr+PYJ6OGy0sS+KjqZfnzXciRtGbdz/Kthj+txprocrifdDsPhlR3C0JYqHktnxV30h79 saIgeFxol6u2Acn8gidton4YUJESFUc3sYf/Cnl+8OdrJ0lYYaFQkRvLvk/kFd9mxKYNv8dmH JiGUOBL6DXfZE9fc3j4X8PvnoT6NZuia68SWYpfs1CxbdX78j3pTNoyjY/CyUopedtB8Mo7zA Mm0z4r1pjWtGIBkJvxXmVoPCJpclEWh48OazY3+4gHQ14nV67j1pcKbvY2YX7pc3/NhMyC7jl gseh5Wx3v8R36q87EyRXXEHuVUAuLT4sTCYeY6Yf7Z3TmfIoIcgdXO0K8Nz0544gR/tI2/EST C2bOIovI1XLeMPfwkxnAjeRjQ7Y91lx1WZOiYHA== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean free() checks if its argument in NULL. No need to check it twice. Signed-off-by: Heinrich Schuchardt --- drivers/mmc/sh_sdhi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.28.0 diff --git a/drivers/mmc/sh_sdhi.c b/drivers/mmc/sh_sdhi.c index 315f95cce8..29f83b6554 100644 --- a/drivers/mmc/sh_sdhi.c +++ b/drivers/mmc/sh_sdhi.c @@ -784,8 +784,7 @@ int sh_sdhi_init(unsigned long addr, int ch, unsigned long quirks) return ret; error: - if (host) - free(host); + free(host); return ret; }