From patchwork Mon Sep 28 04:25:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1372338 X-Patchwork-Delegate: bmeng.cn@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=SDhRVJd3; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C08gr1Jzvz9sSn for ; Mon, 28 Sep 2020 14:30:00 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5847082473; Mon, 28 Sep 2020 06:27:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="SDhRVJd3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 46CE2823B5; Mon, 28 Sep 2020 06:26:42 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0770A823B3 for ; Mon, 28 Sep 2020 06:26:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-ot1-x342.google.com with SMTP id g96so8365748otb.12 for ; Sun, 27 Sep 2020 21:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2nNg3mzMWAMwzrc2+3GNjwjGawhgxlMu5fAcgsC/vO8=; b=SDhRVJd3CuP7w/+hh6ir6Mnug5rcLmwCnM1jwpQobPvKswrYiUn4+mQ8cKwsOkh4yZ uGNndVuuRHVAeGwA607Q/fCDOrglUua8X6Knq3Opl3dKSk6PUrhCk18YbNu6uUCuDNfV Lw/YC3vH74v9GKbw9T8QgH6lGKV75KlU/phV0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2nNg3mzMWAMwzrc2+3GNjwjGawhgxlMu5fAcgsC/vO8=; b=Kl94AZ9uLvqmGzX+xAyPiGwk1Fflet8EsUCg+4fixV4FsgDQYWaj0sNUYdRysS+Q/x m8bwUm2lvxEvXlxpkb1KH2v1dzpPO8yIzYwD+oPti+Av8cddeCtEmgGPZQQIZmFqQOhs ysFb8AcMTYyAjRS//x1alzpfdeTPb1UY1+dr0qscgCptpeB2tbzhzTBh9D7VSXGoMDoe V1PNuSEm0Z5yJk2wllbhFUeHcxjVBoPYUJHQtA8kUe5J8VNpmo3fzn2s6BqFOk6wbk6Z h1lHWms6YM+fYa5yPRKNXFT02Klz2tlM29mL2T/p9wUbzeFdeh4nsQ2QgvWxUR3IB79D 4yYg== X-Gm-Message-State: AOAM531n2rW3BHIkL+/J2cZG9lWYVEo1B2IpNJ5WbYRhIHhdSg74RKHC 5xNbO1fCoJWMYTfXwY/4K6BeAelb8fBd5+2z X-Google-Smtp-Source: ABdhPJw9HI7dMcgY/Miu7ae62eT/bYhSorYg5HjbEC8v1YgbA2Xf/9EDg3saCH+UHzaJVWNq1yj4Ow== X-Received: by 2002:a9d:12ab:: with SMTP id g40mr7908768otg.369.1601267197801; Sun, 27 Sep 2020 21:26:37 -0700 (PDT) Received: from localhost.localdomain (c-73-14-175-90.hsd1.co.comcast.net. [73.14.175.90]) by smtp.gmail.com with ESMTPSA id k51sm2620579otc.46.2020.09.27.21.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2020 21:26:37 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Andy Shevchenko , Heinrich Schuchardt , Bernhard Messerklinger , Wolfgang Wallner , Walter Lozano , Simon Glass , Bin Meng Subject: [PATCH 18/32] x86: sound: Correct error handling Date: Sun, 27 Sep 2020 22:25:57 -0600 Message-Id: <20200928042611.1696178-17-sjg@chromium.org> X-Mailer: git-send-email 2.28.0.681.g6f77f65b4e-goog In-Reply-To: <20200928042611.1696178-1-sjg@chromium.org> References: <20200928042611.1696178-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean A few functions have changed to return pin numbers or I2C addresses. The error checking for some of the callers is therefore wrong. Fix them. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- drivers/sound/da7219.c | 4 ++-- drivers/sound/max98357a.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/sound/da7219.c b/drivers/sound/da7219.c index 6bc1ad0036e..8d674bcb4fa 100644 --- a/drivers/sound/da7219.c +++ b/drivers/sound/da7219.c @@ -54,13 +54,13 @@ static int da7219_acpi_fill_ssdt(const struct udevice *dev, acpigen_write_name(ctx, "_CRS"); acpigen_write_resourcetemplate_header(ctx); ret = acpi_device_write_i2c_dev(ctx, dev); - if (ret) + if (ret < 0) return log_msg_ret("i2c", ret); /* Use either Interrupt() or GpioInt() */ ret = acpi_device_write_interrupt_or_gpio(ctx, (struct udevice *)dev, "req-gpios"); - if (ret) + if (ret < 0) return log_msg_ret("irq_gpio", ret); acpigen_write_resourcetemplate_footer(ctx); diff --git a/drivers/sound/max98357a.c b/drivers/sound/max98357a.c index 827262d235c..b3d27a3616e 100644 --- a/drivers/sound/max98357a.c +++ b/drivers/sound/max98357a.c @@ -69,7 +69,7 @@ static int max98357a_acpi_fill_ssdt(const struct udevice *dev, acpigen_write_name(ctx, "_CRS"); acpigen_write_resourcetemplate_header(ctx); ret = acpi_device_write_gpio_desc(ctx, &priv->sdmode_gpio); - if (ret) + if (ret < 0) return log_msg_ret("gpio", ret); acpigen_write_resourcetemplate_footer(ctx);