diff mbox series

[4/5] qemu: Drop ARCH_SUPPORT_TFABOOT

Message ID 20200924001715.30975-5-andre.przywara@arm.com
State Superseded
Delegated to: Tom Rini
Headers show
Series qemu-arm64: Allow booting via Trusted Firmware | expand

Commit Message

André Przywara Sept. 24, 2020, 12:17 a.m. UTC
CONFIG_ARCH_SUPPORT_TFABOOT seems to be a guard option to enable various
platform specific hacks, when U-Boot is run under TF-A.
Now that the QEMU port does not need to differentiate between secure
vs. non-secure anymore (this is taken care of by the DTB), there is
no need for a build-time option anymore, so remove it.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 arch/arm/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Tom Rini Sept. 29, 2020, 1:23 p.m. UTC | #1
On Thu, Sep 24, 2020 at 01:17:14AM +0100, Andre Przywara wrote:

> CONFIG_ARCH_SUPPORT_TFABOOT seems to be a guard option to enable various
> platform specific hacks, when U-Boot is run under TF-A.
> Now that the QEMU port does not need to differentiate between secure
> vs. non-secure anymore (this is taken care of by the DTB), there is
> no need for a build-time option anymore, so remove it.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>

I don't quite like calling the changes under TFABOOT hacks in that
ARCH_SUPPORT_TFABOOT is used to guard TFABOOT and on other platforms
that's used to enable/disable various non-hacky build time things.
Maybe we need to tweak the help text on TFABOOT to be clear that only
may be required on a given platform?
André Przywara Sept. 29, 2020, 5:13 p.m. UTC | #2
On 29/09/2020 14:23, Tom Rini wrote:

Hi Tom,

> On Thu, Sep 24, 2020 at 01:17:14AM +0100, Andre Przywara wrote:
> 
>> CONFIG_ARCH_SUPPORT_TFABOOT seems to be a guard option to enable various
>> platform specific hacks, when U-Boot is run under TF-A.
>> Now that the QEMU port does not need to differentiate between secure
>> vs. non-secure anymore (this is taken care of by the DTB), there is
>> no need for a build-time option anymore, so remove it.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> 
> I don't quite like calling the changes under TFABOOT hacks in that

Yeah, hack sounds too harsh, apologies for that. I will reword the
commit message. On a first glance the code guarded by that symbol seemed
to be only very loosely connected to TF-A.

> ARCH_SUPPORT_TFABOOT is used to guard TFABOOT and on other platforms
> that's used to enable/disable various non-hacky build time things.
> Maybe we need to tweak the help text on TFABOOT to be clear that only
> may be required on a given platform?

Well, looking more closely now it looks like on STM32 and FSL this makes
the difference between: Does U-Boot handle the secure side (errata
handling, provide PSCI services) or is this done by other firmware (TF-A).
This seems like a legitimate option(*), but this may indeed be better
explained. I can make a patch for that if this seems useful.

Cheers.
Andre


(*) ... although one could argue that this could decided at runtime, by
looking at the EL U-Boot is entered in. But this is quite a separate
discussion and most probably not worth the effort.
Tom Rini Sept. 29, 2020, 5:21 p.m. UTC | #3
On Tue, Sep 29, 2020 at 06:13:09PM +0100, André Przywara wrote:
> On 29/09/2020 14:23, Tom Rini wrote:
> 
> Hi Tom,
> 
> > On Thu, Sep 24, 2020 at 01:17:14AM +0100, Andre Przywara wrote:
> > 
> >> CONFIG_ARCH_SUPPORT_TFABOOT seems to be a guard option to enable various
> >> platform specific hacks, when U-Boot is run under TF-A.
> >> Now that the QEMU port does not need to differentiate between secure
> >> vs. non-secure anymore (this is taken care of by the DTB), there is
> >> no need for a build-time option anymore, so remove it.
> >>
> >> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > 
> > I don't quite like calling the changes under TFABOOT hacks in that
> 
> Yeah, hack sounds too harsh, apologies for that. I will reword the
> commit message. On a first glance the code guarded by that symbol seemed
> to be only very loosely connected to TF-A.
> 
> > ARCH_SUPPORT_TFABOOT is used to guard TFABOOT and on other platforms
> > that's used to enable/disable various non-hacky build time things.
> > Maybe we need to tweak the help text on TFABOOT to be clear that only
> > may be required on a given platform?
> 
> Well, looking more closely now it looks like on STM32 and FSL this makes
> the difference between: Does U-Boot handle the secure side (errata
> handling, provide PSCI services) or is this done by other firmware (TF-A).
> This seems like a legitimate option(*), but this may indeed be better
> explained. I can make a patch for that if this seems useful.

Yes please, thanks!
diff mbox series

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index d079e1930fc..dde8c4c3644 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -929,7 +929,6 @@  config ARCH_OWL
 
 config ARCH_QEMU
 	bool "QEMU Virtual Platform"
-	select ARCH_SUPPORT_TFABOOT
 	select DM
 	select DM_SERIAL
 	select OF_CONTROL