From patchwork Tue Sep 22 09:23:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Z.Q. Hou" X-Patchwork-Id: 1368870 X-Patchwork-Delegate: priyanka.jain@nxp.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=D1CsSJHS; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bwbh01z9Bz9sTC for ; Tue, 22 Sep 2020 19:32:48 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CD88182592; Tue, 22 Sep 2020 11:32:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="D1CsSJHS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BAB6482451; Tue, 22 Sep 2020 11:32:25 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2061e.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::61e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ACDFC82390 for ; Tue, 22 Sep 2020 11:32:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=zhiqiang.hou@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nZ+9dW7+hsH8L+ao0X+6rG0c+jhHBL9NPta/mz7tkiBksSd7EvxBVeYhJAFuXh9lVba7G00dzqLOASev3G1UaHbMXgSmgbacStCW25mYIPOKrIAIUuzySrQaQS3AfAknxTTPqZOcbtwRi6lKyMBHDXPuX4aa2eVPkxzx6d5lefj5oU9ZcuS9mXn0NR/Zd3XCWAMkdW7znHEDj2K/cDKdUKc+GDfNn3uINbxoU4r13J0efPm+PObTsv3gZMAYT6w57/e5sshAoIDVamhceIEPuLMCaGTMnVAK9GSu2Ml8CxaJqdskEUXuidvcGPdgCjoPE/tS4rIZduepk8VMrQA9Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YZcIRbFuFNtnOcscAp91eEBOdujt0FS7hUT+SJyksP0=; b=aWEWmTlV7DiavQYQ1up6DIhNH7MhgwF4R/qXVUf06OZVh9krBQfrX12BCaG/cLukmG4MJKhha8scr3iLsMKBRdBJxCDtyWnRQ6tZFyqpH8TqI70BdbGp+flyZxjkC4Iui14dTowYVCxLYThMVVoSS/lnbnhWLM2LhYVsz8Q1kaoyA7PHWfUKqUi4cPQVLcnKu1dx4iAcUZ4io7q1Z6duXm2r0Q99706bluNdm8jiASX4QFYppHitH3igSxhHEAHCGIpPTq2kdfcTIx8lPFcp2do+rMIDXkuetcKlF93UDCnSU5pa+dTqfuS4RYAl/4kjeLvlQKxLnCjJb3edWbzVSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YZcIRbFuFNtnOcscAp91eEBOdujt0FS7hUT+SJyksP0=; b=D1CsSJHSfXZ5asM1hL0G1gijLFbN5g/OumTICwTXXZN1GfrybLtDGuG+IlugZF9l+i/jLjW7j/dKitm5K5fR591z/Pu2RmH5JcLN+Z1dnjHipKkCDmasF85czH0gTGO9DcPehpaa1LjxHBfBdx2YIPKAElhDbk15dlwTSsG5rVY= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from HE1PR0402MB3371.eurprd04.prod.outlook.com (2603:10a6:7:85::27) by HE1PR0402MB2889.eurprd04.prod.outlook.com (2603:10a6:3:d6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.17; Tue, 22 Sep 2020 09:32:21 +0000 Received: from HE1PR0402MB3371.eurprd04.prod.outlook.com ([fe80::c872:d354:7cf7:deb9]) by HE1PR0402MB3371.eurprd04.prod.outlook.com ([fe80::c872:d354:7cf7:deb9%3]) with mapi id 15.20.3391.026; Tue, 22 Sep 2020 09:32:21 +0000 From: Zhiqiang Hou To: u-boot@lists.denx.de, bmeng.cn@gmail.com, olteanv@gmail.com, priyanka.jain@nxp.com Cc: Vladimir Oltean , Hou Zhiqiang Subject: [PATCHv6 01/18] phy: make phy_connect_fixed work with a null mdio bus Date: Tue, 22 Sep 2020 17:23:30 +0800 Message-Id: <20200922092347.19141-2-Zhiqiang.Hou@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200922092347.19141-1-Zhiqiang.Hou@nxp.com> References: <20200922092347.19141-1-Zhiqiang.Hou@nxp.com> X-ClientProxiedBy: SG2PR06CA0169.apcprd06.prod.outlook.com (2603:1096:1:1e::23) To HE1PR0402MB3371.eurprd04.prod.outlook.com (2603:10a6:7:85::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.73) by SG2PR06CA0169.apcprd06.prod.outlook.com (2603:1096:1:1e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13 via Frontend Transport; Tue, 22 Sep 2020 09:32:18 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [119.31.174.73] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 99e13ddb-59c3-4b87-d437-08d85eda67cb X-MS-TrafficTypeDiagnostic: HE1PR0402MB2889: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /e5MTYXqoWmKo2USvdx/uT0no/8vSnh07CmUakSDkphJHSeDzZhDQRP/yBbbLOzKQ9++S/XnwNTCqm1hikxsrXlaaDa+gs/fKFbaIPLCn9h2Hl1GYD6yeGWXCORoPDWohjpN3qa1Zh9W4Zy1Amh/jhP9YWyY0Hb/Fjw2Nxkz3wQ73XSoEP3bHqncJXjOponoARgBkUQAyUcdj2Y/RLvxsdCGMLLj7y9UIGAU4eEQN6W6Y2kOgj502/iOtlyspmN4xKRAk1S/20m0gDVb3S3fZrogktAk27trn1lx7a79bJ5RUx3iJn3pxZ7ERuenEuJN/xLpOFM8TfiFDzjPJEwvGo+Ix5es+8GoTaSCrrcGojz0RE43QOWdpjWQBX1rQAyL X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0402MB3371.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(136003)(396003)(39860400002)(346002)(8676002)(66946007)(6636002)(5660300002)(316002)(8936002)(6512007)(4326008)(66556008)(66476007)(2906002)(83380400001)(186003)(26005)(478600001)(86362001)(69590400008)(6506007)(54906003)(1076003)(52116002)(16526019)(956004)(6486002)(36756003)(2616005)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: VzwnMmz9+kxPY0yopy0+bxKHvWSoMShzN+peHz5IhWTQS+PYBvRnRfTukENAM3uBCo1mQtSs182C68SAC6zSRJ4WuhGuohMYRBhrVhU2uiXNA8Izn+mrFbkibAQ+4zRyXBpyFmoECTNwGLgkHNRa2AQjBncnkhCR37TS9xWa5InBovuqZqTToMZwU02i3OVT2Qb8YwUzEIeFX1jRFga+vojgqs0t+kyymjVaZ3KaZmqDA3vnRtG1HKfCDzSnJm8dvjBu6v3ZQi9pwdbWdXD+x+IlxPUDzPpXsxLcz/Htr/ptOXyWvg/f8lLvIkTjvodprSti3DN75Tt2V2ZpuF+/uZjc9kfaAru16DEFuJJuvhFGouZj1gEQRBRhnK4Amgt/nxUttzWa8dRfij3EmjfG4JxYO+DO083zA4CIzdlE+92q22c8bWGnrblksFna1ILW2Zd7G7azl0exPoz7wKe/QHKLqkJKjSr371HziONvfHNB2XN40HARNBqNzhXBoqoAaqmQL6gALxWfp8OceuIObni/iuMx3r8LPykEIbPippbxhovp5aZX9Whup6F2rgVZg5Sply7y9XAmRgPA9TP04+Ar+U46thYS1er/j/b44UqgmXxv6oIkLeaaRm3KEHf0FBaLS9XpjOXs7zgqEz8p4A== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99e13ddb-59c3-4b87-d437-08d85eda67cb X-MS-Exchange-CrossTenant-AuthSource: HE1PR0402MB3371.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 09:32:21.4065 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pzdi+YxC8bWvGMkVmdrMK9bmNk4ErCQQuMTy4bTUrUFe6PqV4gQmuMtvbZ9r9rWkey0v98XjrBs375HVqeiRrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2889 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean From: Vladimir Oltean It is utterly pointless to require an MDIO bus pointer for a fixed PHY device. The fixed.c implementation does not require it, only phy_device_create. Fix that. Signed-off-by: Vladimir Oltean Signed-off-by: Hou Zhiqiang Reviewed-by: Hou Zhiqiang --- V6: - No change. drivers/net/phy/phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 67789897c2..9587e6b9fa 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -664,7 +664,7 @@ static struct phy_device *phy_device_create(struct mii_dev *bus, int addr, dev = malloc(sizeof(*dev)); if (!dev) { printf("Failed to allocate PHY device for %s:%d\n", - bus->name, addr); + bus ? bus->name : "(null bus)", addr); return NULL; } @@ -692,7 +692,7 @@ static struct phy_device *phy_device_create(struct mii_dev *bus, int addr, return NULL; } - if (addr >= 0 && addr < PHY_MAX_ADDR) + if (addr >= 0 && addr < PHY_MAX_ADDR && phy_id != PHY_FIXED_ID) bus->phymap[addr] = dev; return dev;