diff mbox series

net: ravb: Remove writeext function call

Message ID 20200922065141.2841-1-biju.das.jz@bp.renesas.com
State Accepted
Commit 9275a963d448562a80213639c73e2dc34c6d1835
Delegated to: Marek Vasut
Headers show
Series net: ravb: Remove writeext function call | expand

Commit Message

Biju Das Sept. 22, 2020, 6:51 a.m. UTC
The micrel phy driver is already configuring this values from
device tree. So remove the redundant phy configuration call from
this driver.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
Tested on RCar M3N board, the final configuration value is same.
rxc-skew-ps 19
ksz90x1_of_config_group Final:1f9
---
 drivers/net/ravb.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Marek Vasut Sept. 22, 2020, 1:11 p.m. UTC | #1
On 9/22/20 8:51 AM, Biju Das wrote:
> The micrel phy driver is already configuring this values from
> device tree. So remove the redundant phy configuration call from
> this driver.

Applied to sh/next, thanks
diff mbox series

Patch

diff --git a/drivers/net/ravb.c b/drivers/net/ravb.c
index 886f53ee82..98883cd15b 100644
--- a/drivers/net/ravb.c
+++ b/drivers/net/ravb.c
@@ -438,8 +438,6 @@  static int ravb_config(struct udevice *dev)
 
 	writel(mask, eth->iobase + RAVB_REG_ECMR);
 
-	phy->drv->writeext(phy, -1, 0x02, 0x08, (0x0f << 5) | 0x19);
-
 	return 0;
 }