| Message ID | 20200914235811.19779-2-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 73fdb9558ed15df868b4b07bdc61ab682b49bd59 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [1/1] bootm: add {arch,board}_preboot_os() to bootm.h | expand |
Am 2020-09-15 01:58, schrieb Heinrich Schuchardt: > Functions that are used in multiple C modules should be defined in an > include. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Reviewed-by: Michael Walle <michael@walle.cc> I've noticed that the boards which use arch_preboot_os() (?!) or board_preboot_os() doesn't include this header, though. -michael
On 15.09.20 09:38, Michael Walle wrote: > Am 2020-09-15 01:58, schrieb Heinrich Schuchardt: >> Functions that are used in multiple C modules should be defined in an >> include. >> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > > Reviewed-by: Michael Walle <michael@walle.cc> > > I've noticed that the boards which use arch_preboot_os() (?!) or > board_preboot_os() doesn't include this header, though. Yes, this will require further patches. Best regards Heinrich
On Tue, Sep 15, 2020 at 01:58:11AM +0200, Heinrich Schuchardt wrote: > Functions that are used in multiple C modules should be defined in an > include. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Reviewed-by: Michael Walle <michael@walle.cc> Applied to u-boot/master, thanks!
diff --git a/include/bootm.h b/include/bootm.h index 0350c349f3..a812a6bf24 100644 --- a/include/bootm.h +++ b/include/bootm.h @@ -75,4 +75,14 @@ void board_quiesce_devices(void); */ void switch_to_non_secure_mode(void); +/** + * arch_preboot_os() - arch specific configuration before booting + */ +void arch_preboot_os(void); + +/** + * board_preboot_os() - board specific configuration before booting + */ +void board_preboot_os(void); + #endif
Functions that are used in multiple C modules should be defined in an include. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- include/bootm.h | 10 ++++++++++ 1 file changed, 10 insertions(+) -- 2.28.0