From patchwork Mon Sep 7 18:16:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1359185 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=AoRsMekK; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Blc3f6Klxz9sT6 for ; Tue, 8 Sep 2020 04:18:38 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DF04882525; Mon, 7 Sep 2020 20:17:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="AoRsMekK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B465D82512; Mon, 7 Sep 2020 20:17:25 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2784C824A5 for ; Mon, 7 Sep 2020 20:17:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qk1-x742.google.com with SMTP id 16so3918484qkf.4 for ; Mon, 07 Sep 2020 11:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V/DPVA13siXrNoLS1XJH2bIp1oug8hJX+iDYYtn2Y/M=; b=AoRsMekK7rMe2+BErZ+BVpyqY3n+4ZLe3/su8vG+nwL+9vBwNQ8NWAYauv3plalYJn I81I/Gepv8nIPwZp/wk6GZElx/cdlF/y4m1RNTQzwtszPzZbXOCRhSWfoREfMZMXYgOz Y4QAWbMyMFDiywhtpm3wauNFlB+tmHNnDbwXnILogG6EF461I0PUXatEcmsMKYd7mpec XAKOm+b2C5xBVG2XufJI13yqko6cx/XOIn3VGglO465eYJzkldBX49zPKtqEgylUwG+F lXJdJVN60f/9OwphER5nACCWD9AfZCgyF0dlRk8+RB6jn8qgFIzb4Wb2bp4OLxA3qOCA Zamg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V/DPVA13siXrNoLS1XJH2bIp1oug8hJX+iDYYtn2Y/M=; b=Pkg673h3+E9xTzCQAXwr/h3hnVqA82het3oWL1dFJ1K6ic1HlCInn5dflVjoFn3tBA O7n7ERwqVTINMJ7j9fmO8+ALnRhRrfG7CzuGFp1cFzu34LwZilUobn9PAbYq3g/BsrpH SsvXwT8ysYiaKZsJZ0UWs/nvo7wUzEYvhljDRhdDekVolSt+uFZvm+gNU2bzXCqmKlvo nTNGLnnEyTiyJl3oH9TTn8GAxQB+fisNkAXejERYVU99pN+T9I2H+3ZgbIJWoc6kzgWL EaIhxL0RT7AD4SWGnNx/27rtlT6x4HSzlAzkr5GNYaFudFbyLG0gvsFmdXdToCYQm448 wVyA== X-Gm-Message-State: AOAM531YsoynR2azkxqLz4Tc/yB4flY7WblCDX3+cZLofVtMz9vWh8ny Ogejvt0OIqIN+2ti1YtvIVvAfiY88aGSiA== X-Google-Smtp-Source: ABdhPJxLk6tO0EJbPUS0Qb+RRjj9mp462oAjhnPc/+A7fF0YmR7JCdQixOB7fE89TZv0AoYGlzUO4A== X-Received: by 2002:a05:620a:220f:: with SMTP id m15mr5893321qkh.255.1599502641810; Mon, 07 Sep 2020 11:17:21 -0700 (PDT) Received: from godwin.fios-router.home (pool-108-51-35-162.washdc.fios.verizon.net. [108.51.35.162]) by smtp.gmail.com with ESMTPSA id w3sm11577212qkc.10.2020.09.07.11.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 11:17:21 -0700 (PDT) From: Sean Anderson To: u-boot@lists.denx.de Cc: Rick Chen , Heinrich Schuchardt , Bin Meng , Sean Anderson Subject: [PATCH 7/7] riscv: Add some comments to start.S Date: Mon, 7 Sep 2020 14:16:59 -0400 Message-Id: <20200907181659.92449-8-seanga2@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200907181659.92449-1-seanga2@gmail.com> References: <20200907181659.92449-1-seanga2@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean This adds comments regarding the ordering and purpose of certain instructions as I understand them. Signed-off-by: Sean Anderson --- arch/riscv/cpu/start.S | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/arch/riscv/cpu/start.S b/arch/riscv/cpu/start.S index 59d3d7bbf4..c659c6df53 100644 --- a/arch/riscv/cpu/start.S +++ b/arch/riscv/cpu/start.S @@ -43,7 +43,10 @@ _start: csrr a0, CSR_MHARTID #endif - /* save hart id and dtb pointer */ + /* + * Save hart id and dtb pointer. The thread pointer register is not + * modified by C code, and may be used in trap handlers. + */ mv tp, a0 mv s1, a1 @@ -54,10 +57,18 @@ _start: */ mv gp, zero + /* + * Set the trap handler. This must happen after initializing tp and gp + * because the handler may use these registers. + */ la t0, trap_entry csrw MODE_PREFIX(tvec), t0 - /* mask all interrupts */ + /* + * Mask all interrupts. Interrupts are disabled globally (in m/sstatus) + * for U-Boot, but we will need to read m/sip to determine if we get an + * IPI + */ csrw MODE_PREFIX(ie), zero #if CONFIG_IS_ENABLED(SMP) @@ -407,6 +418,10 @@ secondary_hart_relocate: mv gp, a2 #endif +/* + * Interrupts are disabled globally, but they can still be read from m/sip. The + * wfi function will wake us up if we get an IPI, even if we do not trap. + */ secondary_hart_loop: wfi