diff mbox series

[v2,14/15] x86: intel: slimbootloader: Remove dead code

Message ID 20200820100234.70576-14-andriy.shevchenko@linux.intel.com
State Accepted
Commit c2addf9fc171de55d99fcccd7e5622894f74fe18
Delegated to: Bin Meng
Headers show
Series [v2,01/15] x86: Introduce USE_EARLY_BOARD_INIT option | expand

Commit Message

Andy Shevchenko Aug. 20, 2020, 10:02 a.m. UTC
start.S does nothing and can be safely removed. Makefile is still being used
by the build system, so simply drop the rule from it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Aiden Park <aiden.park@intel.com>
---
v2: added Rb tag(s)

 board/intel/slimbootloader/Makefile | 2 +-
 board/intel/slimbootloader/start.S  | 9 ---------
 2 files changed, 1 insertion(+), 10 deletions(-)
 delete mode 100644 board/intel/slimbootloader/start.S

Comments

Bin Meng Sept. 1, 2020, 5:34 a.m. UTC | #1
On Thu, Aug 20, 2020 at 6:02 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> start.S does nothing and can be safely removed. Makefile is still being used
> by the build system, so simply drop the rule from it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Aiden Park <aiden.park@intel.com>
> ---
> v2: added Rb tag(s)
>
>  board/intel/slimbootloader/Makefile | 2 +-
>  board/intel/slimbootloader/start.S  | 9 ---------
>  2 files changed, 1 insertion(+), 10 deletions(-)
>  delete mode 100644 board/intel/slimbootloader/start.S
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff mbox series

Patch

diff --git a/board/intel/slimbootloader/Makefile b/board/intel/slimbootloader/Makefile
index fd8fa98a8d39..50330cc6e5db 100644
--- a/board/intel/slimbootloader/Makefile
+++ b/board/intel/slimbootloader/Makefile
@@ -2,4 +2,4 @@ 
 #
 # Copyright (C) 2019 Intel Corporation <www.intel.com>
 
-obj-y	+= start.o slimbootloader.o
+obj-y	+= slimbootloader.o
diff --git a/board/intel/slimbootloader/start.S b/board/intel/slimbootloader/start.S
deleted file mode 100644
index 5c3f3df09eb0..000000000000
--- a/board/intel/slimbootloader/start.S
+++ /dev/null
@@ -1,9 +0,0 @@ 
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2019 Intel Corporation <www.intel.com>
- */
-
-/* board early initialization */
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret