diff mbox series

[v2,03/11] phy: mtk-tphy: make shared reg optional for v1

Message ID 20200819080225.4267-4-linux@fw-web.de
State Superseded
Delegated to: Marek Vasut
Headers show
Series Add MTK AHCI driver, BPI-R64 dts and USB-Nodes for mt7622/mt7623 | expand

Commit Message

Frank Wunderlich Aug. 19, 2020, 8:02 a.m. UTC 
From: Frank Wunderlich <frank-w@public-files.de>

make the shared reg optional when version is v1 for sata

Suggested-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 drivers/phy/phy-mtk-tphy.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Chunfeng Yun (云春峰) Aug. 19, 2020, 8:27 a.m. UTC | #1 
On Wed, 2020-08-19 at 10:02 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> make the shared reg optional when version is v1 for sata
> 
> Suggested-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  drivers/phy/phy-mtk-tphy.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/phy/phy-mtk-tphy.c b/drivers/phy/phy-mtk-tphy.c
> index 326227a30d..3d7b9cd2b1 100644
> --- a/drivers/phy/phy-mtk-tphy.c
> +++ b/drivers/phy/phy-mtk-tphy.c
> @@ -698,11 +698,10 @@ static int mtk_tphy_probe(struct udevice *dev)
>  	tphy->dev = dev;
>  	tphy->version = dev_get_driver_data(dev);
>  
> -	/* v1 has shared banks */
> +	/* v1 has shared banks for usb/pcie mode, */
> +	/* but not for sata mode */
>  	if (tphy->version == MTK_TPHY_V1) {
>  		tphy->sif_base = dev_read_addr_ptr(dev);
> -		if (!tphy->sif_base)
> -			return -ENOENT;
>  	}
Reviewed-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

Thanks

>  
>  	dev_for_each_subnode(subnode, dev) {
diff mbox series

Patch

diff --git a/drivers/phy/phy-mtk-tphy.c b/drivers/phy/phy-mtk-tphy.c
index 326227a30d..3d7b9cd2b1 100644
--- a/drivers/phy/phy-mtk-tphy.c
+++ b/drivers/phy/phy-mtk-tphy.c
@@ -698,11 +698,10 @@  static int mtk_tphy_probe(struct udevice *dev)
 	tphy->dev = dev;
 	tphy->version = dev_get_driver_data(dev);
 
-	/* v1 has shared banks */
+	/* v1 has shared banks for usb/pcie mode, */
+	/* but not for sata mode */
 	if (tphy->version == MTK_TPHY_V1) {
 		tphy->sif_base = dev_read_addr_ptr(dev);
-		if (!tphy->sif_base)
-			return -ENOENT;
 	}
 
 	dev_for_each_subnode(subnode, dev) {