From patchwork Tue Aug 18 10:16:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 1346730 X-Patchwork-Delegate: lukma@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=C/TzZ0/z; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BW5mM2qnTz9sRK for ; Tue, 18 Aug 2020 19:52:03 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9EAA982258; Tue, 18 Aug 2020 11:51:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="C/TzZ0/z"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B21358224A; Tue, 18 Aug 2020 11:51:33 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20608.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::608]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D0B8B82229 for ; Tue, 18 Aug 2020 11:51:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aeKvPGm6LldIOn2/y3qrV8MNQnd1yQXOjvUoyFBIRiKIe5CBiGyFHCDThTnwO+EfjYy6+SUhPxTwn3FCuOd9dewAt+jUMlSau6efwCXIaAKO42qHcGN2z4apoA02+qXGI5Cx8+EXmzBp+ZThh1+Vv993jzaoI5L1/VD5lLiyDQqRPAcODPpEi/BMMBtg7SrKXzSPHURpkuv4e68DHLQTfkVMBFQ8bC8AOZw6ea49Zq0/Ludo7Q38NSNz+j4o64q1Ll1oOLBcPSU2gfreaMagllUE5Z2R5ckOb0nqIxwAujzHG0f2nOQSdhLz29Fh7ijcpXxuWsS55L9CiQ+nzmjZzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RRtSwXi11jJtd56Q+V6PNSDWtsKi3VIcUNlNgPsrss8=; b=R2ur9AO5fuSADWKg1Kz1wboP/4SFWmGZcp6629ii6HhdH9UuWy+vDaUUHrbYxqcRw52cN6q2iNbBRSaP814EBQQs45o254IRHq3RQWVapnFw6RSMwu1QZHIbajt4ienXTJuO7in78BpDb5n2e5tX/Xve1y4gnrmxA5jWgTMCLzE3UKHGR76EP8wPbtAW9ZPwh0+LdIqsBVgDM/oINKwwS1CB5rvkJeNj1Flld1LYjrAnTptfWttJStWQTNV4TI1NSEubwO8+exqI5j75k0MwiKWeG4Iht8qf3ndHlzn2niTpqwYvDTF85yV1aimCxX7QzeLKqc7HALOscu82ilPjxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RRtSwXi11jJtd56Q+V6PNSDWtsKi3VIcUNlNgPsrss8=; b=C/TzZ0/zXirKjzdQuowm1x/6Tv+W1J4cbQLu8peYlFg9J+Jnzr5jwQ7frwG9axQQSpsNYnsMzCnrGztCtJFkAbSzIUI1Vz/tCUweiscWNxvuysLZ3uPPIsiXc7GbdaKF9i06Yox/za3GNfU/rJ2K+SmjbNtWZG8N2uRcAw/oBi8= Authentication-Results: denx.de; dkim=none (message not signed) header.d=none;denx.de; dmarc=none action=none header.from=nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DBAPR04MB7223.eurprd04.prod.outlook.com (2603:10a6:10:1b0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24; Tue, 18 Aug 2020 09:51:27 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::24d0:f783:3c7d:e232]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::24d0:f783:3c7d:e232%12]) with mapi id 15.20.3283.027; Tue, 18 Aug 2020 09:51:27 +0000 From: Peng Fan To: sbabic@denx.de, marex@denx.de, lukma@denx.de Cc: uboot-imx@nxp.com, u-boot@lists.denx.de, Ye Li , Peng Fan Subject: [PATCH v2 3/7] f_sdp: Fix wrong usb request size Date: Tue, 18 Aug 2020 18:16:45 +0800 Message-Id: <20200818101649.16509-4-peng.fan@nxp.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20200818101649.16509-1-peng.fan@nxp.com> References: <20200818101649.16509-1-peng.fan@nxp.com> X-ClientProxiedBy: SG2PR03CA0130.apcprd03.prod.outlook.com (2603:1096:4:91::34) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SG2PR03CA0130.apcprd03.prod.outlook.com (2603:1096:4:91::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.13 via Frontend Transport; Tue, 18 Aug 2020 09:51:24 +0000 X-Mailer: git-send-email 2.16.4 X-Originating-IP: [119.31.174.71] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4f57890d-1716-40a3-1396-08d8435c4668 X-MS-TrafficTypeDiagnostic: DBAPR04MB7223: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2399; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7mXKHIY2xy0rQCkXUu1YAejOUP/zdmANt44trx4Ridk8z4PYkVpEPvz8iLIlNfQCJ8c6Hm0/LEv3T/pIbH8nZRzGhT3QPMJ+uGv40uV8DB3/bg7A+1V36HQ7z9Gnb8Qkqt7lBOma0mBoc6QOuFZPU6JpRljDAaqPpSy4DAWPPHL6vxp3WGMvvhypwHWp1oqa1vhzr7VhpTCDsF3Wg2D1Bk0U5UpgQphPdhafPHleCKId9DqAe+iHCjc1LaOeT7cm9xeldXLCNnUO34+8uvfGDYUfNVPmT51Lxu4LUnVv6GYHnKn0O3MvPUqJSsOD9UY+zGbCO2PnYtjw3Sc95nSGjQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(66946007)(6666004)(83380400001)(478600001)(2906002)(6486002)(8936002)(86362001)(6512007)(956004)(2616005)(44832011)(8676002)(186003)(16526019)(66476007)(66556008)(4326008)(4744005)(36756003)(6506007)(5660300002)(1076003)(54906003)(316002)(52116002)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: zFVeoZqGo9rF45PZ6e4xNkUNgoGlelOjzCNz6dY5wrNi5KwvcJNA3i48NZh2nF11HKLadVgg08U1uC/7OQmB4GUlp3oagcUHD3Co1LMguiSZlsFWA25lcKLW76k1/mWCvKMYuDff2uJCB23ZQF3fH+CKSNNwf/mGva5AfvGpJW3ZxeBG1COv/a5mxTSaHlif/lVcW2VKyRHkLI4cnmN4/Z9ocp5R52dBQoVhYduoTjLAARHqDcgu4S2pTPqoi6B9DNcXh7Kb3n+5SjZcPP4CIHSktkm0vL/P4GwcA7DiHWFN/83gUUeqXeIg7YceXDiGpHxG+AfpgqE2S1X/4NAi5BZtkTdyg008B4nEv9lAvQklyUOCnbIS4Si+okzfSeOesUKqpvEPV0eZkGtoe4pwWYf87P4lsePaoqdQvb+B0ZgHooEyvyK1PKYKcx1atFP0vIBnmp9+/RkFsjN15WVWBlafUXr4oMQ+A34z3NnUwJM5rU7IohoJRurDiyFpm3od4Qwo7/GXueEMCM5fz3yDu0N/s7QH+Cs1QWLVE7Yx7MqpRY6ggslOZSMvjOCoL2Y4Tm17b4F1RZgdHuTChoBcqoR7nuekkRWYjoulW0zXPUmT+hfP2zE/AnuLHlqWJjkmAizYWNmopMjoUp8oqmHJrg== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f57890d-1716-40a3-1396-08d8435c4668 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2020 09:51:27.4201 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eWqh/1wT7hWu2RDBrRCcFTve2hZsjV4YFp6kJ4o4hauJ6vNUVgNA0Ykxp1DxCSvv16LwtDkocwMKFYdnSIQ1cA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7223 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean From: Ye Li Because the buffer length of sdp usb request is 65, we have to allocate 65 bytes not 64 bytes. Otherwise there is potential buffer overflow. Signed-off-by: Ye Li Signed-off-by: Peng Fan Reviewed-by: Lukasz Majewski --- drivers/usb/gadget/f_sdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c index f971ccdeca..eec7560fc2 100644 --- a/drivers/usb/gadget/f_sdp.c +++ b/drivers/usb/gadget/f_sdp.c @@ -548,7 +548,7 @@ static struct usb_request *sdp_start_ep(struct usb_ep *ep) { struct usb_request *req; - req = alloc_ep_req(ep, 64); + req = alloc_ep_req(ep, 65); debug("%s: ep:%p req:%p\n", __func__, ep, req); if (!req)