From patchwork Tue Aug 11 16:23:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1343380 X-Patchwork-Delegate: xypron.glpk@gmx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=RHCxhiUC; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BQyp64pfdz9sTN for ; Wed, 12 Aug 2020 02:24:14 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E7105812E7; Tue, 11 Aug 2020 18:24:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="RHCxhiUC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5C83A819E8; Tue, 11 Aug 2020 18:24:11 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EBA9981269 for ; Tue, 11 Aug 2020 18:24:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1597163047; bh=Zn+yA3YXkopQYx3HGFY1+rrWOmVbw4ekr13yAURqxxw=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=RHCxhiUCib81VGCdFkg1U3Cq0fbb8Til9XijNDlvjf+cGlqaKC1NW+GKKSop8nFGL wh8Lrcvv5In5a1OqrkUyc+reABAhrM7FLbiTMVGkktElSaUFAOBeI67jvv5CEV5b1g o0CW4W8qwJtXVvdz66yLIY39lj/S2bb2vIUmaISk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([178.202.41.107]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MWih0-1kC7ix0aG8-00X81d; Tue, 11 Aug 2020 18:24:07 +0200 From: Heinrich Schuchardt To: Alexander Graf Cc: u-boot@lists.denx.de, AKASHI Takahiro , Heinrich Schuchardt Subject: [PATCH 1/1] cmd/efidebug: missing initialization of load_options Date: Tue, 11 Aug 2020 18:23:55 +0200 Message-Id: <20200811162355.48997-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:xKie9hT1oDJ6lAsaiAqpBa7yCpfv6Z/2l/a40cOsNPKQL77HsiE CQ3JXIyF+PviCwFqqvmmghuPBKbKN4RFBzBuDStwCgzxz71B9wlMJEQ/F5ikyjqGdRQF5d1 cjjjnuZ5N55rvVqYRpJRR/QbEL+FAzkEUjmyneb0ARn8x4zmVCx++bpf2YUKBsNWj0I1vA+ FvX/FkXZN4hPj0v5brW0g== X-UI-Out-Filterresults: notjunk:1;V03:K0:oKzi7dLsggs=:x4li8mwgeg/C5XLfexEwPT 7bxLqEgqLh4VWZBI0+8gpYBeFCE69Zv1nT1mw9RdaEY8ekWewDOZNxYN6bOvUd6u93042Mnnq YdY87Vg78ZsiWyUUlDGuBxi2qTBzn5aIUtrXmYcf5o+tk/DspejQ2maafWTalQgG44dys4SFF DedlldVFp4CXAZRMuvAJjAupGv8bwOlAAOUImINFydY7s0Pr0bBvXSSnBqyhGu9HpPy+tC51Y SM9xYcG4tyd6bCEqPUA5KvFXqtilrnbAETy0N1HSHBRxFdJHPKTjPSFGV8Ju20twMTD40fs3r feaELUbLeTzBObTCojCqBpIKxEpe5foNSPVBLvttwxcfxUbXxJ8UQB/movK2V3/fhF+7dDzhQ o9byNkhbONspB0BhSMhuYL7PLoH5BCBaqPL5CDFUTnCqPuiz1wQF0uv4IR3LeKAAVtnuA3TKc Ac+Qk1dhiO+bvHiYHGpHgtNSXMIGfRW0c83l8R+/XfArvElciNf9mDFT+uLhgqrIbtJFYV/Fq kCHxOTDkRTO0s5IUEOpNts8VUGN56wdcgwxGRio/fNR7I8XGFnnJmfE13nouDpzaZoTurG7QA yJTWocNpgnf2vc1lrBwTorm9eaW9K8QFEzlZ6QrNq60zhuCyl781w9AFdX1UZZAX71487R90D lEIqIxUvQ0ZWKZKovoyRDed8To57FfO9wEAmkWcOCh4JEAhVg4uMt1rJLSr1jZJsNg3gXp9mj jmiNd0gfFb9+mA4RvyWHTYpo5Xd3aG2TzbwaS1jdlwu4oDva/D1ypdWgAmyPKmUkN2OCSTurY SeDvtnlKIp+OwB7kSNBmVx9nCMuc20kndSeQe4oKP09hLMismX/xs4t8mW/rLrX5NjPIFEyQq /7mKAc/GIjnQLqhDabNyxiKMwM0LxKzbfPY4BUwVc8Z9qtmZt0lmb6cv/nV26DPvaY6Q74bol ruFAJZh6SbBK7ZECf7MRKsSMwNYAhUAcZVa1h5UQqZa4pYDiwD1mtyYO8QrJyHWZh15aWkEfh domoXoYPY1+pRZ444d775HdbqGt1WzNAL+XWnyOXn60JS5bhDO06A/LSglCPA87SWK/1+tgDy yQ8JzLqvxxiETG700IhbVGggOv7RbAhnsAOHRPqY58wxmf+epPx9HL89vaGGfMvjMksGa5fks oS8AbVZyyp009X3WGR7HG5sosVVfGd2KXOa+RE/YpnSzzGEktr3eY4nSn7PsH2DOXuqhLjZOW w7LSAO6HRzrdoS/XJ3sGABltlwrxf3CkV65ajCw== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Variable load_options must be initialized to NULL to avoid a segmentation fault when freeing the memory this variable points to. Signed-off-by: Heinrich Schuchardt --- cmd/efidebug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.28.0 diff --git a/cmd/efidebug.c b/cmd/efidebug.c index d00d4247dc..9874838b00 100644 --- a/cmd/efidebug.c +++ b/cmd/efidebug.c @@ -1126,7 +1126,7 @@ static int do_efi_test_bootmgr(struct cmd_tbl *cmdtp, int flag, efi_uintn_t exit_data_size = 0; u16 *exit_data = NULL; efi_status_t ret; - void *load_options; + void *load_options = NULL; ret = efi_bootmgr_load(&image, &load_options); printf("efi_bootmgr_load() returned: %ld\n", ret & ~EFI_ERROR_MASK);