From patchwork Mon Aug 3 21:09:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1340561 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=fgORMimN; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BL9X16J0Fz9sSt for ; Tue, 4 Aug 2020 07:10:25 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 60FD8821E2; Mon, 3 Aug 2020 23:10:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="fgORMimN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 496A4821E7; Mon, 3 Aug 2020 23:10:15 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8673C821D8 for ; Mon, 3 Aug 2020 23:10:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1596488997; bh=3x70+jsfOKm+33or8eswr3OSFhX0fzqzRMbF/pLbfRM=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=fgORMimNtQVh0fmo8RpK/ctrTlJfUM4rMxJ6J1RRHl6MGN7HkghucbHMuCVU/tZf6 0rixnLQ9GLbtLP7ROFgwzecANgt/EF+uqXSYRJMqEfG8T7RSOJnXoCXCbjTyQLTQai KuvJc5xJbmWxWIE7VNC35qOtqm+tPFiA1JYvwunI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([178.202.41.107]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MRmjq-1k9kCt10Uk-00TD8I; Mon, 03 Aug 2020 23:09:57 +0200 From: Heinrich Schuchardt To: Rick Chen Cc: Pragnesh Patel , Bin Meng , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] riscv: sifive: fu540: redundant initialization Date: Mon, 3 Aug 2020 23:09:49 +0200 Message-Id: <20200803210949.16070-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:qQblhSSK33sBf93WZhyYQYbjak1Yw40WK5Ny4W0gsO+7Ildle63 FveHSPjuuZpLGglwE2KdoG4sZ0qG48+HD6gzF7f4ua9QiVKbytmuijqdZ/7dxFJr4ofWEyu JsEoFzSq+27ui+kMKCSf32poj3TzoDaZVRijeyheIAdlHKE2KXtjdMF83JoHlKCycdAu3Vv EGEW/5z+ySKv0EmP0x3GQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:DIG/IRH1hks=:ZctloWVP/HUhSh/Yzezvhx vcsKvn91aObTGfM/fcGSXYsa++Sp1HqWf5O4SOPnZ20B1v6raD6LN1adGGXe7YBbDCg2Zf8dd bcWMB6kK+uVWbCko9/1dm1PSy9UsAeKcNim/4I/dg9ETXnYBut8awPmDLzYNZIQzbIVdzhlQo HRACsZlMdrYduxmKqfehrALESCyuZGXS5bAcyaaKzJsKRhX/97uw1bu4BOFC1u3/pcR01Eju/ S7iq7P0j7s9EiWPz3HP020L5pZh8FyQnO8L/U7RtlZl9TEmyXjdz0nDY7t6JnADMcYHadqnew iqI7g2QO1o5JoY6DLjevV9RjS/pqHrZMNYn62VFPtZLZwhBG4Nh7VyQ0faotv9rs88MK4T3Ot fEUeS5O/iFFslL7+MjQp0DYLZ83sRwmkSn2B+2k0mDuX/Qgal4sACEe6JS1cGvZl34Cdl1kz1 PzwStqbIgGeGuZwcLMutfw056Do8woF7I0MiGpixbe0KwTOA01SJSyhLfGEyGlGS0NB44gsoM in0rAYmKvzb6lRYwn15ymYdS8FGwpSvBDbSlH+AsRboCnO3tRixwTnfpLi1wbnpIHzPszs2R3 QwXawfHYuF0DE090HLx5cflwLLR2KKDVjWGhxJJwNvJb66HGo9Aue9hm87h892XUTGTy6v0qi 3kUZTtxuMs1S4ToV+mkDQkhOOMsQXfg5yolVpRgXIRETnhyLu4jwxCnrgssm90Xf9nUv5GKP0 y6O7e3LyfClxCi1dgyTpkZUS+7DivdL17+sGt4A75//SzOV7YqHkZfSDIHiE7/Xmx0WNUOdlC 7krLm/hdGWuzP0Y868WRRCMvIHJ6uA1MzjgE2T24BUOGoTDVQumBQE86vhTxDPlcYH19/YteY FsOdbXAR3Sx1tXp1SNZVCbl28HPJ9NaYouVCA+vYhsyw1SPSXfKcSAUk67y32fpAoQOB0EZra s2rtXXc3Q7hGdVT8R03BSzFr65yR1HvNGkW2pii7sdNONQnrDVXziTKp+iXgF7Xn0ceceGATW I8PpDoyyhdJBPVjjQbhhSP1gFe6a1WBNuYOIL+fsnS+1Uod4uBbIBZwtlw0pOOI8C4Y8KclUz +gVACgL+ozbD91oVFIuf1BvnJwDwVS85DLJDSySNpEej9jfemQbs1HrNI2FOTgujQRmOsPTw9 a/gkeGtIJ0Z3h/gBbuO21vF1Bgfahgbp2dn6xvYHgDeH4LKMMG1gLkP+jHSBZkX9idMhNQtSl OS03aofOG7Q0CTRDdhSBysnd5AVW1DuoLcUJJQA== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean We should not initialize a variable if the value is overwritten before being read. Signed-off-by: Heinrich Schuchardt Reviewed-by: Bin Meng Reviewed-by: Pragnesh Patel Tested-by: Pragnesh Patel Reviewed-by: Rick Chen --- arch/riscv/cpu/fu540/cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.27.0 diff --git a/arch/riscv/cpu/fu540/cache.c b/arch/riscv/cpu/fu540/cache.c index 9ee364b509..54de14238c 100644 --- a/arch/riscv/cpu/fu540/cache.c +++ b/arch/riscv/cpu/fu540/cache.c @@ -22,7 +22,7 @@ DECLARE_GLOBAL_DATA_PTR; int cache_enable_ways(void) { const void *blob = gd->fdt_blob; - int node = (-FDT_ERR_NOTFOUND); + int node; fdt_addr_t base; u32 config; u32 ways;