diff mbox series

[2/2] test: dm: Add test case for devfdt_get_addr_ptr

Message ID 20200803191736.36228-2-ovidiu.panait@windriver.com
State Accepted
Delegated to: Simon Glass
Headers show
Series [1/2] dm: core: Fix devfdt_get_addr_ptr return value | expand

Commit Message

Ovidiu Panait Aug. 3, 2020, 7:17 p.m. UTC 
Add flat tree test case to cover devfdt_get_addr_ptr function.

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---

 test/dm/test-fdt.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Simon Glass Aug. 4, 2020, 2 a.m. UTC | #1 
On Mon, 3 Aug 2020 at 13:21, Ovidiu Panait <ovidiu.panait@windriver.com> wrote:
>
> Add flat tree test case to cover devfdt_get_addr_ptr function.
>
> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
> ---
>
>  test/dm/test-fdt.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Simon Glass Aug. 22, 2020, 11:18 p.m. UTC | #2 
On Mon, 3 Aug 2020 at 13:21, Ovidiu Panait <ovidiu.panait@windriver.com> wrote:
>
> Add flat tree test case to cover devfdt_get_addr_ptr function.
>
> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
> ---
>
>  test/dm/test-fdt.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!
diff mbox series

Patch

diff --git a/test/dm/test-fdt.c b/test/dm/test-fdt.c
index 8ef7c7a88e..fc089684ac 100644
--- a/test/dm/test-fdt.c
+++ b/test/dm/test-fdt.c
@@ -618,6 +618,24 @@  static int dm_test_fdt_translation(struct unit_test_state *uts)
 }
 DM_TEST(dm_test_fdt_translation, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
 
+static int dm_test_fdt_get_addr_ptr_flat(struct unit_test_state *uts)
+{
+	struct udevice *gpio, *dev;
+	void *ptr;
+
+	/* Test for missing reg property */
+	ut_assertok(uclass_first_device_err(UCLASS_GPIO, &gpio));
+	ut_assertnull(devfdt_get_addr_ptr(gpio));
+
+	ut_assertok(uclass_find_device_by_seq(UCLASS_TEST_DUMMY, 0, true, &dev));
+	ptr = devfdt_get_addr_ptr(dev);
+	ut_asserteq_ptr((void *)0x8000, ptr);
+
+	return 0;
+}
+DM_TEST(dm_test_fdt_get_addr_ptr_flat,
+	DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT | DM_TESTF_FLAT_TREE);
+
 static int dm_test_fdt_remap_addr_flat(struct unit_test_state *uts)
 {
 	struct udevice *dev;