Message ID | 20200726214408.v1.36.Iebe5efc358267d65f014f9fe65f2907afe5e7052@changeid |
---|---|
State | Superseded |
Delegated to: | Bin Meng |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=NTVJoiQh; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BFQrS5nTFz9sPB for <incoming@patchwork.ozlabs.org>; Mon, 27 Jul 2020 13:53:12 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3091382369; Mon, 27 Jul 2020 05:49:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="NTVJoiQh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D8E33822C0; Mon, 27 Jul 2020 05:46:40 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C81DE8230F for <u-boot@lists.denx.de>; Mon, 27 Jul 2020 05:46:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-ot1-x342.google.com with SMTP id w17so11322852otl.4 for <u-boot@lists.denx.de>; Sun, 26 Jul 2020 20:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BkgPQmAqU3X/CSEFkf9Yqq2lyplxxJR6FYR4KnEcp3Q=; b=NTVJoiQhD+RfOA1SBNuEuOPYKIthPBnRfJTgyiCF7eoa+KBC7GgV6bDrieic9UShtO fD/yx6jM1XFrK1FlHucNHxXBim4yw4yQxZynopuXFI5DjxF/1vid+2V+piriHQQ2y7H0 1+2lUvYecRMY0uKy8BYMkgZ83MN5k97SBXNr8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BkgPQmAqU3X/CSEFkf9Yqq2lyplxxJR6FYR4KnEcp3Q=; b=d6KoXg0pCepW6thmbXQm+7ikE6mH4tLSyJDwQDOLG2XEkEO/XgPBmpOVQ+8dNs1XdR mE1fncZ8bK5RFSXVwRjpNGL79Qdos+Jc34zOWTlIvp5VPbAp4aVwL0mDcfqnwalGIGrF ImwJvvXfzu8AWRp+YSUwlTrX9wGsXjyRJp0PvNbUO1ytPTcj63vEdC0lXkARabu2Qua5 W1haMhqjU8/okjC9SRhtl4pjboDVHBssbdwvkKor9kr3qsusBhg8cgvONLvr3/9x1Gj3 rheiuBuoqDZJwyzlNq73T9qw1pWJk+cUqpqswf2jm8KY8w5/1+2UcNp3bIEdNG6DTrVF NK3A== X-Gm-Message-State: AOAM530OKr32bOLf35VhA7JXhHGhzBSL2gGFlF6WMf60/gHhzfJAySag wwiz+eWwyz5W7lfEQ/sUhF1dvzWzo1aOEw== X-Google-Smtp-Source: ABdhPJyHiVMqwSMv+Zq24uzXZzKh53zd0vBHbRgrh0YaCCdiquUrt9h1er2lf6j6gWiJezCspwwmbw== X-Received: by 2002:a05:6830:198:: with SMTP id q24mr18619826ota.202.1595821572551; Sun, 26 Jul 2020 20:46:12 -0700 (PDT) Received: from localhost.localdomain (c-73-14-175-90.hsd1.co.comcast.net. [73.14.175.90]) by smtp.gmail.com with ESMTPSA id p64sm1808996oih.39.2020.07.26.20.46.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2020 20:46:12 -0700 (PDT) From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Cc: Wolfgang Wallner <wolfgang.wallner@br-automation.com>, Bin Meng <bmeng.cn@gmail.com>, Simon Glass <sjg@chromium.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH v1 36/54] x86: apl: Drop unnecessary code in PMC driver Date: Sun, 26 Jul 2020 21:45:08 -0600 Message-Id: <20200726214408.v1.36.Iebe5efc358267d65f014f9fe65f2907afe5e7052@changeid> X-Mailer: git-send-email 2.28.0.rc0.142.g3c755180ce-goog In-Reply-To: <20200727034526.1461514-1-sjg@chromium.org> References: <20200727034526.1461514-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <https://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean |
Series |
dm: Add programatic generation of ACPI tables (part D)
|
expand
|
diff --git a/arch/x86/cpu/apollolake/pmc.c b/arch/x86/cpu/apollolake/pmc.c index 192dec7109a..576d0187570 100644 --- a/arch/x86/cpu/apollolake/pmc.c +++ b/arch/x86/cpu/apollolake/pmc.c @@ -118,7 +118,8 @@ int apl_pmc_ofdata_to_uc_platdata(struct udevice *dev) int size; int ret; - ret = dev_read_u32_array(dev, "early-regs", base, ARRAY_SIZE(base)); + ret = dev_read_u32_array(dev, "early-regs", base, + ARRAY_SIZE(base)); if (ret) return log_msg_ret("Missing/short early-regs", ret); if (spl_phase() == PHASE_TPL) { @@ -133,11 +134,6 @@ int apl_pmc_ofdata_to_uc_platdata(struct udevice *dev) } upriv->acpi_base = base[4]; - /* Since PCI is not enabled, we must get the BDF manually */ - plat->bdf = pci_get_devfn(dev); - if (plat->bdf < 0) - return log_msg_ret("Cannot get PMC PCI address", plat->bdf); - /* Get the dwX values for pmc gpe settings */ size = dev_read_size(dev, "gpe0-dw"); if (size < 0)
We don't have CONFIG_PCI in TPL but it is present in SPL, etc. So this code is not needed. Drop it, and fix a code-style nit just above. Signed-off-by: Simon Glass <sjg@chromium.org> --- arch/x86/cpu/apollolake/pmc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)