diff mbox series

[v3,7/7] arm: meson: change trace level for phy errors managed by uclass

Message ID 20200703153646.28533-8-patrick.delaunay@st.com
State Needs Review / ACK
Delegated to: Tom Rini
Headers show
Series phy: generic: add error trace to detect PHY issue in uclass | expand

Commit Message

Patrick Delaunay July 3, 2020, 3:36 p.m. UTC
As the error message is now displayed by generic phy functions,
the pr_err can be change to pr_debug.

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---

Changes in v3:
- add update for mach-meson board-gx: new generic_phy API usage

 arch/arm/mach-meson/board-gx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Neil Armstrong July 7, 2020, 3:46 p.m. UTC | #1
Hi,

Le 03/07/2020 à 17:36, Patrick Delaunay a écrit :
> As the error message is now displayed by generic phy functions,
> the pr_err can be change to pr_debug.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> 
> Changes in v3:
> - add update for mach-meson board-gx: new generic_phy API usage
> 
>  arch/arm/mach-meson/board-gx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-meson/board-gx.c b/arch/arm/mach-meson/board-gx.c
> index c4cc11f1de..b4fde46fcb 100644
> --- a/arch/arm/mach-meson/board-gx.c
> +++ b/arch/arm/mach-meson/board-gx.c
> @@ -196,8 +196,8 @@ int board_usb_init(int index, enum usb_init_type init)
>  	for (i = 0; i < 2; i++) {
>  		ret = generic_phy_init(&usb_phys[i]);
>  		if (ret) {
> -			pr_err("Can't init USB PHY%d for %s\n",
> -			       i, ofnode_get_name(dwc2_node));
> +			pr_debug("Can't init USB PHY%d for %s\n",
> +				 i, ofnode_get_name(dwc2_node));
>  			return ret;
>  		}
>  	}
> @@ -205,8 +205,8 @@ int board_usb_init(int index, enum usb_init_type init)
>  	for (i = 0; i < 2; i++) {
>  		ret = generic_phy_power_on(&usb_phys[i]);
>  		if (ret) {
> -			pr_err("Can't power USB PHY%d for %s\n",
> -			       i, ofnode_get_name(dwc2_node));
> +			pr_debug("Can't power USB PHY%d for %s\n",
> +				 i, ofnode_get_name(dwc2_node));
>  			return ret;
>  		}
>  	}
> 

Acked-by: Neil Armstrong <narmstrong@baylibre.com>
diff mbox series

Patch

diff --git a/arch/arm/mach-meson/board-gx.c b/arch/arm/mach-meson/board-gx.c
index c4cc11f1de..b4fde46fcb 100644
--- a/arch/arm/mach-meson/board-gx.c
+++ b/arch/arm/mach-meson/board-gx.c
@@ -196,8 +196,8 @@  int board_usb_init(int index, enum usb_init_type init)
 	for (i = 0; i < 2; i++) {
 		ret = generic_phy_init(&usb_phys[i]);
 		if (ret) {
-			pr_err("Can't init USB PHY%d for %s\n",
-			       i, ofnode_get_name(dwc2_node));
+			pr_debug("Can't init USB PHY%d for %s\n",
+				 i, ofnode_get_name(dwc2_node));
 			return ret;
 		}
 	}
@@ -205,8 +205,8 @@  int board_usb_init(int index, enum usb_init_type init)
 	for (i = 0; i < 2; i++) {
 		ret = generic_phy_power_on(&usb_phys[i]);
 		if (ret) {
-			pr_err("Can't power USB PHY%d for %s\n",
-			       i, ofnode_get_name(dwc2_node));
+			pr_debug("Can't power USB PHY%d for %s\n",
+				 i, ofnode_get_name(dwc2_node));
 			return ret;
 		}
 	}