From patchwork Fri Jul 3 03:12:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1322052 X-Patchwork-Delegate: bmeng.cn@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=htAmRX7K; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49yg8X1cQ1z9sR4 for ; Fri, 3 Jul 2020 13:15:56 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8ABC981BFB; Fri, 3 Jul 2020 05:13:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="htAmRX7K"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 042AF81BDE; Fri, 3 Jul 2020 05:13:12 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AA7BD81BB6 for ; Fri, 3 Jul 2020 05:12:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-io1-xd41.google.com with SMTP id i4so31047491iov.11 for ; Thu, 02 Jul 2020 20:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iQxXN6RtpaShlT2xSeOEV8tLcSgqYVeRZ/YBqQ4K/jk=; b=htAmRX7KwoRZIeRkG7kOg8T2h+YGBSCoTVzDmzHbrxxHvOmpXXhcQByODTssf3ZFHE 7E+17070uS5UcgwMKPP4k/czJEhzfaQC9uHWVho+gMQmnHFO1pDCPEJSFDxsYqn3zZmP 9RI3bygIhCXYum3dk7Yw3E/Oj90E8caIQxSps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iQxXN6RtpaShlT2xSeOEV8tLcSgqYVeRZ/YBqQ4K/jk=; b=O5U4LAe84b6EKNVaiDtwMZZ/LlztTFNv3jXfJa1IBJJW/F/oIWODiqCLdJ6CY5uHgy AIaGOBCBB9UIEd1YFxwLoeXRuRzNrKETqJc7YFUo1udKSXPdMohC1ap3M2DJYREouNh5 02Md2ffmcNUAJlabhr7pv0a44G/2adv2BpK0x3WOV3DOrH3AbE2qfFLGi1UbrsKydFhp L+TTLz9U2yuDZvLRhFRaIkD7Z6g9kKpiBpGSg/cOsB+/on8RgiunTyWxCCJy9TqAwtpH SwemghrOl6lHAzHUpy6b4Q7X1DoswcgruNRimFrgSrjIWi71O/cXootcBrTwdahMweVF XDFw== X-Gm-Message-State: AOAM532D8f+XbAFDGES+NKFrOau2ob9MhRpC5Q45M7TpfU5AkZLgCYqC EqtcDmJg73fzPlbYv7Uw1fSLQg== X-Google-Smtp-Source: ABdhPJwEbDKfBOT3qeiwQeW42qB/epU+J7IxwoBNu71O3ruPiaiARLprx4RR9i7ZWHcl87Rmp1KmUw== X-Received: by 2002:a05:6602:234d:: with SMTP id r13mr10167288iot.83.1593745977471; Thu, 02 Jul 2020 20:12:57 -0700 (PDT) Received: from localhost.localdomain (c-73-14-175-90.hsd1.co.comcast.net. [73.14.175.90]) by smtp.gmail.com with ESMTPSA id c16sm5859654ilh.54.2020.07.02.20.12.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 20:12:57 -0700 (PDT) From: Simon Glass To: Bin Meng Cc: Simon Glass , Anatolij Gustschin , u-boot@lists.denx.de Subject: [RESEND PATCH v3 17/26] video: Add comments to struct sandbox_sdl_plat Date: Thu, 2 Jul 2020 21:12:28 -0600 Message-Id: <20200702211204.RESEND.v3.17.I5a77b98330d65a94fd165b06d60fb51d83109d2d@changeid> X-Mailer: git-send-email 2.27.0.212.ge8ba1cc988-goog In-Reply-To: <20200703031237.1546362-1-sjg@chromium.org> References: <20200703031237.1546362-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean This struct is not commented but needs it. Also fix the comment in check_vidconsole_output() about the encoding for the rotation value. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin --- (no changes since v1) include/dm/test.h | 14 +++++++++++++- test/dm/video.c | 3 ++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/include/dm/test.h b/include/dm/test.h index f0f36624ce..d39686cde2 100644 --- a/include/dm/test.h +++ b/include/dm/test.h @@ -159,7 +159,19 @@ enum { /* Declare a new driver model test */ #define DM_TEST(_name, _flags) UNIT_TEST(_name, _flags, dm_test) -/* This platform data is needed in tests, so declare it here */ +/* + * struct sandbox_sdl_plat - Platform data for the SDL video driver + * + * This platform data is needed in tests, so declare it here + * + * @xres: Width of display in pixels + * @yres: Height of display in pixels + * @bpix: Log2 of bits per pixel (enum video_log2_bpp) + * @rot: Console rotation (0=normal orientation, 1=90 degrees clockwise, + * 2=upside down, 3=90 degree counterclockwise) + * @vidconsole_drv_name: Name of video console driver (set by tests) + * @font_size: Console font size to select (set by tests) + */ struct sandbox_sdl_plat { int xres; int yres; diff --git a/test/dm/video.c b/test/dm/video.c index 68f5ba44e7..729c31b47d 100644 --- a/test/dm/video.c +++ b/test/dm/video.c @@ -188,7 +188,8 @@ DM_TEST(dm_test_video_ansi, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT); * check_vidconsole_output() - Run a text console test * * @uts: Test state - * @rot: Console rotation (0, 90, 180, 270) + * @rot: Console rotation (0=normal orientation, 1=90 degrees clockwise, + * 2=upside down, 3=90 degree counterclockwise) * @wrap_size: Expected size of compressed frame buffer for the wrap test * @scroll_size: Same for the scroll test * @return 0 on success