diff mbox series

Add information for skipped commit options

Message ID 20200702175254.22954-1-patrick.delaunay@st.com
State Accepted
Delegated to: Simon Glass
Headers show
Series Add information for skipped commit options | expand

Commit Message

Patrick Delaunay July 2, 2020, 5:52 p.m. UTC
The unsupported Commit-xxx option are silently skipped
and removed as 're_remove=Commit-\w*', this patch adds
warning message in this case to detect misspelled issue
for the 2 supported options:
  Commit-notes:
  Commit-changes:

For example: the final 's' is missing (Commit-note:)

NB: no issue for Series-xxx option as only the supported
    options are accepted (see valid_series in series.py)

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---

 tools/patman/patchstream.py | 3 +++
 1 file changed, 3 insertions(+)

Comments

Simon Glass July 3, 2020, 3:50 a.m. UTC | #1
On Thu, 2 Jul 2020 at 11:53, Patrick Delaunay <patrick.delaunay@st.com> wrote:
>
> The unsupported Commit-xxx option are silently skipped
> and removed as 're_remove=Commit-\w*', this patch adds
> warning message in this case to detect misspelled issue
> for the 2 supported options:
>   Commit-notes:
>   Commit-changes:
>
> For example: the final 's' is missing (Commit-note:)
>
> NB: no issue for Series-xxx option as only the supported
>     options are accepted (see valid_series in series.py)
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
>
>  tools/patman/patchstream.py | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py
index a575c09b47..7efab8c2dd 100644
--- a/tools/patman/patchstream.py
+++ b/tools/patman/patchstream.py
@@ -342,6 +342,9 @@  class PatchStream:
             elif name == 'changes':
                 self.in_change = 'Commit'
                 self.change_version = self.ParseVersion(value, line)
+            else:
+                self.warn.append('Line %d: Ignoring Commit-%s' %
+                    (self.linenum, name))
 
         # Detect the start of a new commit
         elif commit_match: