diff mbox series

[v2,2/2] stm32mp1: use the command env info in env_check

Message ID 20200702154345.8436-2-patrick.delaunay@st.com
State Accepted
Delegated to: Patrick Delaunay
Headers show
Series [v2,1/2] cmd: env: use ENV_IS_IN_DEVICE in env info | expand

Commit Message

Patrick Delaunay July 2, 2020, 3:43 p.m. UTC
Activate CMD_NVEDIT_INFO and use the new command "env info -d -p -q"
to automatically save the environment on first boot.

This patch allows to remove the env_default variable.


Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---

Previously sent in serie
cmd: env: add option for quiet output on env info
http://patchwork.ozlabs.org/project/uboot/list/?series=158105

Resend as separate serie without the "-q" option.


Changes in v2:
- correct commit message (commit-notes) and add review by Patrice

 arch/arm/mach-stm32mp/Kconfig | 1 +
 include/configs/stm32mp1.h    | 4 +---
 2 files changed, 2 insertions(+), 3 deletions(-)

Comments

Patrice CHOTARD July 2, 2020, 4:11 p.m. UTC | #1
Hi Patrick

On 7/2/20 5:43 PM, Patrick Delaunay wrote:
> Activate CMD_NVEDIT_INFO and use the new command "env info -d -p -q"
> to automatically save the environment on first boot.
>
> This patch allows to remove the env_default variable.
>
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
>
> Previously sent in serie
> cmd: env: add option for quiet output on env info
> http://patchwork.ozlabs.org/project/uboot/list/?series=158105
>
> Resend as separate serie without the "-q" option.
>
>
> Changes in v2:
> - correct commit message (commit-notes) and add review by Patrice
>
>  arch/arm/mach-stm32mp/Kconfig | 1 +
>  include/configs/stm32mp1.h    | 4 +---
>  2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-stm32mp/Kconfig b/arch/arm/mach-stm32mp/Kconfig
> index 6c995ed8d8..478fd2f17d 100644
> --- a/arch/arm/mach-stm32mp/Kconfig
> +++ b/arch/arm/mach-stm32mp/Kconfig
> @@ -46,6 +46,7 @@ config STM32MP15x
>  	select STM32_RESET
>  	select STM32_SERIAL
>  	select SYS_ARCH_TIMER
> +	imply CMD_NVEDIT_INFO
>  	imply SYSRESET_PSCI if TFABOOT
>  	imply SYSRESET_SYSCON if !TFABOOT
>  	help
> diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h
> index f271b84a59..e927787be0 100644
> --- a/include/configs/stm32mp1.h
> +++ b/include/configs/stm32mp1.h
> @@ -155,9 +155,7 @@
>  	"splashimage=0xc4300000\0"  \
>  	"ramdisk_addr_r=0xc4400000\0" \
>  	"altbootcmd=run bootcmd\0" \
> -	"env_default=1\0" \
> -	"env_check=if test $env_default -eq 1;"\
> -		" then env set env_default 0;env save;fi\0" \
> +	"env_check=if env info -p -d; then env save; fi\0" \
>  	STM32MP_BOOTCMD \
>  	BOOTENV \
>  	"boot_net_usb_start=true\0"

Reviewed-by: Patrice Chotard <patrice.chotard@st.com>

Thanks
diff mbox series

Patch

diff --git a/arch/arm/mach-stm32mp/Kconfig b/arch/arm/mach-stm32mp/Kconfig
index 6c995ed8d8..478fd2f17d 100644
--- a/arch/arm/mach-stm32mp/Kconfig
+++ b/arch/arm/mach-stm32mp/Kconfig
@@ -46,6 +46,7 @@  config STM32MP15x
 	select STM32_RESET
 	select STM32_SERIAL
 	select SYS_ARCH_TIMER
+	imply CMD_NVEDIT_INFO
 	imply SYSRESET_PSCI if TFABOOT
 	imply SYSRESET_SYSCON if !TFABOOT
 	help
diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h
index f271b84a59..e927787be0 100644
--- a/include/configs/stm32mp1.h
+++ b/include/configs/stm32mp1.h
@@ -155,9 +155,7 @@ 
 	"splashimage=0xc4300000\0"  \
 	"ramdisk_addr_r=0xc4400000\0" \
 	"altbootcmd=run bootcmd\0" \
-	"env_default=1\0" \
-	"env_check=if test $env_default -eq 1;"\
-		" then env set env_default 0;env save;fi\0" \
+	"env_check=if env info -p -d; then env save; fi\0" \
 	STM32MP_BOOTCMD \
 	BOOTENV \
 	"boot_net_usb_start=true\0"