diff mbox series

[PATCHv4,13/16] powerpc: p1010rdb: Compile legacy ethernet init function when no DM_ETH

Message ID 20200701165857.39930-14-Zhiqiang.Hou@nxp.com
State Superseded
Delegated to: Priyanka Jain
Headers show
Series powerpc: covert p1010, p1020 and p2020 RDB board to DM_ETH | expand

Commit Message

Zhiqiang Hou July 1, 2020, 4:58 p.m. UTC
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

The board_eth_init() is only used by legacy ethernet driver framework,
so do not compile it when DM_ETH config has been selected.

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
V4:
 - No change.

 board/freescale/p1010rdb/p1010rdb.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Vladimir Oltean July 4, 2020, 8:38 a.m. UTC | #1
On Thu, Jul 02, 2020 at 12:58:54AM +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> 
> The board_eth_init() is only used by legacy ethernet driver framework,
> so do not compile it when DM_ETH config has been selected.
> 
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

> V4:
>  - No change.
> 
>  board/freescale/p1010rdb/p1010rdb.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/board/freescale/p1010rdb/p1010rdb.c b/board/freescale/p1010rdb/p1010rdb.c
> index 66ccc0bd1e..309f4daa88 100644
> --- a/board/freescale/p1010rdb/p1010rdb.c
> +++ b/board/freescale/p1010rdb/p1010rdb.c
> @@ -484,6 +484,7 @@ int checkboard(void)
>  	return 0;
>  }
>  
> +#ifndef CONFIG_DM_ETH
>  int board_eth_init(bd_t *bis)
>  {
>  #ifdef CONFIG_TSEC_ENET
> @@ -524,6 +525,7 @@ int board_eth_init(bd_t *bis)
>  
>  	return pci_eth_init(bis);
>  }
> +#endif
>  
>  #if defined(CONFIG_OF_BOARD_SETUP)
>  void fdt_del_flexcan(void *blob)
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/board/freescale/p1010rdb/p1010rdb.c b/board/freescale/p1010rdb/p1010rdb.c
index 66ccc0bd1e..309f4daa88 100644
--- a/board/freescale/p1010rdb/p1010rdb.c
+++ b/board/freescale/p1010rdb/p1010rdb.c
@@ -484,6 +484,7 @@  int checkboard(void)
 	return 0;
 }
 
+#ifndef CONFIG_DM_ETH
 int board_eth_init(bd_t *bis)
 {
 #ifdef CONFIG_TSEC_ENET
@@ -524,6 +525,7 @@  int board_eth_init(bd_t *bis)
 
 	return pci_eth_init(bis);
 }
+#endif
 
 #if defined(CONFIG_OF_BOARD_SETUP)
 void fdt_del_flexcan(void *blob)