diff mbox series

[PATCHv4,10/16] powerpc: p1_p2_rdb: Don't compile board_eth_init() when DM_ETH enabled

Message ID 20200701165857.39930-11-Zhiqiang.Hou@nxp.com
State Superseded
Delegated to: Priyanka Jain
Headers show
Series powerpc: covert p1010, p1020 and p2020 RDB board to DM_ETH | expand

Commit Message

Z.q. Hou July 1, 2020, 4:58 p.m. UTC
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

The board_eth_init() is only used by legacy ethernet driver framework,
so do not compile it when DM_ETH config has been selected.

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
V4:
 - No change.

 board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Vladimir Oltean July 4, 2020, 8:36 a.m. UTC | #1
On Thu, Jul 02, 2020 at 12:58:51AM +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> 
> The board_eth_init() is only used by legacy ethernet driver framework,
> so do not compile it when DM_ETH config has been selected.
> 
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

> V4:
>  - No change.
> 
>  board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c
> index 3dd6178708..41585cf342 100644
> --- a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c
> +++ b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c
> @@ -359,6 +359,7 @@ int board_early_init_r(void)
>  	return 0;
>  }
>  
> +#ifndef CONFIG_DM_ETH
>  int board_eth_init(bd_t *bis)
>  {
>  	struct fsl_pq_mdio_info mdio_info;
> @@ -406,6 +407,7 @@ int board_eth_init(bd_t *bis)
>  
>  	return pci_eth_init(bis);
>  }
> +#endif
>  
>  #if defined(CONFIG_QE) && \
>  	(defined(CONFIG_TARGET_P1025RDB) || defined(CONFIG_TARGET_P1021RDB))
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c
index 3dd6178708..41585cf342 100644
--- a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c
+++ b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c
@@ -359,6 +359,7 @@  int board_early_init_r(void)
 	return 0;
 }
 
+#ifndef CONFIG_DM_ETH
 int board_eth_init(bd_t *bis)
 {
 	struct fsl_pq_mdio_info mdio_info;
@@ -406,6 +407,7 @@  int board_eth_init(bd_t *bis)
 
 	return pci_eth_init(bis);
 }
+#endif
 
 #if defined(CONFIG_QE) && \
 	(defined(CONFIG_TARGET_P1025RDB) || defined(CONFIG_TARGET_P1021RDB))